From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web09.380.1645807698045269934 for ; Fri, 25 Feb 2022 08:48:18 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Rac05KRH; spf=pass (domain: kernel.org, ip: 139.178.84.217, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 21C9661CF3 for ; Fri, 25 Feb 2022 16:48:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D3C70C340F4 for ; Fri, 25 Feb 2022 16:48:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1645807695; bh=2f7nBp+/GhNfnumj152XAzCCN2nPLnVHayLnHvbTtyc=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=Rac05KRHP1kuhLkUOMc/FBditt2IFRh/WqyqdUN6OCmFXzETNQHTXcPmXZejEO7jr +JWBDLTtNBK4JhQeaNrRMvBNglH+Hma1Eil47BSTV2szOuJK4NK7olxEefDKFn5phn 96IzX7hsB5dG5PixRz7VjmMmWeZg3f+6NlIt+i4FPZqPEe6PSXNuz/HF1C7xLD3Ypc KKc2errvP8vbYZpgdZZby4D9pvUAeWeGncJ8xLB110ciTDcdzzMmOAAfToOYwC36qX zloWQJjOddRcTlpNbgjxoT8tfXBno9HYfUqIIA/BLZiEnL0D4rRWiGqNFqgOcV419z 1vEJ6K9xImNgQ== Received: by mail-yb1-f178.google.com with SMTP id v186so7035518ybg.1 for ; Fri, 25 Feb 2022 08:48:15 -0800 (PST) X-Gm-Message-State: AOAM530VxKGvJGM9dYo0DKRNg+OmBciDQxfMuvVnRR2eoXOfPs0KJCIX uQJL3jY1aWJ9mGhtEvZjO4a4xHCGU9suDecC3CQ= X-Google-Smtp-Source: ABdhPJyhm+h7ZLxRaHBGtC8/SXa16HjgeMZ8FabV0rU/1K8YxbYnzkZDSBTsB0HlFxjb6MKAMGuFD8x31SXD9VnxEJ4= X-Received: by 2002:a25:dc6:0:b0:624:128a:a92c with SMTP id 189-20020a250dc6000000b00624128aa92cmr8272438ybn.533.1645807694868; Fri, 25 Feb 2022 08:48:14 -0800 (PST) MIME-Version: 1.0 References: <20220201180302.743162-1-ardb@kernel.org> In-Reply-To: From: "Ard Biesheuvel" Date: Fri, 25 Feb 2022 17:48:02 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH] ArmVirtPkg/ArmVirtKvmTool: wire up configurable timeout To: edk2-devel-groups-io , Sami Mujawar Cc: Pierre Gondois , "leif@nuviainc.com" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 2 Feb 2022 at 11:04, Sami Mujawar wrote: > > Hi Ard, > > Thank you for this patch. > > The timeout value 5 appears to be standard across platforms, so it looks = good to me. > > Reviewed-by: Sami Mujawar > > Regards, > > Sami Mujawar > Merged as #2547 (with a mention of the change to 5 seconds in the commit lo= g) Thanks all, > =EF=BB=BFOn 02/02/2022, 09:42, "devel@edk2.groups.io on behalf of PierreG= ondois via groups.io" wrote: > > Hi, > The value also gets updated from 3 to 5, is it possible to note it in= the > commit message or to let it to 3 ? > Otherwise the patch looks good to me, > > Reviewed-by: Pierre Gondois > > > On 2/1/22 7:03 PM, Ard Biesheuvel wrote: > > Use the correct PCD type for PcdPlatformBootTimeOut so it gets wire= d up > > to the Timeout EFI variable automatically, which is how the boot ma= nager > > stores the timeout preference. > > > > Signed-off-by: Ard Biesheuvel > > --- > > ArmVirtPkg/ArmVirtKvmTool.dsc | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/ArmVirtPkg/ArmVirtKvmTool.dsc b/ArmVirtPkg/ArmVirtKvmT= ool.dsc > > index a1bf4b9be87b..3bd3ebd6e0b3 100644 > > --- a/ArmVirtPkg/ArmVirtKvmTool.dsc > > +++ b/ArmVirtPkg/ArmVirtKvmTool.dsc > > @@ -170,9 +170,10 @@ [PcdsPatchableInModule.common] > > > > gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase|0x0 > > > > +[PcdsDynamicHii] > > + gEfiMdePkgTokenSpaceGuid.PcdPlatformBootTimeOut|L"Timeout"|gEfiG= lobalVariableGuid|0x0|5 > > + > > [PcdsDynamicDefault.common] > > - gEfiMdePkgTokenSpaceGuid.PcdPlatformBootTimeOut|3 > > - > > gArmTokenSpaceGuid.PcdArmArchTimerSecIntrNum|0x0 > > gArmTokenSpaceGuid.PcdArmArchTimerIntrNum|0x0 > > gArmTokenSpaceGuid.PcdArmArchTimerVirtIntrNum|0x0 > > > > > > > > > IMPORTANT NOTICE: The contents of this email and any attachments are conf= idential and may also be privileged. If you are not the intended recipient,= please notify the sender immediately and do not disclose the contents to a= ny other person, use it for any purpose, or store or copy the information i= n any medium. Thank you. > > >=20 > >