public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ard Biesheuvel" <ardb@kernel.org>
To: devel@edk2.groups.io, lersek@redhat.com
Cc: Michael Brown <mcb30@ipxe.org>,
	kraxel@redhat.com, Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [edk2-devel] [PATCH 2/3] OvmfPkg: Add library to handle TPL from within nested interrupt handlers
Date: Fri, 23 Dec 2022 15:25:52 +0100	[thread overview]
Message-ID: <CAMj1kXGtTOZ7qHxpVLf6UxbHDARCsRLGhnqWZwcuY4SpnYeh=w@mail.gmail.com> (raw)
In-Reply-To: <407d54f4-537d-375a-224c-184fb5e2dff1@redhat.com>

On Wed, 21 Dec 2022 at 09:07, Laszlo Ersek <lersek@redhat.com> wrote:
>
> On 12/20/22 16:02, Michael Brown wrote:
> > On 09/12/2022 15:22, Michael Brown wrote:
> >> On 09/12/2022 15:02, Gerd Hoffmann wrote:
> >>>> Add the Nested Interrupt TPL Library (NestedInterruptTplLib) to
> >>>> provide helper functions that can be used by nested interrupt
> >>>> handlers in place of RaiseTPL()/RestoreTPL().
> >>>
> >>> <snip>
> >>
> >>> The idea looks sane to me and I couldn't spot any logic errors in
> >>> this.
> >>
> >> Great! :)
> >
> > Ping.  Is there anything else that needs to be done before this gets
> > merged?  It would be good to have the regression bug fixed.
> >
> > Thanks,
> >
> > Michael
> >
>
> series
> Acked-by: Laszlo Ersek <lersek@redhat.com>
>
> Ard, can you please help merge this?
>

Sure.

For the ARM case, it seems the situation is slightly different, given
that we reprogram the timer for the next interrupt in
TimerInterruptHandler (), so I don't think we can accumulate pending
interrupts in the same way as x86.

So i'm fine with making this fix specific to OVMF/x86.

Queued as #3829

  reply	other threads:[~2022-12-23 14:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1670328507.git.mcb30@ipxe.org>
2022-12-09 10:20 ` [PATCH 1/3] OvmfPkg: Send EOI before RestoreTPL() in timer interrupt handlers Michael Brown
2022-12-09 10:20 ` [PATCH 2/3] OvmfPkg: Add library to handle TPL from within nested " Michael Brown
2022-12-09 15:02   ` [edk2-devel] " Gerd Hoffmann
2022-12-09 15:22     ` Michael Brown
     [not found]     ` <ac60f07a-df27-bcfd-4129-0d6bfcf7ac77@ipxe.org>
2022-12-20 15:02       ` Michael Brown
2022-12-21  8:06         ` Laszlo Ersek
2022-12-23 14:25           ` Ard Biesheuvel [this message]
2022-12-09 10:20 ` [PATCH 3/3] OvmfPkg: Use NestedInterruptTplLib in " Michael Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMj1kXGtTOZ7qHxpVLf6UxbHDARCsRLGhnqWZwcuY4SpnYeh=w@mail.gmail.com' \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox