From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web11.37413.1685635954229732836 for ; Thu, 01 Jun 2023 09:12:34 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=m5Uh/bA2; spf=pass (domain: kernel.org, ip: 139.178.84.217, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B379B6108D for ; Thu, 1 Jun 2023 16:12:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9677FC433A1 for ; Thu, 1 Jun 2023 16:12:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685635952; bh=9/zbCFqQdRe4MGrVNFCVUc5C8w+P8XA6DvB2shvgPuU=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=m5Uh/bA2Mm+vxCF4adwkCNoLK/A6YNkqnS4/MluMYE9PoQqHkChDoRnpZoWfV/t9Z q9eNy5/ImAZxJ4EJIP1iDCwUFz8cG3zFidEd74nmRcJrUWK2YSxwkZIPXGKe28LDUz Yi7kGFTjFWHDrYR38PN13heNpXI8C9cSoi5avGXjOHOF+7krj0fcViElQY6r9tMhT7 BkpPaspfE0BwuYja+24PXBeh2QCC2L9NF8/31xAyeCL3lmMuHbSEYlJAJrqA9WUPnZ Ki5bkKej6+xZN0pVxoSUtfkr9S7gSmu0F2+K78axb9cMiRcShweJ3IEs9p01HFs59j uehoXnmqa0qXA== Received: by mail-lf1-f49.google.com with SMTP id 2adb3069b0e04-4f3b5881734so1361966e87.0 for ; Thu, 01 Jun 2023 09:12:32 -0700 (PDT) X-Gm-Message-State: AC+VfDz6blDmMu79oeW8mpXQ6p0AsitHcZxPo8idkV8vN6xitfmQ5lFS JyS2G5N3LS16/gweCsOuALsNMsp3OobsSbl2INo= X-Google-Smtp-Source: ACHHUZ7vGIXdgVWSBOl4lJBdQW75njiB3U9/LUpWHzQGM54HxT4kwj6rp4od+JJsHbLsZWfUrUxsglFUaKC5ywSj9RM= X-Received: by 2002:ac2:52b4:0:b0:4f4:dfd4:33df with SMTP id r20-20020ac252b4000000b004f4dfd433dfmr264211lfm.21.1685635950590; Thu, 01 Jun 2023 09:12:30 -0700 (PDT) MIME-Version: 1.0 References: <20230509163212.291333-1-pedro.falcato@gmail.com> In-Reply-To: <20230509163212.291333-1-pedro.falcato@gmail.com> From: "Ard Biesheuvel" Date: Thu, 1 Jun 2023 18:12:19 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 00/12] OvmfPkg: Replace the OVMF-specific SataControllerDxe with the generic one To: Pedro Falcato Cc: devel@edk2.groups.io, Laszlo Ersek , Ard Biesheuvel , Jiewen Yao , Gerd Hoffmann , Erdem Aktas , James Bottomley , Min Xu , Tom Lendacky , Michael Roth , Rebecca Cran , Peter Grehan , =?UTF-8?Q?Corvin_K=C3=B6hne?= , Sebastien Boeuf , Anthony Perard , Julien Grall Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 9 May 2023 at 18:32, Pedro Falcato wrote: > > This patch-set replaces the OVMF specific SataControllerDxe with the MdeM= odulePkg/Bus/Pci one. > They were both forked from the same code, and are code-and-functionality = similar. As such, there > seems to be no need for duplication here. > > The first four pages both replay OvmfPkg/SataControllerDxe commits and fi= x up a couple of details. > The rest of the patches (minus the last) replace OvmfPkg/SataControllerDx= e with the MdeModulePkg variant. > The last patch, finally, removes the thing. > > Tested by booting in QEMU (Q35 (AHCI) and PC (IDE)). > More testing from other, alternative platforms is desired, although break= age seems unlikely. > > This patchset (or at least, the last patch) depends on the edk2-platforms= patch series to get merged. > > (+CC Laszlo as the author of the original SataControllerDxe patches) > > Cc: Ard Biesheuvel > Cc: Jiewen Yao > Cc :Jordan Justen > Cc: Gerd Hoffmann > Cc: Erdem Aktas > Cc: James Bottomley > Cc: Min Xu > Cc: Tom Lendacky > Cc: Michael Roth > Cc: Rebecca Cran > Cc: Peter Grehan > Cc: Corvin K=C3=B6hne > Cc: Sebastien Boeuf > Cc: Anthony Perard > Cc: Julien Grall > Cc: Laszlo Ersek > > Changes: > v2: > - Address Laszlo's feedback wrt commit to port into MdeModulePkg > - Address Laszlo's feedback wrt how to split the removal of the driver = and the patches for each sub-platform maintainer > - Address Mike Maslenkin's feedback on the preexisting ASSERTs (Private= !=3D NULL) > - Add Gerd's ACK and Tested-by (conservatively) to patches 6 and 12 (si= nce they are remotely QEMU related) > > Pedro Falcato (12): > MdeModulePkg/SataControllerDxe: Clean up error handling in Start() > MdeModulePkg/SataControllerDxe: Log expected errors at DEBUG_INFO > level > MdeModulePkg/SataControllerDxe: Remove useless null check > MdeModulePkg/SataControllerDxe: Fix up ASSERTS (Private !=3D NULL) > OvmfPkg: Replace the OVMF-specific SataControllerDxe > OvmfPkg/Microvm: Replace the OVMF-specific SataControllerDxe > OvmfPkg/Bhyve: Replace the OVMF-specific SataControllerDxe > OvmfPkg/CloudHv: Replace the OVMF-specific SataControllerDxe > OvmfPkg/IntelTdx: Replace the OVMF-specific SataControllerDxe > OvmfPkg/AmdSev: Replace the OVMF-specific SataControllerDxe > OvmfPkg/Xen: Replace the OVMF-specific SataControllerDxe > OvmfPkg: Remove SataControllerDxe > What is the state of this series? Are we waiting for the MdeModulePkg changes to be picked up, and do the OVMF changes have to wait for that?