From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web11.120197.1671059293090947311 for ; Wed, 14 Dec 2022 15:08:13 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=vMVHX8Va; spf=pass (domain: kernel.org, ip: 139.178.84.217, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4995961C52 for ; Wed, 14 Dec 2022 23:08:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AB993C433F0 for ; Wed, 14 Dec 2022 23:08:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1671059291; bh=E3CPlVJeNc07SdtZbKLd3uISuUBIwYMHD3O3XSYYZkg=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=vMVHX8Vafq6kG88Z6qdr4NIqMvj3qrRavGpf+YMHmclz9tPqapu/RcWOM881JEEtD cUeBnqniWCm+GGaPdYtr9RvL1gBIDUhOGW0XLFhahBUzE/H2vQE1fowMDtnPWqlBNd T+qL+s0joi3DSLh/0+VTCr1HVlwwS8QYAH9dBsmyasYt8gMhcrXAV43ebqIcvLd9A1 Qa2bmt5eu0JJjB5qwNRBdE1aUfO09k3npsk4vMlN6XYcM0KkqWbdQ3iwaVDzsnvqAE rUSWRhYLwJF00O8Yu6uhicEco3dB7MstLHpWUd5NIh+dNoKvMqTNCX+Cq7wN65m6ff 2vMtnDH1b3Zcw== Received: by mail-lf1-f47.google.com with SMTP id g7so12976498lfv.5 for ; Wed, 14 Dec 2022 15:08:11 -0800 (PST) X-Gm-Message-State: ANoB5pkHkH/3r9ryDDYVRh+x7myeG4SNq58JrSQlQQD+Nn7MubDAqGLl R4AOm4godtsENUHRRSxY8i0hYZPH8fR5XUxXQRM= X-Google-Smtp-Source: AA0mqf7tYsuItn4LaqFrTN98XGpFx85YiLmMx9yM1jum0YI2xtA99MfGd6U63WSt6/qwkSc/Og1EVYXdJhQ5a7rEaX0= X-Received: by 2002:a19:6b19:0:b0:4a2:740b:5b02 with SMTP id d25-20020a196b19000000b004a2740b5b02mr30911711lfa.122.1671059289673; Wed, 14 Dec 2022 15:08:09 -0800 (PST) MIME-Version: 1.0 References: <20221214225252.1660-1-mikuback@linux.microsoft.com> <20221214225252.1660-14-mikuback@linux.microsoft.com> In-Reply-To: <20221214225252.1660-14-mikuback@linux.microsoft.com> From: "Ard Biesheuvel" Date: Thu, 15 Dec 2022 00:07:58 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 13/14] ArmPkg: Turn off spellcheck audit mode To: mikuback@linux.microsoft.com Cc: devel@edk2.groups.io, Leif Lindholm , Ard Biesheuvel , Sami Mujawar Content-Type: text/plain; charset="UTF-8" On Wed, 14 Dec 2022 at 23:53, wrote: > > From: Michael Kubacki > > Audit mode was enabled for the spellcheck CI plugin. It is no longer > needed with recent changes. Spelling errors can be checked in the > package moving forward. > > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Cc: Sami Mujawar > Signed-off-by: Michael Kubacki Will this patch result in PRs potentially being rejected by pre-merge CI due to trivial spelling errors? > --- > ArmPkg/ArmPkg.ci.yaml | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/ArmPkg/ArmPkg.ci.yaml b/ArmPkg/ArmPkg.ci.yaml > index c8dface6821a..a304c7966cf7 100644 > --- a/ArmPkg/ArmPkg.ci.yaml > +++ b/ArmPkg/ArmPkg.ci.yaml > @@ -87,7 +87,7 @@ > > ## options defined .pytool/Plugin/SpellCheck > "SpellCheck": { > - "AuditOnly": True, > + "AuditOnly": False, > "IgnoreFiles": [ > "Library/ArmSoftFloatLib/berkeley-softfloat-3/**" > ], # use gitignore syntax to ignore errors > @@ -148,6 +148,7 @@ > "fcmplt", > "ffreestanding", > "frsub", > + "hauser", > "hisilicon", > "iccabpr", > "iccbpr", > -- > 2.28.0.windows.1 >