From: "Ard Biesheuvel" <ardb@kernel.org>
To: edk2-devel-groups-io <devel@edk2.groups.io>,
Gerd Hoffmann <kraxel@redhat.com>
Cc: "Pawel Polawski" <ppolawsk@redhat.com>,
"Liming Gao" <gaoliming@byosoft.com.cn>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Jiewen Yao" <jiewen.yao@intel.com>,
"Abner Chang" <abner.chang@hpe.com>,
"Ard Biesheuvel" <ardb+tianocore@kernel.org>,
"Ray Ni" <ray.ni@intel.com>, "Hao A Wu" <hao.a.wu@intel.com>,
"Jian J Wang" <jian.j.wang@intel.com>,
"Jordan Justen" <jordan.l.justen@intel.com>,
"Leif Lindholm" <leif@nuviainc.com>
Subject: Re: [edk2-devel] [PATCH 1/6] PciHostBridge: io range is not mandatory
Date: Thu, 16 Dec 2021 10:53:58 +0100 [thread overview]
Message-ID: <CAMj1kXGwvbs3hnovpKhvYv9romvKnSxZeSbWDnFdQDq-RcAOuw@mail.gmail.com> (raw)
In-Reply-To: <20211216095037.1843149-2-kraxel@redhat.com>
On Thu, 16 Dec 2021 at 10:50, Gerd Hoffmann <kraxel@redhat.com> wrote:
>
> io range is not mandatory according to pcie spec,
> so allow bridge configurations without io address
> space assigned.
>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
> ---
> MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c b/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c
> index b20bcd310ad5..51a3b987967f 100644
> --- a/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c
> +++ b/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c
> @@ -1085,6 +1085,9 @@ NotifyPhase (
> RootBridge->ResAllocNode[Index].Base = BaseAddress;
> RootBridge->ResAllocNode[Index].Status = ResAllocated;
> DEBUG ((DEBUG_INFO, "Success\n"));
> + } else if (Index == TypeIo) {
> + /* optional on PCIe */
> + DEBUG ((DEBUG_INFO, "No IO\n"));
> } else {
> ReturnStatus = EFI_OUT_OF_RESOURCES;
> DEBUG ((DEBUG_ERROR, "Out Of Resource!\n"));
> --
> 2.33.1
>
>
>
>
>
>
next prev parent reply other threads:[~2021-12-16 9:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-16 9:50 [PATCH 0/6] OvmfPkg/Microvm/pcie: add pcie support Gerd Hoffmann
2021-12-16 9:50 ` [PATCH 1/6] PciHostBridge: io range is not mandatory Gerd Hoffmann
2021-12-16 9:53 ` Ard Biesheuvel [this message]
2021-12-16 9:50 ` [PATCH 2/6] FdtPciHostBridgeLib: " Gerd Hoffmann
2021-12-16 9:50 ` [PATCH 3/6] OvmfPkg/PlatformPei: unfix PcdPciExpressBaseAddress Gerd Hoffmann
2021-12-16 12:50 ` [edk2-devel] " Ard Biesheuvel
2021-12-17 6:33 ` Gerd Hoffmann
2021-12-16 9:50 ` [PATCH 4/6] OvmfPkg/Microvm/pcie: no vbeshim please Gerd Hoffmann
2021-12-16 9:50 ` [PATCH 5/6] OvmfPkg/Microvm/pcie: mPhysMemAddressWidth tweak Gerd Hoffmann
2021-12-16 9:50 ` [PATCH 6/6] OvmfPkg/Microvm/pcie: add pcie support Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMj1kXGwvbs3hnovpKhvYv9romvKnSxZeSbWDnFdQDq-RcAOuw@mail.gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox