From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by mx.groups.io with SMTP id smtpd.web12.8754.1639648454710608144 for ; Thu, 16 Dec 2021 01:54:15 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=seCswkJy; spf=pass (domain: kernel.org, ip: 145.40.68.75, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 5C920B82322 for ; Thu, 16 Dec 2021 09:54:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2290EC36AE6 for ; Thu, 16 Dec 2021 09:54:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1639648451; bh=oeAJo/v1TXNgg9zzTxrkfeHSoVmkS06B5ft+xeRg9AA=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=seCswkJyaYxLHwJ3HMXQKhXmeoAyEWt0FO+tQqJfNc0MIkAqmoFd81oLU2OZjW09w RqwZzFJZu2WzBRL8T0uis2kXS/NH3V8cuuRRfH4PT8LbjC/0qsFPVkcOv9fNJSik9y Y8CQXk0RK7Z4U6dKnY8cwPBYHsa/ROuI+3Vx3+C9lCzL/OU8iFQ+J4OboxeI2LY+WE Kz+arLdfUdE9wAEo+LOWVqLsTFZnAbCOYuIH6dJsILXVnVUk0jlfS5TWGBAUzngXmL uCwjn/2mpayV5cc12MQ+7nD7DZkeG85Y41sdUdHeJN59mXo/COwvMXHtXuzYwnXlvJ l+uhf5T7LZi+A== Received: by mail-wr1-f48.google.com with SMTP id e5so9683084wrc.5 for ; Thu, 16 Dec 2021 01:54:11 -0800 (PST) X-Gm-Message-State: AOAM532ynF+EuH3MpIwVFPBGEZFj3FpGm9/cfYLU3Axg1AJvuppgRnty 51hwYr6mK17RJGcjqEMHJkZoHena/lJzbW2N6Fo= X-Google-Smtp-Source: ABdhPJxovVjx5vNXLKSdRvxI3wACeI0Mx4J0hmw1pCbWwMuh+gJB7TV0ZcgMXAeC8rBbVTprBdozPjVcwDSmzigQQxY= X-Received: by 2002:adf:bbd0:: with SMTP id z16mr3951907wrg.447.1639648449483; Thu, 16 Dec 2021 01:54:09 -0800 (PST) MIME-Version: 1.0 References: <20211216095037.1843149-1-kraxel@redhat.com> <20211216095037.1843149-2-kraxel@redhat.com> In-Reply-To: <20211216095037.1843149-2-kraxel@redhat.com> From: "Ard Biesheuvel" Date: Thu, 16 Dec 2021 10:53:58 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH 1/6] PciHostBridge: io range is not mandatory To: edk2-devel-groups-io , Gerd Hoffmann Cc: Pawel Polawski , Liming Gao , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= , Jiewen Yao , Abner Chang , Ard Biesheuvel , Ray Ni , Hao A Wu , Jian J Wang , Jordan Justen , Leif Lindholm Content-Type: text/plain; charset="UTF-8" On Thu, 16 Dec 2021 at 10:50, Gerd Hoffmann wrote: > > io range is not mandatory according to pcie spec, > so allow bridge configurations without io address > space assigned. > > Signed-off-by: Gerd Hoffmann Reviewed-by: Ard Biesheuvel > --- > MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c b/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c > index b20bcd310ad5..51a3b987967f 100644 > --- a/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c > +++ b/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c > @@ -1085,6 +1085,9 @@ NotifyPhase ( > RootBridge->ResAllocNode[Index].Base = BaseAddress; > RootBridge->ResAllocNode[Index].Status = ResAllocated; > DEBUG ((DEBUG_INFO, "Success\n")); > + } else if (Index == TypeIo) { > + /* optional on PCIe */ > + DEBUG ((DEBUG_INFO, "No IO\n")); > } else { > ReturnStatus = EFI_OUT_OF_RESOURCES; > DEBUG ((DEBUG_ERROR, "Out Of Resource!\n")); > -- > 2.33.1 > > > > > >