From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by mx.groups.io with SMTP id smtpd.web08.5597.1659507841486858305 for ; Tue, 02 Aug 2022 23:24:02 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ShTlqSIL; spf=pass (domain: kernel.org, ip: 145.40.68.75, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id EF98DB821A4 for ; Wed, 3 Aug 2022 06:23:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9D39AC433D7 for ; Wed, 3 Aug 2022 06:23:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1659507837; bh=tG93ei1EMqHNTQI0PznMSqy96w/dny6gcs6U9J0E3HQ=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=ShTlqSILPbIfDMInlXUj7Uhd9CEF4Kyhf3onHZL4OZOG9ahUnZKID/1DzlJTrJIv3 7whozh735NF7aSa5VSuk8lCVI9aN3R5a/JU+aYMqmbqQz+Uj82kuXgHTk6oy9qgO/Q RLLRO20YzM8Gaw8NzVv1XMdl+LkeotlzCYaKpK50FW3afzSfPEKvD3aOUhzKEttROi wzBsWw+Wqoa3ppia2vHP3SWUGQLfX9fCocdGv372Bb4uUaJU6yjsSFFGNKwc00WeID HHctA1AQj8C31mmE9suWaRWCjLSTBNfqSPoKBvGsFGd36B7Tp1Sy0afjvPLyM+qjKN CYyYN/q+wm/Dg== Received: by mail-oa1-f51.google.com with SMTP id 586e51a60fabf-10cf9f5b500so19786208fac.2 for ; Tue, 02 Aug 2022 23:23:57 -0700 (PDT) X-Gm-Message-State: ACgBeo2ePvJu3hzaojyvHGHeAXBdtm9QfuLW0a8YsYWiM7hyKHRQ9LZV jpLmHP0sxA9E1cc4VQPWQSaSpicCM2i7DItNrag= X-Google-Smtp-Source: AA6agR4cHwMcl4uEelnbo9HNC+W8mTstrwJxolUGqorBMkt6TnZUiFngvMJgsN/E31G3Y8Dv05H/DZvdMrHXrn9nQok= X-Received: by 2002:a05:6870:a90a:b0:10d:9e83:98a6 with SMTP id eq10-20020a056870a90a00b0010d9e8398a6mr1202897oab.228.1659507836772; Tue, 02 Aug 2022 23:23:56 -0700 (PDT) MIME-Version: 1.0 References: <20220802180418.880-1-mikuback@linux.microsoft.com> <20220802180418.880-2-mikuback@linux.microsoft.com> In-Reply-To: <20220802180418.880-2-mikuback@linux.microsoft.com> From: "Ard Biesheuvel" Date: Wed, 3 Aug 2022 08:23:46 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v1 1/5] ArmPlatformPkg/NorFlashDxe: Remove unused debug print specifier To: Michael Kubacki Cc: edk2-devel-groups-io , Leif Lindholm Content-Type: text/plain; charset="UTF-8" On Tue, 2 Aug 2022 at 20:04, wrote: > > From: Michael Kubacki > > These debug messages are repeated in both NorFlashBlockIoReadBlocks() > and NorFlashBlockIoWriteBlocks(): > > "NorFlashBlockIoWriteBlocks(MediaId=0x%x, Lba=%ld, BufferSize=0x%x" > "bytes (%d kB), BufferPtr @ 0x%08x)\n" > > Although this requires 5 arguments, only 4 are provided. The kilobyte > value was never given. > > This change removes that specifier so the 4 arguments match the 4 > specifiers in the debug macro. > > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Signed-off-by: Michael Kubacki Reviewed-by: Ard Biesheuve; > --- > ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashBlockIoDxe.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashBlockIoDxe.c b/ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashBlockIoDxe.c > index 5afab0a79fa2..e671108e2bcf 100644 > --- a/ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashBlockIoDxe.c > +++ b/ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashBlockIoDxe.c > @@ -54,7 +54,7 @@ NorFlashBlockIoReadBlocks ( > Instance = INSTANCE_FROM_BLKIO_THIS (This); > Media = This->Media; > > - DEBUG ((DEBUG_BLKIO, "NorFlashBlockIoReadBlocks(MediaId=0x%x, Lba=%ld, BufferSize=0x%x bytes (%d kB), BufferPtr @ 0x%08x)\n", MediaId, Lba, BufferSizeInBytes, Buffer)); > + DEBUG ((DEBUG_BLKIO, "NorFlashBlockIoReadBlocks(MediaId=0x%x, Lba=%ld, BufferSize=0x%x bytes, BufferPtr @ 0x%08x)\n", MediaId, Lba, BufferSizeInBytes, Buffer)); > > if (!Media) { > Status = EFI_INVALID_PARAMETER; > @@ -89,7 +89,7 @@ NorFlashBlockIoWriteBlocks ( > > Instance = INSTANCE_FROM_BLKIO_THIS (This); > > - DEBUG ((DEBUG_BLKIO, "NorFlashBlockIoWriteBlocks(MediaId=0x%x, Lba=%ld, BufferSize=0x%x bytes (%d kB), BufferPtr @ 0x%08x)\n", MediaId, Lba, BufferSizeInBytes, Buffer)); > + DEBUG ((DEBUG_BLKIO, "NorFlashBlockIoWriteBlocks(MediaId=0x%x, Lba=%ld, BufferSize=0x%x bytes, BufferPtr @ 0x%08x)\n", MediaId, Lba, BufferSizeInBytes, Buffer)); > > if ( !This->Media->MediaPresent ) { > Status = EFI_NO_MEDIA; > -- > 2.28.0.windows.1 >