From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 4AFB1AC1820 for ; Tue, 12 Sep 2023 14:59:00 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=u0XpHUeL/rSmzPzGC494aqvgmnvEq9brcB0l42E4liM=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1694530739; v=1; b=SIXAGJg/KU1ZnbbVgrp2yDPgzrO/Dxwmum5NMTM68Erx3HIXTb5FmqrcAZTkNDY4XJPNmphy +Pa3efkjNxpoAhU5k0jjCH9rbJcS2/L23wgWZZcGnCoWpekKbSBXBaplRtQFJalVyIGj15cBDHf i+XPqtIRTMpG72lo59kvHLY0= X-Received: by 127.0.0.2 with SMTP id 5KiXYY7687511xhDjT2gMWpG; Tue, 12 Sep 2023 07:58:59 -0700 X-Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by mx.groups.io with SMTP id smtpd.web11.27471.1694530738010898191 for ; Tue, 12 Sep 2023 07:58:58 -0700 X-Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 0FA92CE1B06 for ; Tue, 12 Sep 2023 14:58:56 +0000 (UTC) X-Received: by smtp.kernel.org (Postfix) with ESMTPSA id 49B3FC433CC for ; Tue, 12 Sep 2023 14:58:54 +0000 (UTC) X-Received: by mail-lj1-f172.google.com with SMTP id 38308e7fff4ca-2bcb89b476bso97997461fa.1 for ; Tue, 12 Sep 2023 07:58:54 -0700 (PDT) X-Gm-Message-State: 1hhH6dfJf9yo300auK1dMArJx7686176AA= X-Google-Smtp-Source: AGHT+IFvl9TSrOOCgwjzpxCvzKVKIS97KJAtWSuCbzvOH4GKUOwekXsBWFA2XlOul6SydbEo8ZqbGNPm0opes0EfGeE= X-Received: by 2002:a2e:b0d6:0:b0:2bc:ffcc:6cc0 with SMTP id g22-20020a2eb0d6000000b002bcffcc6cc0mr17616ljl.17.1694530732440; Tue, 12 Sep 2023 07:58:52 -0700 (PDT) MIME-Version: 1.0 References: <20230912141849.75147-1-lersek@redhat.com> In-Reply-To: <20230912141849.75147-1-lersek@redhat.com> From: "Ard Biesheuvel" Date: Tue, 12 Sep 2023 16:58:41 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH] OvmfPkg: raise DXEFV size to 14.5 MB in the traditional platform FDFs To: Laszlo Ersek Cc: devel@edk2.groups.io, Ard Biesheuvel , Gerd Hoffmann , Jiewen Yao , Jordan Justen Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ardb@kernel.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="SIXAGJg/"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Tue, 12 Sept 2023 at 16:19, Laszlo Ersek wrote: > > My usual IA32X64 and X64 builds fail for the NOOPT target, using GCC5: > > - IA32X64: > > > the required fv image size 0xdef130 exceeds the set fv image size > > 0xd00000 > > - X64: > > > the required fv image size 0xd8f7b8 exceeds the set fv image size > > 0xd00000 > > NOOPT is important for debugging (less confusing behavior with gdb, and > much less confusing disassembly). > > Raise the DXEFV size to 14.5 MB (14 MB would work, but cut it too close > for IA32X64). > > After this patch: > > - IA32: > > > DXEFV [83%Full] 15204352 (0xe80000) total, 12718784 (0xc212c0) used, > > 2485568 (0x25ed40) free > > - IA32X64: > > > DXEFV [96%Full] 15204352 (0xe80000) total, 14610736 (0xdef130) used, > > 593616 (0x90ed0) free > > - X64: > > > DXEFV [93%Full] 15204352 (0xe80000) total, 14219192 (0xd8f7b8) used, > > 985160 (0xf0848) free > ... > > Cc: Ard Biesheuvel > Cc: Gerd Hoffmann > Cc: Jiewen Yao > Cc: Jordan Justen > Signed-off-by: Laszlo Ersek Acked-by: Ard Biesheuvel > --- > OvmfPkg/OvmfPkgIa32.fdf | 6 +++--- > OvmfPkg/OvmfPkgIa32X64.fdf | 6 +++--- > OvmfPkg/OvmfPkgX64.fdf | 6 +++--- > 3 files changed, 9 insertions(+), 9 deletions(-) > > diff --git a/OvmfPkg/OvmfPkgIa32.fdf b/OvmfPkg/OvmfPkgIa32.fdf > index 4c9be963a74d..383613e54b14 100644 > --- a/OvmfPkg/OvmfPkgIa32.fdf > +++ b/OvmfPkg/OvmfPkgIa32.fdf > @@ -62,10 +62,10 @@ [FD.OVMF_CODE] > > [FD.MEMFD] > BaseAddress = $(MEMFD_BASE_ADDRESS) > -Size = 0xE00000 > +Size = 0xF80000 > ErasePolarity = 1 > BlockSize = 0x10000 > -NumBlocks = 0xE0 > +NumBlocks = 0xF8 > > 0x000000|0x006000 > gUefiOvmfPkgTokenSpaceGuid.PcdOvmfSecPageTablesBase|gUefiOvmfPkgTokenSpaceGuid.PcdOvmfSecPageTablesSize > @@ -86,7 +86,7 @@ [FD.MEMFD] > gUefiOvmfPkgTokenSpaceGuid.PcdOvmfPeiMemFvBase|gUefiOvmfPkgTokenSpaceGuid.PcdOvmfPeiMemFvSize > FV = PEIFV > > -0x100000|0xD00000 > +0x100000|0xE80000 > gUefiOvmfPkgTokenSpaceGuid.PcdOvmfDxeMemFvBase|gUefiOvmfPkgTokenSpaceGuid.PcdOvmfDxeMemFvSize > FV = DXEFV > > diff --git a/OvmfPkg/OvmfPkgIa32X64.fdf b/OvmfPkg/OvmfPkgIa32X64.fdf > index 7f599f15e341..3cec3d0c8790 100644 > --- a/OvmfPkg/OvmfPkgIa32X64.fdf > +++ b/OvmfPkg/OvmfPkgIa32X64.fdf > @@ -62,10 +62,10 @@ [FD.OVMF_CODE] > > [FD.MEMFD] > BaseAddress = $(MEMFD_BASE_ADDRESS) > -Size = 0xE00000 > +Size = 0xF80000 > ErasePolarity = 1 > BlockSize = 0x10000 > -NumBlocks = 0xE0 > +NumBlocks = 0xF8 > > 0x000000|0x006000 > gUefiOvmfPkgTokenSpaceGuid.PcdOvmfSecPageTablesBase|gUefiOvmfPkgTokenSpaceGuid.PcdOvmfSecPageTablesSize > @@ -86,7 +86,7 @@ [FD.MEMFD] > gUefiOvmfPkgTokenSpaceGuid.PcdOvmfPeiMemFvBase|gUefiOvmfPkgTokenSpaceGuid.PcdOvmfPeiMemFvSize > FV = PEIFV > > -0x100000|0xD00000 > +0x100000|0xE80000 > gUefiOvmfPkgTokenSpaceGuid.PcdOvmfDxeMemFvBase|gUefiOvmfPkgTokenSpaceGuid.PcdOvmfDxeMemFvSize > FV = DXEFV > > diff --git a/OvmfPkg/OvmfPkgX64.fdf b/OvmfPkg/OvmfPkgX64.fdf > index 41912fc1bece..9c35b6e848a2 100644 > --- a/OvmfPkg/OvmfPkgX64.fdf > +++ b/OvmfPkg/OvmfPkgX64.fdf > @@ -62,10 +62,10 @@ [FD.OVMF_CODE] > > [FD.MEMFD] > BaseAddress = $(MEMFD_BASE_ADDRESS) > -Size = 0xE00000 > +Size = 0xF80000 > ErasePolarity = 1 > BlockSize = 0x10000 > -NumBlocks = 0xE0 > +NumBlocks = 0xF8 > > 0x000000|0x006000 > gUefiOvmfPkgTokenSpaceGuid.PcdOvmfSecPageTablesBase|gUefiOvmfPkgTokenSpaceGuid.PcdOvmfSecPageTablesSize > @@ -101,7 +101,7 @@ [FD.MEMFD] > gUefiOvmfPkgTokenSpaceGuid.PcdOvmfPeiMemFvBase|gUefiOvmfPkgTokenSpaceGuid.PcdOvmfPeiMemFvSize > FV = PEIFV > > -0x100000|0xD00000 > +0x100000|0xE80000 > gUefiOvmfPkgTokenSpaceGuid.PcdOvmfDxeMemFvBase|gUefiOvmfPkgTokenSpaceGuid.PcdOvmfDxeMemFvSize > FV = DXEFV > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108539): https://edk2.groups.io/g/devel/message/108539 Mute This Topic: https://groups.io/mt/101315785/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-