From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 13548AC0DC7 for ; Wed, 18 Oct 2023 08:51:21 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=qA2j4F8K6tVuD+zdn4OC3uFJXJMCiSOpAhqY65jgcpI=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1697619080; v=1; b=BXx8ZKJho6oZQ2kOocUZVuK3warw9VJuuhGN8jeWdK2J2uqUJyROP0mTWzojCzCLL6422PMW UFKIcejXNJGZLme6u8RzE3XE88/baeMSQtmBD1jDWzjZa4/d3WJK1Fzh7p9Kipyvizc0SUlpL4S lXjTlUpUjizQKoWXSjoEspy8= X-Received: by 127.0.0.2 with SMTP id 5ZGaYY7687511xgrAMUOnvyM; Wed, 18 Oct 2023 01:51:20 -0700 X-Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web10.277515.1697619079934985309 for ; Wed, 18 Oct 2023 01:51:20 -0700 X-Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 684B861705 for ; Wed, 18 Oct 2023 08:51:19 +0000 (UTC) X-Received: by smtp.kernel.org (Postfix) with ESMTPSA id 19377C433C9 for ; Wed, 18 Oct 2023 08:51:19 +0000 (UTC) X-Received: by mail-lj1-f173.google.com with SMTP id 38308e7fff4ca-2c514cbbe7eso54813781fa.1 for ; Wed, 18 Oct 2023 01:51:19 -0700 (PDT) X-Gm-Message-State: s7xdmEzFxHTjym0xtccZvOQMx7686176AA= X-Google-Smtp-Source: AGHT+IFKZm+rrGQJSaZAGViMZcffNteozAfMkEAFqMSO/JsgN1Yp6AnSVkRrI2nTcR9sCUDo2rWs6Wkff+qQssJmmEk= X-Received: by 2002:a05:651c:1416:b0:2c5:14f9:aa1 with SMTP id u22-20020a05651c141600b002c514f90aa1mr3036555lje.15.1697619077316; Wed, 18 Oct 2023 01:51:17 -0700 (PDT) MIME-Version: 1.0 References: <0048beef351cf6fb6646a171c0a6eb01f2d3829f.1688071551.git.jbrasen@nvidia.com> <8d01f157-ad20-421d-a1e1-9aebeba1f028@bsdio.com> In-Reply-To: <8d01f157-ad20-421d-a1e1-9aebeba1f028@bsdio.com> From: "Ard Biesheuvel" Date: Wed, 18 Oct 2023 10:51:06 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH] ArmPkg/ArmPsciMpServices Add EFI_NOT_READY return To: devel@edk2.groups.io, rebecca@bsdio.com Cc: Jeff Brasen , quic_llindhol@quicinc.com, ardb+tianocore@kernel.org Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ardb@kernel.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=BXx8ZKJh; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Tue, 17 Oct 2023 at 00:55, Rebecca Cran wrote: > > Reviewed-by: Rebecca Cran > > > Looks like this is still waiting to be merged by an ArmPkg maintainer. > > Thanks for the reminder Really queued up now > > On 6/29/23 14:46, Jeff Brasen wrote: > > Add EFI_NOT_READY return if the CPU can not be enabled if the > > processor is already on. > > > > This can occur in normal use if the CPU is still being turned off from > > a previous call when this is called again. > > > > Signed-off-by: Jeff Brasen > > --- > > ArmPkg/Drivers/ArmPsciMpServicesDxe/ArmPsciMpServicesDxe.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/ArmPkg/Drivers/ArmPsciMpServicesDxe/ArmPsciMpServicesDxe.c b/ArmPkg/Drivers/ArmPsciMpServicesDxe/ArmPsciMpServicesDxe.c > > index f822a9877c..e7f4223513 100644 > > --- a/ArmPkg/Drivers/ArmPsciMpServicesDxe/ArmPsciMpServicesDxe.c > > +++ b/ArmPkg/Drivers/ArmPsciMpServicesDxe/ArmPsciMpServicesDxe.c > > @@ -103,7 +103,9 @@ DispatchCpu ( > > > > ArmCallSmc (&Args); > > > > - if (Args.Arg0 != ARM_SMC_PSCI_RET_SUCCESS) { > > + if (Args.Arg0 == ARM_SMC_PSCI_RET_ALREADY_ON) { > > + Status = EFI_NOT_READY; > > + } else if (Args.Arg0 != ARM_SMC_PSCI_RET_SUCCESS) { > > DEBUG ((DEBUG_ERROR, "PSCI_CPU_ON call failed: %d\n", Args.Arg0)); > > Status = EFI_DEVICE_ERROR; > > } > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109716): https://edk2.groups.io/g/devel/message/109716 Mute This Topic: https://groups.io/mt/99859167/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-