From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web10.18045.1683873600183870415 for ; Thu, 11 May 2023 23:40:00 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=cz+pJ+de; spf=pass (domain: kernel.org, ip: 139.178.84.217, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A0A1461B2D for ; Fri, 12 May 2023 06:39:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EA2F8C433A1 for ; Fri, 12 May 2023 06:39:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683873598; bh=r2JBUmTrZZA//jmfhXSjT9xJB5Zd6z9W+co66+z73jM=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=cz+pJ+deakISufIqKBq8hK8rgiSw25ho41DK407sE7vDz0Aub3AwDmvJVf0jHwCwv xuhmYV3J77iNm1Vak/j6m835D+UuL5c5Ft0w+iOUxhhhziqHLrKLxnNO9EBdy88At6 OeNZ9ALfB3CzIK9fYJjBrvmUdzrWAjjbzF7Nwx5tGjUe/TRVzGRSQwOVMqhPMKAREW mMT/x1FMfjYt/lJRLFELlvRFfGzW8ac0RRI3gIJqa0vSxe0xeQ5oyu+DazyIwPmoRj MScMLo3xFlhEV+gegNmRip6kidNN6qt2y3qPz/Kg6Ks9muk99d5fpfmiHAKOhwQk1K 6PQK7A3MknMsg== Received: by mail-lf1-f54.google.com with SMTP id 2adb3069b0e04-4f14f266b72so8526134e87.1 for ; Thu, 11 May 2023 23:39:58 -0700 (PDT) X-Gm-Message-State: AC+VfDxisg09XzLEVBCNnO+I3aWyQNWC4fXeGHHGvyGrwxknOUhpm1U8 L3EXHbxi2NdcG9xQadZBs72FVdUNYZIEso0bO08= X-Google-Smtp-Source: ACHHUZ4tRNcJEER7GCMyHlesdFdCcWZ0SfIqfFUKHUcmRm4Slg17inIj1Ri8IzpJ7Feer1/9AOP2DrqoU2pr7IL1tzA= X-Received: by 2002:a05:6512:3881:b0:4ed:be06:9e9a with SMTP id n1-20020a056512388100b004edbe069e9amr3073225lft.26.1683873596888; Thu, 11 May 2023 23:39:56 -0700 (PDT) MIME-Version: 1.0 References: <20230510145008.1893553-1-ardb@kernel.org> In-Reply-To: From: "Ard Biesheuvel" Date: Fri, 12 May 2023 08:39:45 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH] BaseTools/tools_def: Disable overzealous unused variable warning on Clang To: devel@edk2.groups.io, kraxel@redhat.com Cc: Rebecca Cran , Liming Gao Content-Type: text/plain; charset="UTF-8" Liming: I'd like to merge this one for the stable tag - any objections? On Thu, 11 May 2023 at 06:55, Gerd Hoffmann wrote: > > On Wed, May 10, 2023 at 04:50:08PM +0200, Ard Biesheuvel wrote: > > The warnings Clang emits when enabling -Wunneeded-internal-declaration > > (which is part of -Wall) are generating false positives for variables > > whose size gets taken but are not referenced beyond that. > > > > This may happen legitimately in debug code, so let's disable this > > warning for Clang, rather than tiptoe around it in the code base. > > > > This fixes the RELEASE build for OVMF, which triggers this issue in the > > newly added VirtioSerialDxe driver. > > > > Cc: Rebecca Cran > > Cc: Gerd Hoffmann > > Cc: Liming Gao > > Signed-off-by: Ard Biesheuvel > > Acked-by: Gerd Hoffmann > > > > > >