public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ard Biesheuvel" <ardb@kernel.org>
To: "Ni, Ray" <ray.ni@intel.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	Rebecca Cran <rebecca@bsdio.com>,  Andrew Fish <afish@apple.com>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>,
	 "Liu, Zhiguang" <zhiguang.liu@intel.com>
Subject: Re: [edk2-devel] Is Xcode5ExceptionHandlerAsm.nasm still needed?
Date: Thu, 30 Mar 2023 18:47:30 +0200	[thread overview]
Message-ID: <CAMj1kXH+h20hN_gCbCEtact1Q-dPLn4h9ioizyWWV7-MbPa1nA@mail.gmail.com> (raw)
In-Reply-To: <CAMj1kXGbr__N8cS1HmKPZSagxPf_DoZZatjZRxwxccZk+KM6rw@mail.gmail.com>

On Thu, 30 Mar 2023 at 18:33, Ard Biesheuvel <ardb@kernel.org> wrote:
>
> On Thu, 30 Mar 2023 at 17:04, Ard Biesheuvel <ardb@kernel.org> wrote:
> >
> > On Thu, 30 Mar 2023 at 16:25, Ni, Ray <ray.ni@intel.com> wrote:
> > >
> > > I am afraid they are not template code.
> > > That means if nx is set for data section, they can not be executed.
> > >
> >
> > Currently, we fix up the entries by writing to the .text section at
> > runtime, so NX seems out of scope in any case.
> >
> > Someone should check Xcode5, but for LLD, adding  -Wl,-z,notext is
> > sufficient to work around the error.
>
> As far as I could figure out, '-read_only_relocs suppress' does the
> same thing as '-z notext' on the GNU linker, and permits the code to
> be built with the absolute relocations in the .text section.
>
> AFAICT, this means we don't need the runtime fixups, nor do we need to
> move that code out of .text
>
> i'll respin the series I sent out earlier today with that if I manage
> to build a working OVMF.fd with XCODE5

Hmm seems we are already using that for XCODE5.

  reply	other threads:[~2023-03-30 16:47 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-30 10:16 Is Xcode5ExceptionHandlerAsm.nasm still needed? Ni, Ray
2023-03-30 10:48 ` [edk2-devel] " Ard Biesheuvel
2023-03-30 11:47   ` Ard Biesheuvel
2023-03-30 14:25     ` Ni, Ray
2023-03-30 15:04       ` Ard Biesheuvel
2023-03-30 16:33         ` Ard Biesheuvel
2023-03-30 16:47           ` Ard Biesheuvel [this message]
2023-03-30 16:54           ` Rebecca Cran
2023-03-30 17:03             ` Ard Biesheuvel
2023-03-30 15:30 ` Michael D Kinney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMj1kXH+h20hN_gCbCEtact1Q-dPLn4h9ioizyWWV7-MbPa1nA@mail.gmail.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox