From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by mx.groups.io with SMTP id smtpd.web12.4622.1665397127630794265 for ; Mon, 10 Oct 2022 03:18:48 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=moHH44kC; spf=pass (domain: kernel.org, ip: 145.40.73.55, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 87246CE10E7 for ; Mon, 10 Oct 2022 10:18:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B0291C4347C for ; Mon, 10 Oct 2022 10:18:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1665397122; bh=mG910whrOPvO4OpT8TEna25Y8lQViwUvvxTKVwPtioE=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=moHH44kCAQtT/jNVfXcAhvdT99ojGPunZ9dpGFCsw0OHijDlu1nWuWOgJAbZSn8a8 sBKmCD6j4EXjnxrltM2b8XlZnohQRx1wdSIBOICyE/PQ1z80Tw7/ddsHzQ9Zys9jJ5 XCeTCIqrkgLYYXdiHe0JfRNA2AfgyU8AcUI9lPwGTgkQ0k8DKTI15Vp81NLVm7VudT xYluJoOGKUCM18F/N2xcycoJqcph2ZzDOKU5xAELmeuBWx+XeHg96ozhSJki39kTkB vRe0RXmD9D0z2yBD5h0qHOEW3nesURR2EJWgMWD/vVlLBckB1Vf1aBVEhhpeV0uhU3 0cnHqpe09NdFA== Received: by mail-lj1-f179.google.com with SMTP id a25so6690569ljk.0 for ; Mon, 10 Oct 2022 03:18:42 -0700 (PDT) X-Gm-Message-State: ACrzQf1E4+4vHnfM7I3HfNS3GLYfA5EEWzRsQmNFlWxSOhQeRanGSxvC mw3NNfZVKnBp+9/NgCziDoP3Sl0a1hp1obi0LEA= X-Google-Smtp-Source: AMsMyM4K6F4/Mnclgudv2eTilE3Ka4ZtZRKwJQ0aDZXW0Y/qiEj0xU58exDGgZqzC2hqjYj4ypBqc3D4r9meMGhfryc= X-Received: by 2002:a05:651c:b13:b0:26c:679f:ea66 with SMTP id b19-20020a05651c0b1300b0026c679fea66mr7001738ljr.516.1665397120732; Mon, 10 Oct 2022 03:18:40 -0700 (PDT) MIME-Version: 1.0 References: <20220817143503.3279277-1-dimitrije.pavlov@arm.com> In-Reply-To: From: "Ard Biesheuvel" Date: Mon, 10 Oct 2022 12:18:29 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH v1 1/1] OvmfPkg/VirtioNetDxe: Check ChildHandle argument in GetControllerName To: devel@edk2.groups.io, samer.el-haj-mahmoud@arm.com Cc: Sunny Wang , Dimitrije Pavlov , Ard Biesheuvel , Jiewen Yao , Liming Gao , Jeff Booher-Kaeding Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 28 Sept 2022 at 15:32, Samer El-Haj-Mahmoud wrote: > > Hi Ard, > > Any luck getting this one merged? > Merged #3460 into master. Thanks, > > -----Original Message----- > > From: Sunny Wang > > Sent: Friday, August 19, 2022 10:47 AM > > To: Dimitrije Pavlov ; devel@edk2.groups.io > > Cc: Ard Biesheuvel ; Jiewen Yao > > ; Liming Gao ; Jeff > > Booher-Kaeding ; Samer El-Haj-Mahmoud > > ; Sunny Wang > > Subject: RE: [PATCH v1 1/1] OvmfPkg/VirtioNetDxe: Check ChildHandle arg= ument > > in GetControllerName > > > > Looks good. > > Reviewed-by: Sunny Wang > > > > -----Original Message----- > > From: Dimitrije Pavlov > > Sent: 17 August 2022 15:35 > > To: devel@edk2.groups.io > > Cc: Ard Biesheuvel ; Jiewen Yao > > ; Liming Gao ; Sunny > > Wang ; Jeff Booher-Kaeding > Kaeding@arm.com>; Samer El-Haj-Mahmoud > Mahmoud@arm.com> > > Subject: [PATCH v1 1/1] OvmfPkg/VirtioNetDxe: Check ChildHandle argumen= t in > > GetControllerName > > > > Per the UEFI specification, a device driver implementation should retur= n > > EFI_UNSUPPORTED if the ChildHandle argument in > > EFI_COMPONENT_NAME2_PROTOCOL.GetControllerName() is not NULL. > > > > Cc: Ard Biesheuvel > > Cc: Jiewen Yao > > Cc: Liming Gao > > Cc: Sunny Wang > > Cc: Jeff Booher-Kaeding > > Cc: Samer El-Haj-Mahmoud > > > > Signed-off-by: Dimitrije Pavlov > > --- > > OvmfPkg/VirtioNetDxe/ComponentName.c | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/OvmfPkg/VirtioNetDxe/ComponentName.c > > b/OvmfPkg/VirtioNetDxe/ComponentName.c > > index e340ca2f8fe4..718096630f6f 100644 > > --- a/OvmfPkg/VirtioNetDxe/ComponentName.c > > +++ b/OvmfPkg/VirtioNetDxe/ComponentName.c > > @@ -129,6 +129,13 @@ VirtioNetGetControllerName ( > > return EFI_INVALID_PARAMETER; > > } > > > > + // > > + // This is a device driver, so ChildHandle must be NULL. > > + // > > + if (ChildHandle !=3D NULL) { > > + return EFI_UNSUPPORTED; > > + } > > + > > // > > // confirm that the device is managed by this driver, using the Virt= Io > > // Protocol > > -- > > 2.37.2 > > > > IMPORTANT NOTICE: The contents of this email and any attachments are conf= idential and may also be privileged. If you are not the intended recipient,= please notify the sender immediately and do not disclose the contents to a= ny other person, use it for any purpose, or store or copy the information i= n any medium. Thank you. > > >=20 > >