From: "Ard Biesheuvel" <ardb@kernel.org>
To: devel@edk2.groups.io, thomas.lendacky@amd.com,
Michael Kinney <michael.d.kinney@intel.com>,
Michael Kubacki <mikuback@linux.microsoft.com>,
Sean Brogan <sean.brogan@microsoft.com>
Cc: Mikolaj Lisik <lisik@google.com>,
Gerd Hoffmann <kraxel@redhat.com>,
pedro.falcato@gmail.com, erdemaktas@google.com,
jejb@linux.ibm.com, jiewen.yao@intel.com, min.m.xu@intel.com,
michael.roth@amd.com
Subject: Re: [edk2-devel] [PATCH v2] OvmfPkg: Create additional PML1 entries for large SEV-SNP VMs
Date: Sat, 3 Jun 2023 01:03:31 +0200 [thread overview]
Message-ID: <CAMj1kXH05W6w=AeXTWaRDa4XEmJ7EjxYPk4r7s3Oz6L-+X50ag@mail.gmail.com> (raw)
In-Reply-To: <CAMj1kXGcBELZDpVF4RR5VUYv9fvpbWR15o+QvprFLuu=16fTwQ@mail.gmail.com>
On Sat, 3 Jun 2023 at 00:49, Ard Biesheuvel <ardb@kernel.org> wrote:
>
> On Fri, 2 Jun 2023 at 23:20, Lendacky, Thomas via groups.io
> <thomas.lendacky=amd.com@groups.io> wrote:
> >
> > On 1/26/23 14:26, Mikolaj Lisik wrote:
> > > Edk2 was failing, rather than creating more PML4 entries, when they
> > > weren't present in the initial memory acceptance flow. Because of that
> > > VMs with more than 512G memory were crashing. This code fixes that.
> > >
> > > This change affects only SEV-SNP VMs.
> > >
> > > The code was tested by successfully booting a 512G SEV-SNP VM.
> > >
> > > Signed-off-by: Mikolaj Lisik <lisik@google.com>
> >
> > I don't see where this was merged. Both Gerd and I acked it back in
> > January, was there a problem with it?
> >
>
> I wasn't cc'ed.
>
> I've queued this up now.
>
PR here
https://github.com/tianocore/edk2/pull/4473
CI is spuriously failing again.
(cc Mike + Mike + Sean)
Could someone please push the merge button on this? Thanks.
next prev parent reply other threads:[~2023-06-02 23:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-26 20:26 [PATCH v2] OvmfPkg: Create additional PML1 entries for large SEV-SNP VMs Mikolaj Lisik
2023-01-27 8:27 ` [edk2-devel] " Gerd Hoffmann
2023-01-27 15:29 ` Lendacky, Thomas
2023-06-02 21:20 ` Lendacky, Thomas
2023-06-02 22:49 ` [edk2-devel] " Ard Biesheuvel
2023-06-02 23:03 ` Ard Biesheuvel [this message]
2023-06-02 23:56 ` Lendacky, Thomas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMj1kXH05W6w=AeXTWaRDa4XEmJ7EjxYPk4r7s3Oz6L-+X50ag@mail.gmail.com' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox