From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web11.769.1685747026718267112 for ; Fri, 02 Jun 2023 16:03:46 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=lGVy6nrm; spf=pass (domain: kernel.org, ip: 139.178.84.217, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3171961F72 for ; Fri, 2 Jun 2023 23:03:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 20B80C433A4 for ; Fri, 2 Jun 2023 23:03:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685747025; bh=BB0ELAWJmZegsLvSZi7nX5S0o5vQseRsy/GBdPEvhsA=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=lGVy6nrmTOJus2pOPenMJ2cl3TEaSU/W/eibbNEQI7R9xfHfpdt/nzvap0IgMH5tK 41cvOexdKtUFuyeYV8J8hfp9dl990EzKzj0kxyzZvjTF5sQEF5YgnbV61euHn0kZor +lK1QfE0uM0fmpb856vUAcyTsOeyIfp1IZ4cguIs1txn8zhMkssGi2PiyEhC+cxI4d BwI5g+M7Xw1RMvN/+3SO9S02QACl/2WxSwfweBjD4RUnJklwCsAhUVf6xbqutOGMnr 0I4cOsOYkWkGgdfYi40ugWsg2vpivlxFw87pwZE8CSpZRlJp2VWj5m9Gsww4CgO4XU U0dFeH7Bcdesg== Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-4f4b384c09fso3541780e87.3 for ; Fri, 02 Jun 2023 16:03:45 -0700 (PDT) X-Gm-Message-State: AC+VfDxABnc57djm02zSi9uXpCuwm1utwqY9M5NtUnEFbqRLk+8NXTeG l5cUP2Z9qIpi0IUfwPXclaLlfbIMMW7N5JWZhYU= X-Google-Smtp-Source: ACHHUZ4k1/33XONjl8fqWAEfLKfYJ781kRDxzBd8T+rG38OXWifH/ZzpdiF9/5/ORW6MaJksIJnxxQyOttjBbg35NFU= X-Received: by 2002:a2e:999a:0:b0:2a8:ba49:a811 with SMTP id w26-20020a2e999a000000b002a8ba49a811mr800654lji.25.1685747022991; Fri, 02 Jun 2023 16:03:42 -0700 (PDT) MIME-Version: 1.0 References: <9d9d8bb2-ac6f-0339-738e-44c6d50f286b@amd.com> In-Reply-To: From: "Ard Biesheuvel" Date: Sat, 3 Jun 2023 01:03:31 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH v2] OvmfPkg: Create additional PML1 entries for large SEV-SNP VMs To: devel@edk2.groups.io, thomas.lendacky@amd.com, Michael Kinney , Michael Kubacki , Sean Brogan Cc: Mikolaj Lisik , Gerd Hoffmann , pedro.falcato@gmail.com, erdemaktas@google.com, jejb@linux.ibm.com, jiewen.yao@intel.com, min.m.xu@intel.com, michael.roth@amd.com Content-Type: text/plain; charset="UTF-8" On Sat, 3 Jun 2023 at 00:49, Ard Biesheuvel wrote: > > On Fri, 2 Jun 2023 at 23:20, Lendacky, Thomas via groups.io > wrote: > > > > On 1/26/23 14:26, Mikolaj Lisik wrote: > > > Edk2 was failing, rather than creating more PML4 entries, when they > > > weren't present in the initial memory acceptance flow. Because of that > > > VMs with more than 512G memory were crashing. This code fixes that. > > > > > > This change affects only SEV-SNP VMs. > > > > > > The code was tested by successfully booting a 512G SEV-SNP VM. > > > > > > Signed-off-by: Mikolaj Lisik > > > > I don't see where this was merged. Both Gerd and I acked it back in > > January, was there a problem with it? > > > > I wasn't cc'ed. > > I've queued this up now. > PR here https://github.com/tianocore/edk2/pull/4473 CI is spuriously failing again. (cc Mike + Mike + Sean) Could someone please push the merge button on this? Thanks.