From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 376D574003A for ; Fri, 18 Aug 2023 12:32:21 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=7iqmX6AqIz022POofeMk9H39FR8Chkf2+i+XOXOWmmI=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20140610; t=1692361940; v=1; b=JWmU0X06OfvI91qE/eSOTxNND2AgdxMwYF7qUKunN77btILqUkwZpBBNTQoezGxFssyK3Sl1 3MZPD5u6LZzfBOx/gDMULu5v+sZoIK59ScSn7PhxZByziX79ITXWtpBE6zqH3/cxmonB+0qXhr0 DcQsF5uvGrpeLJ+2QFuwdbWk= X-Received: by 127.0.0.2 with SMTP id Mo3CYY7687511xkLbphmB0jm; Fri, 18 Aug 2023 05:32:20 -0700 X-Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web11.10153.1692361939883085000 for ; Fri, 18 Aug 2023 05:32:20 -0700 X-Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5872264F5B for ; Fri, 18 Aug 2023 12:32:19 +0000 (UTC) X-Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4AE7AC433D9 for ; Fri, 18 Aug 2023 12:32:18 +0000 (UTC) X-Received: by mail-lf1-f54.google.com with SMTP id 2adb3069b0e04-4fe3b86cec1so1230182e87.2 for ; Fri, 18 Aug 2023 05:32:18 -0700 (PDT) X-Gm-Message-State: qlBlsB4a2XDDgAnzEZqiLzuPx7686176AA= X-Google-Smtp-Source: AGHT+IFk7CqsZGnKg9j1zmnbb4D/NiySwrBR7XzqYHsvTXHKhj3zBizi0TfiZNheUxDnz0eQLImmDewxyUdXCSWHvRI= X-Received: by 2002:a05:6512:3d15:b0:4fd:d016:c2e8 with SMTP id d21-20020a0565123d1500b004fdd016c2e8mr2130070lfv.43.1692361936161; Fri, 18 Aug 2023 05:32:16 -0700 (PDT) MIME-Version: 1.0 References: <20230724130006.427522-1-corvink@FreeBSD.org> <20230724130006.427522-2-corvink@FreeBSD.org> <899bbdac-5aa3-50c4-f6e2-926b7a22c799@bsdio.com> <47a7e3eb-2049-bbc3-3e74-0c115f00702e@linux.microsoft.com> <35b68f61774b96e6b68e72c6ca056a10d2601087.camel@FreeBSD.org> In-Reply-To: From: "Ard Biesheuvel" Date: Fri, 18 Aug 2023 14:32:04 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH v1 1/1] OvmfPkg/Bhyve: build platform info HOB To: devel@edk2.groups.io, corvink@freebsd.org, "Liming Gao (Byosoft address)" Cc: mikuback@linux.microsoft.com, Rebecca Cran , Michael Kinney , Jiewen Yao , Jordan Justen , Gerd Hoffmann , Peter Grehan Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ardb@kernel.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=JWmU0X06; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Tue, 15 Aug 2023 at 10:10, Ard Biesheuvel wrote: > > On Mon, 14 Aug 2023 at 10:15, Corvin K=C3=B6hne wro= te: > > > > On Thu, 2023-08-10 at 15:54 -0400, Michael Kubacki wrote: > > > I'm not sure why test results are not being reported that may be a > > > larger issue. > > > > > > I pulled the branch locally, run uncrustify, and it automatically > > > fixed > > > the code to pass. > > > > > > The issue is the following function call: > > > > > > BuildPlatformInfoHob(); > > > > > > Should be: > > > > > > BuildPlatformInfoHob (); > > > > > > > I already run uncrustify locally but it doesn't complain about it. > > Thank you! > > > > Should I resend an updated patch? > > Can this change make it into edk-stable202308? Otherwise, fwcfg won't > > be usable by bhyve in this version. > > > > It is up to Liming to decide but given that > > - it is low risk as it only touches bhyve platform code > - i would have merged it already if bugs in the CI wouldn't have > prevented me from doing so > > I would be in favour of including this change I accidentally pushed this change to master by pushing it to a branch that was already associated with a PR with the push label set. I will leave it to Liming and the stewards to decide whether to leave it or revert it. Apologies - I wasn't expecting this to be permitted by the CI rules during the freeze. -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107851): https://edk2.groups.io/g/devel/message/107851 Mute This Topic: https://groups.io/mt/100327419/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-