From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web10.47992.1679502025102001989 for ; Wed, 22 Mar 2023 09:20:25 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=h9r3YSXT; spf=pass (domain: kernel.org, ip: 139.178.84.217, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5E740621CD for ; Wed, 22 Mar 2023 16:20:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C76BAC4339B for ; Wed, 22 Mar 2023 16:20:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679502023; bh=2H6KQ/vzY96FwHPPPzXDbXXhBaZJ7lhHJoBQsCWLmfg=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=h9r3YSXTdhDCxj4dUVUXyKo2z+IvoxGVToPkm+wCrzNVlIvrY2olhe86J5UHiiRjz Ye0isOeZuA5GbBFpRWKwoCxzirtKNbGj7n3YQul0h7k506ar+cmNfUW4Yo9vg0eMsT 7VJJ4vZcJinHlncXdCPmU0AZXX7gMpZXDn3RMAcg5aTU0Zn4wZN5HJx/V22+brRSpv ctFxRd/6fLizIgViIIWWLA7G4pDFRIu3SwGR0Ba8hrBNuRRm5aXGQxt1kz2t6ZmdLN umQtjjq/+TFN8s8bqHdXuwQ4J5spsYQYPfulsHIzWbfVcz1LYJfNWes5ApTDua3dGp rYub9HUWyxGtw== Received: by mail-lf1-f52.google.com with SMTP id x17so24138511lfu.5 for ; Wed, 22 Mar 2023 09:20:23 -0700 (PDT) X-Gm-Message-State: AAQBX9dlidoFy0A+bsbT6Sa8ZISiJAazVQ4/hF5CDUgs2U43/oU6ITHH w4EPUh0WcaDu6FrZCrlFgQ+eXCejyVtOYF+GHP4= X-Google-Smtp-Source: AK7set/XjdAaTB22kC+6R4KflsTQ2TodvqsNXXnAjz71b4T738ongUd8YWThs8ZXSNREb9CyeZV5XUxilnDou9CkDzk= X-Received: by 2002:ac2:53a2:0:b0:4ea:e0e7:d131 with SMTP id j2-20020ac253a2000000b004eae0e7d131mr2100495lfh.4.1679502021819; Wed, 22 Mar 2023 09:20:21 -0700 (PDT) MIME-Version: 1.0 References: <20230317121921.219205-1-kraxel@redhat.com> In-Reply-To: <20230317121921.219205-1-kraxel@redhat.com> From: "Ard Biesheuvel" Date: Wed, 22 Mar 2023 17:20:10 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH 1/1] OvmfPkg/PlatformBootManagerLib: use utf8 for the serial console. To: devel@edk2.groups.io, kraxel@redhat.com Cc: Pawel Polawski , Oliver Steffen , Jordan Justen , Jiewen Yao , Ard Biesheuvel Content-Type: text/plain; charset="UTF-8" On Fri, 17 Mar 2023 at 13:19, Gerd Hoffmann wrote: > > Time to leave behind relics from the last century and arrive in the > modern world. Drop PC-ANSI Terminal Type for the serial console, use > UTF-8 instead. > > Signed-off-by: Gerd Hoffmann No objections here but how will I be able to observe the difference? > --- > OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.h | 4 ++-- > OvmfPkg/Library/PlatformBootManagerLib/PlatformData.c | 6 +++--- > 2 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.h b/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.h > index 1676d61616d8..18b3deb9db59 100644 > --- a/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.h > +++ b/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.h > @@ -126,7 +126,7 @@ extern VENDOR_DEVICE_PATH gTerminalTypeDeviceNode; > 1 \ > } > > -#define gPcAnsiTerminal \ > +#define gVtUtf8Terminal \ > { \ > { \ > MESSAGING_DEVICE_PATH, \ > @@ -136,7 +136,7 @@ extern VENDOR_DEVICE_PATH gTerminalTypeDeviceNode; > (UINT8) ((sizeof (VENDOR_DEVICE_PATH)) >> 8) \ > } \ > }, \ > - DEVICE_PATH_MESSAGING_PC_ANSI \ > + DEVICE_PATH_MESSAGING_VT_UTF8 \ > } > > #define gEndEntire \ > diff --git a/OvmfPkg/Library/PlatformBootManagerLib/PlatformData.c b/OvmfPkg/Library/PlatformBootManagerLib/PlatformData.c > index 6536d9fe369e..c1801725c2c8 100644 > --- a/OvmfPkg/Library/PlatformBootManagerLib/PlatformData.c > +++ b/OvmfPkg/Library/PlatformBootManagerLib/PlatformData.c > @@ -47,7 +47,7 @@ typedef struct { > ACPI_HID_DEVICE_PATH gPnpPs2KeyboardDeviceNode = gPnpPs2Keyboard; > ACPI_HID_DEVICE_PATH gPnp16550ComPortDeviceNode = gPnp16550ComPort; > UART_DEVICE_PATH gUartDeviceNode = gUart; > -VENDOR_DEVICE_PATH gTerminalTypeDeviceNode = gPcAnsiTerminal; > +VENDOR_DEVICE_PATH gTerminalTypeDeviceNode = gVtUtf8Terminal; > > // > // Platform specific keyboard device path > @@ -83,7 +83,7 @@ VENDOR_UART_DEVICE_PATH gDebugAgentUartDevicePath = { > 0, // Parity - Default > 0, // StopBits - Default > }, > - gPcAnsiTerminal, > + gVtUtf8Terminal, > gEndEntire > }; > > @@ -168,7 +168,7 @@ STATIC VENDOR_UART_DEVICE_PATH gXenConsoleDevicePath = { > FixedPcdGet8 (PcdUartDefaultParity), > FixedPcdGet8 (PcdUartDefaultStopBits), > }, > - gPcAnsiTerminal, > + gVtUtf8Terminal, > gEndEntire > }; > > -- > 2.39.2 > > > > > >