From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
 by mx.groups.io with SMTP id smtpd.web08.1120.1613674163396718100
 for <devel@edk2.groups.io>;
 Thu, 18 Feb 2021 10:49:23 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@kernel.org header.s=k20201202 header.b=lU32kOWv;
 spf=pass (domain: kernel.org, ip: 198.145.29.99, mailfrom: ardb@kernel.org)
Received: by mail.kernel.org (Postfix) with ESMTPSA id AFA3064EB4
	for <devel@edk2.groups.io>; Thu, 18 Feb 2021 18:49:22 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1613674162;
	bh=abVBD+EzoiHxqC/91VjZR0iVY7xqAI9sIf3a6dNLGzM=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=lU32kOWvicDWpkATU+gT2hSuGMFIV+yfsr1WAFQvg7ajrl/VIgHdlk5soaJUdjdyE
	 x30vLxaRvDx7aFluGqwDqqTmcwhTJ+zJrCCKsYGSVsSxzXUnJ/SJNw5KCvX+Y6/iiW
	 oLls99GguhktpikpRotvX7iiP9a797F2dzlg3qm1oxiJtDvRgRn8klpfC8n5u9ifa/
	 8qg/PnvLSuNcS3qvoZ36bDeIPk2RB5KUjVAMMM5qjYeHeTJ6ZCtSKt178VqMi5O7RR
	 ekauvWgglYZ3qnFd5r7xP/0mxYLE3oShinmW8znMCbWCDA39CHf1dWbVj6r3ou7lnx
	 kqvNhT5YVse4Q==
Received: by mail-oi1-f169.google.com with SMTP id y199so3106620oia.4
        for <devel@edk2.groups.io>; Thu, 18 Feb 2021 10:49:22 -0800 (PST)
X-Gm-Message-State: AOAM530S3XMCoalJ+x7rlBx5wqz+fGwteW6TOgbNuoJVqj23e4hlWFFS
	ZFtdW0z5C3Yrv3xOR5s/6IMMuyu1XI1l719V1kc=
X-Google-Smtp-Source: ABdhPJwNCJlmEBiJRmQMrC0N9AhahUUeOf3UeE1KNRYaH5js+OaRtbfN8vQZ2feFur91RNG0JgPWFtByj98I6gbdc+8=
X-Received: by 2002:aca:b6c1:: with SMTP id g184mr3830063oif.47.1613674161923;
 Thu, 18 Feb 2021 10:49:21 -0800 (PST)
MIME-Version: 1.0
References: <20210217061809.307479-1-lintonrjeremy@gmail.com>
In-Reply-To: <20210217061809.307479-1-lintonrjeremy@gmail.com>
From: "Ard Biesheuvel" <ardb@kernel.org>
Date: Thu, 18 Feb 2021 19:49:10 +0100
X-Gmail-Original-Message-ID: <CAMj1kXH179EnhDmP0=XoBvuWdMtxsoD+9Vk=KrkN7WZLq5NgJQ@mail.gmail.com>
Message-ID: <CAMj1kXH179EnhDmP0=XoBvuWdMtxsoD+9Vk=KrkN7WZLq5NgJQ@mail.gmail.com>
Subject: Re: [PATCH v3 0/4] RPi: SD/WiFi ACPI updates
To: jlinton <lintonrjeremy@gmail.com>
Cc: devel@edk2.groups.io, Peter Batard <pete@akeo.ie>, 
	Andrei Warkentin <awarkentin@vmware.com>, Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com>, 
	Leif Lindholm <leif@nuviainc.com>, Ard Biesheuvel <ardb+tianocore@kernel.org>, 
	Jeremy Linton <jeremy.linton@arm.com>
Content-Type: text/plain; charset="UTF-8"

On Wed, 17 Feb 2021 at 07:18, jlinton <lintonrjeremy@gmail.com> wrote:
>
> From: Jeremy Linton <jeremy.linton@arm.com>
>
> The existing RPi3 ACPI entries for the Arasan
> and SDHCI controllers need updating to work
> with the RPi4. This is done by adding a caps
> override for the legacy Arasan controller and
> then adding an entirely new entry for the newer
> eMMC2 controller.
>
> Then we flip the default routing to make the eMMC2
> the default for the SD card, so that the WiFi can
> start working on the Arasan.
>
> Additional we add a menu item to enable the SDMA/ADMA2
> modes on the controller.
>
> v2->v3: Various small review tweaks, whitespace, wording
>             spelling, etc.
>
> v1->v2: Add option for user to enable/disable eMMC DMA
>         Only enable the emmc2 table on rpi4 &
>             !Arasan routing
>         Move emmc2 into its own SSDT and drop
>             second _DMA entry
>
> Jeremy Linton (4):
>   Platform/RaspberryPi: Add Negative table check
>   Platform/RaspberryPi/Acpitables: Add eMMC2 device and tweak Arasan
>   Platform/RaspberryPi: User control of eMMC2 DMA
>   Platform/RaspberryPi: Invert default Arasan, eMMC2 routing
>

Could you please resend these in a way that I can apply them? They
seem to have gone through some QP mangling filter, with long lines
broken and newlines doubled in some cases (depending on the line
ending mode of the file, it seems)

https://pastebin.com/yG74aygV


>  Platform/RaspberryPi/AcpiTables/AcpiTables.inf     |   1 +
>  Platform/RaspberryPi/AcpiTables/Emmc.asl           | 129 +++++++++++++++++++++
>  Platform/RaspberryPi/AcpiTables/Sdhc.asl           |  18 ++-
>  Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c |  26 +++++
>  .../RaspberryPi/Drivers/ConfigDxe/ConfigDxe.inf    |   1 +
>  .../RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.uni |   4 +
>  .../RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.vfr |  17 +++
>  Platform/RaspberryPi/Include/ConfigVars.h          |   8 ++
>  Platform/RaspberryPi/RPi3/RPi3.dsc                 |   1 +
>  Platform/RaspberryPi/RPi4/RPi4.dsc                 |   3 +-
>  Platform/RaspberryPi/RPi4/Readme.md                |   2 +-
>  Platform/RaspberryPi/RaspberryPi.dec               |   1 +
>  12 files changed, 206 insertions(+), 5 deletions(-)
>  create mode 100644 Platform/RaspberryPi/AcpiTables/Emmc.asl
>
> --
> 2.13.7
>