From: "Ard Biesheuvel" <ardb@kernel.org>
To: Sami Mujawar <sami.mujawar@arm.com>
Cc: devel@edk2.groups.io, Ard Biesheuvel <ardb+tianocore@kernel.org>,
thomas.abraham@arm.com, Leif Lindholm <leif@nuviainc.com>,
Matteo.Carlini@arm.com, Ben.Adderson@arm.com, nd <nd@arm.com>
Subject: Re: [PATCH edk2-platforms v1 00/12] Platform/ARM: Add support for FVP RevC Model
Date: Sat, 13 Feb 2021 11:26:16 +0100 [thread overview]
Message-ID: <CAMj1kXH2AVUn8mu9psYF3pV3PXDi9bUY0m4OCuP5bqCrvi9_Kw@mail.gmail.com> (raw)
In-Reply-To: <20210212102341.24056-1-sami.mujawar@arm.com>
On Fri, 12 Feb 2021 at 11:24, Sami Mujawar <sami.mujawar@arm.com> wrote:
>
> The Armv8-A Base RevC AEM FVP model includes a SMMUv3 and a PCIe
> subsystem. The FVP RevC model has an AHCI controller that appears
> as a device on the PCIe bus. The model parameters further allow
> a file on the host PC to be exposed as a SATA disk.
>
> AHCI is one of the defined boot mechanisms for a standards-based
> Operating System. Therefore, add support for the FVP RevC model.
>
> More information on the Armv8-A Base RevC AEM FVP model can be
> found at: https://developer.arm.com/tools-and-software/
> simulation-models/fixed-virtual-platforms/arm-ecosystem-models
>
> The ACPI support for RevC model is implemented using Dynamic
> Tables Framework. This enables unification of the firmware
> for FVP_Base_AEMv8A-AEMv8A and FVP_Base_RevC-2xAEMv8A models
> such that the same firmware binary can be used by both models.
>
> The last patch in this series drops support for the traditional
> ACPI tables as these are now redundant.
>
> The changes can be seen at:
> https://github.com/samimujawar/edk2-platforms/tree/1599_fvp_revc_v1
>
> Sami Mujawar (12):
> Platform/ARM/VExpressPkg: FVP RevC SysID.Rev defintion
> Platform/ARM/VExpressPkg: Add PCIe Host Bridge lib for FVP
> Platform/ARM/VExpressPkg: Memory map for FVP RevC model
> Platform/ARM/VExpressPkg: Configure SMMUv3 for FVP RevC
> Platform/ARM/VExpressPkg: Helper macro to map reference token
> Platform/ARM/VExpressPkg: ACPI support for FVP RevC model
> Platform/ARM/VExpressPkg: Add support for FVP RevC model
> Platform/ARM/VExpressPkg: Update ACPI Revision to 6.3
> Platform/ARM/VExpressPkg: Add SMC91x device description
> Platform/ARM/VExpressPkg: Add Virtio Block Device description
> Platform/ARM/VExpressPkg: Make Dynamic Tables Framework default
> Platform/ARM/VExpressPkg: Remove redundant traditional ACPI support
>
For the series,
Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
Pushed as f62887cbb37e..404a76c577fc
Thanks!
> Platform/ARM/VExpressPkg/AcpiTables/AcpiTables.inf | 38 --
> Platform/ARM/VExpressPkg/AcpiTables/Dsdt.asl | 123 -------
> Platform/ARM/VExpressPkg/AcpiTables/Fadt.aslc | 80 -----
> Platform/ARM/VExpressPkg/AcpiTables/FvpPlatform.h | 40 ---
> Platform/ARM/VExpressPkg/AcpiTables/Gtdt.aslc | 169 ---------
> Platform/ARM/VExpressPkg/AcpiTables/Madt.aslc | 85 -----
> Platform/ARM/VExpressPkg/AcpiTables/Spcr.aslc | 82 -----
> Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc | 49 ++-
> Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.fdf | 33 +-
> Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/AslTables/Dsdt.asl | 27 +-
> Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/AslTables/SsdtPci.asl | 204 +++++++++++
> Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c | 376 +++++++++++++++++++-
> Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h | 36 +-
> Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerDxe.inf | 10 +-
> Platform/ARM/VExpressPkg/Drivers/ArmVExpressDxe/ArmFvpDxe.c | 110 +++++-
> Platform/ARM/VExpressPkg/Drivers/ArmVExpressDxe/ArmFvpDxe.inf | 4 +-
> Platform/ARM/VExpressPkg/Include/Platform/RTSM/ArmPlatform.h | 6 +-
> Platform/ARM/VExpressPkg/Include/VExpressMotherBoard.h | 5 +-
> Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/ArmVExpressLib.inf | 12 +-
> Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/RTSMMem.c | 31 +-
> Platform/ARM/VExpressPkg/Library/ArmVExpressPciHostBridgeLib/ArmVExpressPciHostBridgeLib.c | 208 +++++++++++
> Platform/ARM/VExpressPkg/Library/ArmVExpressPciHostBridgeLib/ArmVExpressPciHostBridgeLib.inf | 48 +++
> Platform/ARM/VExpressPkg/Library/ArmVExpressPciHostBridgeLib/ArmVExpressPciHostBridgeLib.uni | 14 +
> 23 files changed, 1124 insertions(+), 666 deletions(-)
> delete mode 100644 Platform/ARM/VExpressPkg/AcpiTables/AcpiTables.inf
> delete mode 100644 Platform/ARM/VExpressPkg/AcpiTables/Dsdt.asl
> delete mode 100644 Platform/ARM/VExpressPkg/AcpiTables/Fadt.aslc
> delete mode 100644 Platform/ARM/VExpressPkg/AcpiTables/FvpPlatform.h
> delete mode 100644 Platform/ARM/VExpressPkg/AcpiTables/Gtdt.aslc
> delete mode 100644 Platform/ARM/VExpressPkg/AcpiTables/Madt.aslc
> delete mode 100644 Platform/ARM/VExpressPkg/AcpiTables/Spcr.aslc
> create mode 100644 Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/AslTables/SsdtPci.asl
> create mode 100644 Platform/ARM/VExpressPkg/Library/ArmVExpressPciHostBridgeLib/ArmVExpressPciHostBridgeLib.c
> create mode 100644 Platform/ARM/VExpressPkg/Library/ArmVExpressPciHostBridgeLib/ArmVExpressPciHostBridgeLib.inf
> create mode 100644 Platform/ARM/VExpressPkg/Library/ArmVExpressPciHostBridgeLib/ArmVExpressPciHostBridgeLib.uni
>
> --
> 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
>
prev parent reply other threads:[~2021-02-13 10:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-12 10:23 [PATCH edk2-platforms v1 00/12] Platform/ARM: Add support for FVP RevC Model Sami Mujawar
2021-02-12 10:23 ` [PATCH edk2-platforms v1 01/12] Platform/ARM/VExpressPkg: FVP RevC SysID.Rev defintion Sami Mujawar
2021-02-12 10:23 ` [PATCH edk2-platforms v1 02/12] Platform/ARM/VExpressPkg: Add PCIe Host Bridge lib for FVP Sami Mujawar
2021-02-12 10:23 ` [PATCH edk2-platforms v1 03/12] Platform/ARM/VExpressPkg: Memory map for FVP RevC model Sami Mujawar
2021-02-12 10:23 ` [PATCH edk2-platforms v1 04/12] Platform/ARM/VExpressPkg: Configure SMMUv3 for FVP RevC Sami Mujawar
2021-02-12 10:23 ` [PATCH edk2-platforms v1 05/12] Platform/ARM/VExpressPkg: Helper macro to map reference token Sami Mujawar
2021-02-12 10:23 ` [PATCH edk2-platforms v1 06/12] Platform/ARM/VExpressPkg: ACPI support for FVP RevC model Sami Mujawar
2021-02-12 10:23 ` [PATCH edk2-platforms v1 07/12] Platform/ARM/VExpressPkg: Add " Sami Mujawar
2021-02-12 10:23 ` [PATCH edk2-platforms v1 08/12] Platform/ARM/VExpressPkg: Update ACPI Revision to 6.3 Sami Mujawar
2021-02-12 10:23 ` [PATCH edk2-platforms v1 09/12] Platform/ARM/VExpressPkg: Add SMC91x device description Sami Mujawar
2021-02-12 10:23 ` [PATCH edk2-platforms v1 10/12] Platform/ARM/VExpressPkg: Add Virtio Block Device description Sami Mujawar
2021-02-12 10:23 ` [PATCH edk2-platforms v1 11/12] Platform/ARM/VExpressPkg: Make Dynamic Tables Framework default Sami Mujawar
2021-02-12 10:23 ` [PATCH edk2-platforms v1 12/12] Platform/ARM/VExpressPkg: Remove redundant traditional ACPI support Sami Mujawar
2021-02-13 10:26 ` Ard Biesheuvel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMj1kXH2AVUn8mu9psYF3pV3PXDi9bUY0m4OCuP5bqCrvi9_Kw@mail.gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox