From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mx.groups.io with SMTP id smtpd.web09.1744.1613211989584144721 for ; Sat, 13 Feb 2021 02:26:29 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=JbKEtk7g; spf=pass (domain: kernel.org, ip: 198.145.29.99, mailfrom: ardb@kernel.org) Received: by mail.kernel.org (Postfix) with ESMTPSA id A564764DEB for ; Sat, 13 Feb 2021 10:26:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1613211988; bh=UA/F5gqIPyiJi81FHc2vb+DXAmxWyCd9m457Qj4moUE=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=JbKEtk7gi7QA4MwTTUjeovjs+xJxDuI1rodaYJPG3YC/VuhAl273DKbBeilTgU0Tn K37ubQt+2ZP0Y0b83k2iN+/4Hh9vyIDmn+IuVDWPlHaAwawqdQGvX1OqzoIZyDnsxt gHizs5A0vMJNOriKMcCownCvuZWl1lkXM2OjJhsbcJfsqM21qKWnDHqpJ5aXL+NKvb AiE6ctLthUJAZkEUFUX+vwJNf26vI+IO8MwpsXWg7iuR1i1diiK5tkiKjeZIQFdQ/3 242KHEar/WkB10Dir/e/9D0bE+oLmSkOFZcxp1KgFlNZUbW00rCGq0Fj/+O0DFrWFu X40gWgpilc5JA== Received: by mail-oo1-f51.google.com with SMTP id g46so456821ooi.9 for ; Sat, 13 Feb 2021 02:26:28 -0800 (PST) X-Gm-Message-State: AOAM5332VOkGDVaQ7pRBI6lEmmJzPNIPEjD6v/NChOmNR7wHUOABW+1j xFFGlyXH7I4Pr0dgpQ6ltGEBbeFnRpqpU4YnG1k= X-Google-Smtp-Source: ABdhPJxWH7tTVsgAUfJv5bO90n4TwchKbY3vNrtN5d/v7pjoxlxm87Q8yRFLA0HNIYdRJYTvntMR51dzirnWSYZwIPU= X-Received: by 2002:a4a:e1e4:: with SMTP id u4mr4866533ood.41.1613211987860; Sat, 13 Feb 2021 02:26:27 -0800 (PST) MIME-Version: 1.0 References: <20210212102341.24056-1-sami.mujawar@arm.com> In-Reply-To: <20210212102341.24056-1-sami.mujawar@arm.com> From: "Ard Biesheuvel" Date: Sat, 13 Feb 2021 11:26:16 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH edk2-platforms v1 00/12] Platform/ARM: Add support for FVP RevC Model To: Sami Mujawar Cc: devel@edk2.groups.io, Ard Biesheuvel , thomas.abraham@arm.com, Leif Lindholm , Matteo.Carlini@arm.com, Ben.Adderson@arm.com, nd Content-Type: text/plain; charset="UTF-8" On Fri, 12 Feb 2021 at 11:24, Sami Mujawar wrote: > > The Armv8-A Base RevC AEM FVP model includes a SMMUv3 and a PCIe > subsystem. The FVP RevC model has an AHCI controller that appears > as a device on the PCIe bus. The model parameters further allow > a file on the host PC to be exposed as a SATA disk. > > AHCI is one of the defined boot mechanisms for a standards-based > Operating System. Therefore, add support for the FVP RevC model. > > More information on the Armv8-A Base RevC AEM FVP model can be > found at: https://developer.arm.com/tools-and-software/ > simulation-models/fixed-virtual-platforms/arm-ecosystem-models > > The ACPI support for RevC model is implemented using Dynamic > Tables Framework. This enables unification of the firmware > for FVP_Base_AEMv8A-AEMv8A and FVP_Base_RevC-2xAEMv8A models > such that the same firmware binary can be used by both models. > > The last patch in this series drops support for the traditional > ACPI tables as these are now redundant. > > The changes can be seen at: > https://github.com/samimujawar/edk2-platforms/tree/1599_fvp_revc_v1 > > Sami Mujawar (12): > Platform/ARM/VExpressPkg: FVP RevC SysID.Rev defintion > Platform/ARM/VExpressPkg: Add PCIe Host Bridge lib for FVP > Platform/ARM/VExpressPkg: Memory map for FVP RevC model > Platform/ARM/VExpressPkg: Configure SMMUv3 for FVP RevC > Platform/ARM/VExpressPkg: Helper macro to map reference token > Platform/ARM/VExpressPkg: ACPI support for FVP RevC model > Platform/ARM/VExpressPkg: Add support for FVP RevC model > Platform/ARM/VExpressPkg: Update ACPI Revision to 6.3 > Platform/ARM/VExpressPkg: Add SMC91x device description > Platform/ARM/VExpressPkg: Add Virtio Block Device description > Platform/ARM/VExpressPkg: Make Dynamic Tables Framework default > Platform/ARM/VExpressPkg: Remove redundant traditional ACPI support > For the series, Reviewed-by: Ard Biesheuvel Pushed as f62887cbb37e..404a76c577fc Thanks! > Platform/ARM/VExpressPkg/AcpiTables/AcpiTables.inf | 38 -- > Platform/ARM/VExpressPkg/AcpiTables/Dsdt.asl | 123 ------- > Platform/ARM/VExpressPkg/AcpiTables/Fadt.aslc | 80 ----- > Platform/ARM/VExpressPkg/AcpiTables/FvpPlatform.h | 40 --- > Platform/ARM/VExpressPkg/AcpiTables/Gtdt.aslc | 169 --------- > Platform/ARM/VExpressPkg/AcpiTables/Madt.aslc | 85 ----- > Platform/ARM/VExpressPkg/AcpiTables/Spcr.aslc | 82 ----- > Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc | 49 ++- > Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.fdf | 33 +- > Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/AslTables/Dsdt.asl | 27 +- > Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/AslTables/SsdtPci.asl | 204 +++++++++++ > Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c | 376 +++++++++++++++++++- > Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h | 36 +- > Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerDxe.inf | 10 +- > Platform/ARM/VExpressPkg/Drivers/ArmVExpressDxe/ArmFvpDxe.c | 110 +++++- > Platform/ARM/VExpressPkg/Drivers/ArmVExpressDxe/ArmFvpDxe.inf | 4 +- > Platform/ARM/VExpressPkg/Include/Platform/RTSM/ArmPlatform.h | 6 +- > Platform/ARM/VExpressPkg/Include/VExpressMotherBoard.h | 5 +- > Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/ArmVExpressLib.inf | 12 +- > Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/RTSMMem.c | 31 +- > Platform/ARM/VExpressPkg/Library/ArmVExpressPciHostBridgeLib/ArmVExpressPciHostBridgeLib.c | 208 +++++++++++ > Platform/ARM/VExpressPkg/Library/ArmVExpressPciHostBridgeLib/ArmVExpressPciHostBridgeLib.inf | 48 +++ > Platform/ARM/VExpressPkg/Library/ArmVExpressPciHostBridgeLib/ArmVExpressPciHostBridgeLib.uni | 14 + > 23 files changed, 1124 insertions(+), 666 deletions(-) > delete mode 100644 Platform/ARM/VExpressPkg/AcpiTables/AcpiTables.inf > delete mode 100644 Platform/ARM/VExpressPkg/AcpiTables/Dsdt.asl > delete mode 100644 Platform/ARM/VExpressPkg/AcpiTables/Fadt.aslc > delete mode 100644 Platform/ARM/VExpressPkg/AcpiTables/FvpPlatform.h > delete mode 100644 Platform/ARM/VExpressPkg/AcpiTables/Gtdt.aslc > delete mode 100644 Platform/ARM/VExpressPkg/AcpiTables/Madt.aslc > delete mode 100644 Platform/ARM/VExpressPkg/AcpiTables/Spcr.aslc > create mode 100644 Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/AslTables/SsdtPci.asl > create mode 100644 Platform/ARM/VExpressPkg/Library/ArmVExpressPciHostBridgeLib/ArmVExpressPciHostBridgeLib.c > create mode 100644 Platform/ARM/VExpressPkg/Library/ArmVExpressPciHostBridgeLib/ArmVExpressPciHostBridgeLib.inf > create mode 100644 Platform/ARM/VExpressPkg/Library/ArmVExpressPciHostBridgeLib/ArmVExpressPciHostBridgeLib.uni > > -- > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' >