From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mx.groups.io with SMTP id smtpd.web09.24769.1626680205559312734 for ; Mon, 19 Jul 2021 00:36:45 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=tkAaGeDa; spf=pass (domain: kernel.org, ip: 198.145.29.99, mailfrom: ardb@kernel.org) Received: by mail.kernel.org (Postfix) with ESMTPSA id 8976C611BE for ; Mon, 19 Jul 2021 07:36:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1626680204; bh=sOJS/ymbmsykgkoEh0uDRjbtoBLFqF5dWf3vv+jfPXU=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=tkAaGeDaSliDHh6lH4Pwyo615JtCipDE5YLHtQOs4L49iNBptNLQvMvOxb9PDAt8L NhQxTpvRRhQMSiF6bru0uCZUbAigl/x6WPTY2GXMVuFBuRFf31+BM3oWNTqDbfJVuR LUyN8ZOGplpyQ8QM3uRu1GSEAZ6HkUk20OrA0f6DXnwz/ht1n1XKmM5l711qT6JxMN VeTv4odBaHo18E+uDB+JG/W46XKkq4nz4e7+Odm8drCgHnPSZAwwMNmbnHGhnNvryY F/g3JDL/LLdAtZJYemGG4I1gdHPXp6fYcQfYU8MPlhJfPRx1gpwU2J1h4MJO/681Kb isJK8RPT/ADJg== Received: by mail-oi1-f180.google.com with SMTP id c197so19720555oib.11 for ; Mon, 19 Jul 2021 00:36:44 -0700 (PDT) X-Gm-Message-State: AOAM5335d2XYxgz3EwcNoMwNjiEcjqTq8coWT1kpiIYjjvqrEI2MBfew dKY910sl1xoGllmpThkL6qBFhY9uJDcOkASQ6As= X-Google-Smtp-Source: ABdhPJyPuOgPmZpJCrRVi98r8LV0Pqcg+mvapX+01Ro2V5Jk+s4QeclR1GoROiytgJcf8v9AHwjOBmgvIom41sTS4vM= X-Received: by 2002:aca:d64d:: with SMTP id n74mr21319756oig.47.1626680203884; Mon, 19 Jul 2021 00:36:43 -0700 (PDT) MIME-Version: 1.0 References: <20210709032423.17092-1-glin@suse.com> In-Reply-To: <20210709032423.17092-1-glin@suse.com> From: "Ard Biesheuvel" Date: Mon, 19 Jul 2021 09:36:33 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] OvmfPkg/OvmfXen: add QemuKernelLoaderFsDxe To: Gary Lin Cc: edk2-devel-groups-io , Ard Biesheuvel , Jordan Justen , Anthony Perard , Julien Grall , Jim Fehlig Content-Type: text/plain; charset="UTF-8" On Fri, 9 Jul 2021 at 05:24, Gary Lin wrote: > > Without QemuKernelLoaderFsDxe, QemuLoadKernelImage() couldn't download > the kernel, initrd, and kernel command line from QEMU's fw_cfg. > > Cc: Ard Biesheuvel > cc: Jordan Justen > Cc: Anthony Perard > Cc: Julien Grall > Cc: Jim Fehlig > Signed-off-by: Gary Lin I don't understand Xen on x86 well enough to decide whether we should care about QEMU in the first place. Xen folks, please have a look. > --- > OvmfPkg/OvmfXen.dsc | 1 + > OvmfPkg/OvmfXen.fdf | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/OvmfPkg/OvmfXen.dsc b/OvmfPkg/OvmfXen.dsc > index 3c1ca6bfd493..1a9c06c164a8 100644 > --- a/OvmfPkg/OvmfXen.dsc > +++ b/OvmfPkg/OvmfXen.dsc > @@ -587,6 +587,7 @@ [Components] > NULL|OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiLib.inf > !endif > } > + OvmfPkg/QemuKernelLoaderFsDxe/QemuKernelLoaderFsDxe.inf > OvmfPkg/XenIoPvhDxe/XenIoPvhDxe.inf > OvmfPkg/XenIoPciDxe/XenIoPciDxe.inf > OvmfPkg/XenBusDxe/XenBusDxe.inf > diff --git a/OvmfPkg/OvmfXen.fdf b/OvmfPkg/OvmfXen.fdf > index aeb9336fd5b7..8b5823555937 100644 > --- a/OvmfPkg/OvmfXen.fdf > +++ b/OvmfPkg/OvmfXen.fdf > @@ -324,6 +324,7 @@ [FV.DXEFV] > INF MdeModulePkg/Universal/DriverHealthManagerDxe/DriverHealthManagerDxe.inf > INF MdeModulePkg/Universal/BdsDxe/BdsDxe.inf > INF MdeModulePkg/Application/UiApp/UiApp.inf > +INF OvmfPkg/QemuKernelLoaderFsDxe/QemuKernelLoaderFsDxe.inf > INF MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf > INF MdeModulePkg/Universal/PrintDxe/PrintDxe.inf > INF MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf > -- > 2.31.1 >