From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web09.7549.1643378833158941391 for ; Fri, 28 Jan 2022 06:07:13 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=RFlHMZM/; spf=pass (domain: kernel.org, ip: 139.178.84.217, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2D8B161DD2 for ; Fri, 28 Jan 2022 14:07:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 91C6DC340EB for ; Fri, 28 Jan 2022 14:07:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1643378831; bh=QD0OzfVBdFZCOl7CYVlEUyOvw9J/PUMNyOVhal/2zZY=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=RFlHMZM/7Za0dZE4zIzW2+RM2Md25H3PTJzYx8sHUR6voMykBayPxuzL1fVzUekII ZcqsIHovAxTPEyPDqEWUYOOJZnB3CS6o9NVQ2PvNbYgczkpGZkEcJxQkpahFPBw/xu OhqKsJchFYCwbeG4sTod9nyiG8BFfhCyTq3ZKuhdK2EJw3OZ1IZwRSoh7lnciuMjzt Hg4XyoioXaDmHaojIlvlsJxtJM48h7juSxOBOmuMeijCkCpFwSfiZwRNssHGdJ4LRB FWQYicFawpbCpTGeIPNZORpkLBbfgihtc46a1ShHd6OCzKHMqHjtNu5PPSIuHbzURB XP5oksMVYdu2Q== Received: by mail-wm1-f41.google.com with SMTP id f202-20020a1c1fd3000000b0034dd403f4fbso4142892wmf.1 for ; Fri, 28 Jan 2022 06:07:11 -0800 (PST) X-Gm-Message-State: AOAM530ucjISRzI/K20k8Q9trqeJicUU83X4pR/t5KlF7ePYT4r/a43P 7feWDA1nwZlJWm8Dh4Utqw7436v9sozNu5gzCqU= X-Google-Smtp-Source: ABdhPJx3c6Ce2NEUPVM20mdOlJ+cKWFWIT38ikK8DYNte6EXJ+ZJuuElSf9QtTHhACVxP87SkP50aYudcjPKZG052vo= X-Received: by 2002:a05:600c:2b89:: with SMTP id j9mr7594199wmc.190.1643378829708; Fri, 28 Jan 2022 06:07:09 -0800 (PST) MIME-Version: 1.0 References: <20220128131703.3256564-1-Pierre.Gondois@arm.com> In-Reply-To: <20220128131703.3256564-1-Pierre.Gondois@arm.com> From: "Ard Biesheuvel" Date: Fri, 28 Jan 2022 15:06:58 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH RESEND edk2-platforms v1 1/1] Platform/ARM: Add BootDiscoveryPolicy To: Pierre Cc: edk2-devel-groups-io , Ard Biesheuvel , Sami Mujawar , Thomas Abraham Content-Type: text/plain; charset="UTF-8" On Fri, 28 Jan 2022 at 14:16, wrote: > > From: Pierre Gondois > > This commit adds code which check BootDiscoveryPolicy variable and > calls Boot Policy Manager Protocol to connect device specified by > the variable. To enable that mechanism for platform > EfiMdeModulePkgTokenSpaceGuid.PcdBootDiscoveryPolicy PCD must be > added to DSC file. > For the edk2 repository, commit cae735f61328 ("ArmPkg: Enable boot > discovery policy for ARM package.") adds a mechanism to check for > the boot discovery policy. When the following are available: > - gEfiBootManagerPolicyProtocolGuid protocol > - BOOT_DISCOVERY_POLICY_VAR variable > this allows to choose whether devices need to be connected during > boot. > > During boot on ARM platforms, all devices are connected if there > are no valid boot options. If the UEFI shell is added as a valid > boot option, some devices won't be connected. The BootDiscoveryPolicy > will allow to manually configure this. > > For all ARM platforms, add: > - BootManagerPolicyDxe module to Bds phase > - BootDiscoveryPolicyUiLib to UiApp module > - PcdBootDiscoveryPolicy Pcd > > Signed-off-by: Pierre Gondois Reviewed-by: Ard Biesheuvel Pushed as b9d6ddebe1a9..1bbfeb030a55 Thanks, > --- > Platform/ARM/JunoPkg/ArmJuno.dsc | 2 ++ > Platform/ARM/JunoPkg/ArmJuno.fdf | 1 + > Platform/ARM/Morello/MorelloPlatform.dsc.inc | 2 ++ > Platform/ARM/Morello/MorelloPlatformFvp.fdf | 1 + > Platform/ARM/N1Sdp/N1SdpPlatform.dsc | 2 ++ > Platform/ARM/N1Sdp/N1SdpPlatform.fdf | 1 + > Platform/ARM/SgiPkg/SgiPlatform.dsc.inc | 2 ++ > Platform/ARM/SgiPkg/SgiPlatform.fdf | 1 + > Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc | 2 ++ > Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.fdf | 1 + > Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc | 2 ++ > Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.fdf | 1 + > Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 7 +++++++ > 13 files changed, 25 insertions(+) > > diff --git a/Platform/ARM/JunoPkg/ArmJuno.dsc b/Platform/ARM/JunoPkg/ArmJuno.dsc > index 3b7a63b6437a..f7ce397633f6 100644 > --- a/Platform/ARM/JunoPkg/ArmJuno.dsc > +++ b/Platform/ARM/JunoPkg/ArmJuno.dsc > @@ -362,12 +362,14 @@ [Components.common] > # > # Bds > # > + MdeModulePkg/Universal/BootManagerPolicyDxe/BootManagerPolicyDxe.inf > MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf > MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf > MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf > MdeModulePkg/Universal/BdsDxe/BdsDxe.inf > MdeModulePkg/Application/UiApp/UiApp.inf { > > + NULL|MdeModulePkg/Library/BootDiscoveryPolicyUiLib/BootDiscoveryPolicyUiLib.inf > NULL|MdeModulePkg/Library/DeviceManagerUiLib/DeviceManagerUiLib.inf > NULL|MdeModulePkg/Library/BootManagerUiLib/BootManagerUiLib.inf > NULL|MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenanceManagerUiLib.inf > diff --git a/Platform/ARM/JunoPkg/ArmJuno.fdf b/Platform/ARM/JunoPkg/ArmJuno.fdf > index f70d30c6a9d9..c9d51c65ffdb 100644 > --- a/Platform/ARM/JunoPkg/ArmJuno.fdf > +++ b/Platform/ARM/JunoPkg/ArmJuno.fdf > @@ -221,6 +221,7 @@ [FV.FvMain] > # > # Bds > # > + INF MdeModulePkg/Universal/BootManagerPolicyDxe/BootManagerPolicyDxe.inf > INF MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf > INF MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf > INF MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf > diff --git a/Platform/ARM/Morello/MorelloPlatform.dsc.inc b/Platform/ARM/Morello/MorelloPlatform.dsc.inc > index dccd22248318..1c93246a5273 100644 > --- a/Platform/ARM/Morello/MorelloPlatform.dsc.inc > +++ b/Platform/ARM/Morello/MorelloPlatform.dsc.inc > @@ -204,12 +204,14 @@ [Components.common] > FatPkg/EnhancedFatDxe/Fat.inf > > # Bds > + MdeModulePkg/Universal/BootManagerPolicyDxe/BootManagerPolicyDxe.inf > MdeModulePkg/Universal/BdsDxe/BdsDxe.inf > MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf > MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf > MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf > MdeModulePkg/Application/UiApp/UiApp.inf { > > + NULL|MdeModulePkg/Library/BootDiscoveryPolicyUiLib/BootDiscoveryPolicyUiLib.inf > NULL|MdeModulePkg/Library/DeviceManagerUiLib/DeviceManagerUiLib.inf > NULL|MdeModulePkg/Library/BootManagerUiLib/BootManagerUiLib.inf > NULL|MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenanceManagerUiLib.inf > diff --git a/Platform/ARM/Morello/MorelloPlatformFvp.fdf b/Platform/ARM/Morello/MorelloPlatformFvp.fdf > index 851ee3159b3d..5f2af05c8bfc 100644 > --- a/Platform/ARM/Morello/MorelloPlatformFvp.fdf > +++ b/Platform/ARM/Morello/MorelloPlatformFvp.fdf > @@ -143,6 +143,7 @@ [FV.FvMain] > INF Platform/ARM/Morello/Drivers/PlatformDxe/PlatformDxeFvp.inf > > # Bds > + INF MdeModulePkg/Universal/BootManagerPolicyDxe/BootManagerPolicyDxe.inf > INF MdeModulePkg/Application/UiApp/UiApp.inf > INF MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf > INF MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf > diff --git a/Platform/ARM/N1Sdp/N1SdpPlatform.dsc b/Platform/ARM/N1Sdp/N1SdpPlatform.dsc > index 8dac1bc54c36..865dd04deb09 100644 > --- a/Platform/ARM/N1Sdp/N1SdpPlatform.dsc > +++ b/Platform/ARM/N1Sdp/N1SdpPlatform.dsc > @@ -238,12 +238,14 @@ [Components.common] > FatPkg/EnhancedFatDxe/Fat.inf > > # Bds > + MdeModulePkg/Universal/BootManagerPolicyDxe/BootManagerPolicyDxe.inf > MdeModulePkg/Universal/BdsDxe/BdsDxe.inf > MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf > MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf > MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf > MdeModulePkg/Application/UiApp/UiApp.inf { > > + NULL|MdeModulePkg/Library/BootDiscoveryPolicyUiLib/BootDiscoveryPolicyUiLib.inf > NULL|MdeModulePkg/Library/DeviceManagerUiLib/DeviceManagerUiLib.inf > NULL|MdeModulePkg/Library/BootManagerUiLib/BootManagerUiLib.inf > NULL|MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenanceManagerUiLib.inf > diff --git a/Platform/ARM/N1Sdp/N1SdpPlatform.fdf b/Platform/ARM/N1Sdp/N1SdpPlatform.fdf > index 6ede2b7fc894..09f1e0e0073b 100644 > --- a/Platform/ARM/N1Sdp/N1SdpPlatform.fdf > +++ b/Platform/ARM/N1Sdp/N1SdpPlatform.fdf > @@ -160,6 +160,7 @@ [FV.FvMain] > INF Platform/ARM/N1Sdp/Drivers/PlatformDxe/PlatformDxe.inf > > # Bds > + INF MdeModulePkg/Universal/BootManagerPolicyDxe/BootManagerPolicyDxe.inf > INF MdeModulePkg/Application/UiApp/UiApp.inf > INF MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf > INF MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf > diff --git a/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc b/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc > index 4fe3ccf9a530..582efb0114c6 100644 > --- a/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc > +++ b/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc > @@ -318,12 +318,14 @@ [Components.common] > # > # Bds > # > + MdeModulePkg/Universal/BootManagerPolicyDxe/BootManagerPolicyDxe.inf > MdeModulePkg/Universal/BdsDxe/BdsDxe.inf > MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf > MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf > MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf > MdeModulePkg/Application/UiApp/UiApp.inf { > > + NULL|MdeModulePkg/Library/BootDiscoveryPolicyUiLib/BootDiscoveryPolicyUiLib.inf > NULL|MdeModulePkg/Library/DeviceManagerUiLib/DeviceManagerUiLib.inf > NULL|MdeModulePkg/Library/BootManagerUiLib/BootManagerUiLib.inf > NULL|MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenanceManagerUiLib.inf > diff --git a/Platform/ARM/SgiPkg/SgiPlatform.fdf b/Platform/ARM/SgiPkg/SgiPlatform.fdf > index 8227ae03330c..21eeb3706ba0 100644 > --- a/Platform/ARM/SgiPkg/SgiPlatform.fdf > +++ b/Platform/ARM/SgiPkg/SgiPlatform.fdf > @@ -187,6 +187,7 @@ [FV.FvMain] > # > # Bds > # > + INF MdeModulePkg/Universal/BootManagerPolicyDxe/BootManagerPolicyDxe.inf > INF MdeModulePkg/Application/UiApp/UiApp.inf > INF MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf > INF MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf > diff --git a/Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc b/Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc > index e06a2a47f091..cb9d2d4287e3 100644 > --- a/Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc > +++ b/Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc > @@ -267,12 +267,14 @@ [Components.common] > # > # Bds > # > + MdeModulePkg/Universal/BootManagerPolicyDxe/BootManagerPolicyDxe.inf > MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf > MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf > MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf > MdeModulePkg/Universal/BdsDxe/BdsDxe.inf > MdeModulePkg/Application/UiApp/UiApp.inf { > > + NULL|MdeModulePkg/Library/BootDiscoveryPolicyUiLib/BootDiscoveryPolicyUiLib.inf > NULL|MdeModulePkg/Library/DeviceManagerUiLib/DeviceManagerUiLib.inf > NULL|MdeModulePkg/Library/BootManagerUiLib/BootManagerUiLib.inf > NULL|MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenanceManagerUiLib.inf > diff --git a/Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.fdf b/Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.fdf > index f98de162e634..8ca70a248d09 100644 > --- a/Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.fdf > +++ b/Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.fdf > @@ -153,6 +153,7 @@ [FV.FvMain] > # > # Bds > # > + INF MdeModulePkg/Universal/BootManagerPolicyDxe/BootManagerPolicyDxe.inf > INF MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf > INF MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf > INF MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf > diff --git a/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc b/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc > index cf7350649edb..8561c21fab5a 100644 > --- a/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc > +++ b/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc > @@ -328,12 +328,14 @@ [Components.common] > # > # Bds > # > + MdeModulePkg/Universal/BootManagerPolicyDxe/BootManagerPolicyDxe.inf > MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf > MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf > MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf > MdeModulePkg/Universal/BdsDxe/BdsDxe.inf > MdeModulePkg/Application/UiApp/UiApp.inf { > > + NULL|MdeModulePkg/Library/BootDiscoveryPolicyUiLib/BootDiscoveryPolicyUiLib.inf > NULL|MdeModulePkg/Library/DeviceManagerUiLib/DeviceManagerUiLib.inf > NULL|MdeModulePkg/Library/BootManagerUiLib/BootManagerUiLib.inf > NULL|MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenanceManagerUiLib.inf > diff --git a/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.fdf b/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.fdf > index 7635cb7a8406..a7d048273b37 100644 > --- a/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.fdf > +++ b/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.fdf > @@ -161,6 +161,7 @@ [FV.FvMain] > # > # Bds > # > + INF MdeModulePkg/Universal/BootManagerPolicyDxe/BootManagerPolicyDxe.inf > INF MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf > INF MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf > INF MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf > diff --git a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > index d6f31ecda42f..9f739b374c91 100644 > --- a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > +++ b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > @@ -264,6 +264,13 @@ [BuildOptions] > # > ################################################################################ > > +[PcdsDynamicHii.common.DEFAULT] > + # Possible values are: > + # 0: Connect Minimal Devices > + # 1: Connect Network Devices > + # 2: Connect All Devices > + gEfiMdeModulePkgTokenSpaceGuid.PcdBootDiscoveryPolicy|L"BootDiscoveryPolicy"|gBootDiscoveryPolicyMgrFormsetGuid|0|0 > + > [PcdsFeatureFlag.common] > gEfiMdePkgTokenSpaceGuid.PcdComponentNameDisable|TRUE > gEfiMdePkgTokenSpaceGuid.PcdDriverDiagnosticsDisable|TRUE > -- > 2.25.1 >