From: "Ard Biesheuvel" <ardb@kernel.org>
To: Laszlo Ersek <lersek@redhat.com>
Cc: devel@edk2.groups.io, kraxel@redhat.com,
Jiewen Yao <jiewen.yao@intel.com>,
oliver@redhat.com
Subject: Re: [edk2-devel] [PATCH 0/4] OvmfPkg/VirtNorFlashDxe: fix corruption + misc small improvements
Date: Tue, 16 Jan 2024 11:21:26 +0100 [thread overview]
Message-ID: <CAMj1kXH4Tn+fCN2Exy1cozd6bHLA2q21YYGAB2-0B4Y9A_MBOA@mail.gmail.com> (raw)
In-Reply-To: <dbc5cc73-4385-9865-ee16-5a0c80181431@redhat.com>
On Tue, 16 Jan 2024 at 10:37, Laszlo Ersek <lersek@redhat.com> wrote:
>
> On 1/15/24 18:56, Ard Biesheuvel wrote:
> > On Mon, 15 Jan 2024 at 11:21, Laszlo Ersek <lersek@redhat.com> wrote:
> >>
> >> On 1/12/24 12:37, Gerd Hoffmann wrote:
> >>> This is a little series containing the flash corruption fix sent
> >>> yesterday with an slightly improved commit message and some small
> >>> improvements on top of this.
> >>>
> >>> Gerd Hoffmann (4):
> >>> OvmfPkg/VirtNorFlashDxe: fix shadowbuffer reads
> >>> OvmfPkg/VirtNorFlashDxe: clarify block write logic
> >>> OvmfPkg/VirtNorFlashDxe: allow larger writes without block erase
> >>> OvmfPkg/VirtNorFlashDxe: ValidateFvHeader: unwritten state is EOL too
> >>>
> >>> OvmfPkg/VirtNorFlashDxe/VirtNorFlash.c | 33 +++++++++++------------
> >>> OvmfPkg/VirtNorFlashDxe/VirtNorFlashFvb.c | 5 ++++
> >>> 2 files changed, 21 insertions(+), 17 deletions(-)
> >>>
> >>
> >> Looking at the original code makes me throw a fit (no offense -- I don't
> >> know who wrote it, and I don't want to check).
> >>
> >
> > Hi Laszlo,
> >
> > I am not the author of the original code, but I suppose I should take
> > at least some of the blame here, having added some of the logic to
> > reduce the number of MMIO accesses (which are disproportionately
> > expensive under virtualization), and this is where the bug got
> > introduced afaict.
>
> ... sorry about being needlessly harsh. If it's any excuse: in all such
> cases I make a fully committed, honest effort to dig down to the "roots"
> of the code, and the more I struggle to form a mental image, the more
> annoyed/stressed I get. Comments and diagrams would definitely help with
> my efforts, but just because I get annoyed during first analysis, that
> is not sufficient reason to let that *leak* to the list. It's a
> personality defect on my end. I'll keep working on it.
>
Don't worry about it, really.
I don't mind unfiltered criticism from long-time collaborators as long
as it is constructive - email is such a lossy medium in terms of
subtext that I'd rather suffer a minor ego bruise than having to
unwrap layers of politeness to get at the real meaning.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#113885): https://edk2.groups.io/g/devel/message/113885
Mute This Topic: https://groups.io/mt/103680930/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
prev parent reply other threads:[~2024-01-16 10:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-12 11:37 [edk2-devel] [PATCH 0/4] OvmfPkg/VirtNorFlashDxe: fix corruption + misc small improvements Gerd Hoffmann
2024-01-12 11:37 ` [edk2-devel] [PATCH 1/4] OvmfPkg/VirtNorFlashDxe: fix shadowbuffer reads Gerd Hoffmann
2024-01-12 12:11 ` Ard Biesheuvel
2024-01-12 11:37 ` [edk2-devel] [PATCH 2/4] OvmfPkg/VirtNorFlashDxe: clarify block write logic Gerd Hoffmann
2024-01-12 12:14 ` Ard Biesheuvel
2024-01-12 11:37 ` [edk2-devel] [PATCH 3/4] OvmfPkg/VirtNorFlashDxe: allow larger writes without block erase Gerd Hoffmann
2024-01-12 12:15 ` Ard Biesheuvel
2024-01-12 11:37 ` [edk2-devel] [PATCH 4/4] OvmfPkg/VirtNorFlashDxe: ValidateFvHeader: unwritten state is EOL too Gerd Hoffmann
2024-01-12 12:16 ` Ard Biesheuvel
2024-01-12 12:41 ` Gerd Hoffmann
2024-01-15 10:21 ` [edk2-devel] [PATCH 0/4] OvmfPkg/VirtNorFlashDxe: fix corruption + misc small improvements Laszlo Ersek
2024-01-15 12:38 ` Laszlo Ersek
2024-01-15 17:56 ` Ard Biesheuvel
2024-01-16 9:37 ` Laszlo Ersek
2024-01-16 10:21 ` Ard Biesheuvel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMj1kXH4Tn+fCN2Exy1cozd6bHLA2q21YYGAB2-0B4Y9A_MBOA@mail.gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox