From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by mx.groups.io with SMTP id smtpd.web12.8809.1651569132376957538 for ; Tue, 03 May 2022 02:12:12 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=MuQ5U6Be; spf=pass (domain: kernel.org, ip: 145.40.68.75, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id DD5F3B81A96 for ; Tue, 3 May 2022 09:12:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AD3F5C385B0 for ; Tue, 3 May 2022 09:12:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651569129; bh=ydjsjN17REYXhy95lRez3gF7mOfGZAw6FV2ELVL/SaA=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=MuQ5U6BeYHXZNEtYPf/00NJRPnGhRbfb152v76LFh6CJ/+pRkpv+koEDbKF1/SP60 /AivkhfzAFPBHnR9OWiwaS5yYPK9IGv5uf4quG+T2sXfKLuzCfFGdaUoaZKfaKD9nz IFMs+bufYKk7VOWsN33WuiXFbRSDACFoTxrdqBWCZ/rMCXnB0g2oVzaeLac+csQ8sg nt7nfMxBxogL0FOZX8lvn6GH0HvB86mRCXJa5Yb4kOvl0A7rROZBQXZcR1UzPshX7o 49ozz9QQB/1Ffuawq57H7AkN3eFiVl8QwTkefiQJaIVkOfZ8g9GFfpkkXE0nzdd8B/ OaNqWjbgyc5UQ== Received: by mail-oi1-f169.google.com with SMTP id v65so17564094oig.10 for ; Tue, 03 May 2022 02:12:09 -0700 (PDT) X-Gm-Message-State: AOAM531ETBUOJLPEZhfQN9NhWkl7yzOgIePcZNtsXhciOYnWXOtOnZXv 2SYSXIwKoky0fmv6ebw9Ha7/CUjlZ5pj8D/n5gk= X-Google-Smtp-Source: ABdhPJzatc8ilrOF+Yws/y789s7qmOfPdUijCyY/97ECYJByLTNO2CU+7+GuZ9WAKka92LmA5rYbdUcuxeMZrQIXMxE= X-Received: by 2002:a05:6808:1141:b0:325:cd92:ef8d with SMTP id u1-20020a056808114100b00325cd92ef8dmr1411166oiu.228.1651569128859; Tue, 03 May 2022 02:12:08 -0700 (PDT) MIME-Version: 1.0 References: <20220418081403.2324-1-pranav.madhu@arm.com> In-Reply-To: From: "Ard Biesheuvel" Date: Tue, 3 May 2022 11:11:57 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [edk2-platforms][PATCH V1 1/1] Platform/Sgi: Remove SLC entry from PPTT table To: edk2-devel-groups-io , Pranav Madhu Cc: Ard Biesheuvel , Sami Mujawar , nd Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 20 Apr 2022 at 09:45, Pranav Madhu wrote: > > Hi Ard, > > Please find my response inline. > > > -----Original Message----- > > From: Ard Biesheuvel > > Sent: Wednesday, April 20, 2022 1:05 PM > > To: Pranav Madhu > > Cc: edk2-devel-groups-io ; Ard Biesheuvel > > ; Sami Mujawar > > Subject: Re: [edk2-platforms][PATCH V1 1/1] Platform/Sgi: Remove SLC en= try > > from PPTT table > > > > On Mon, 18 Apr 2022 at 10:14, Pranav Madhu > > wrote: > > > > > > Remove system level cache (SLC) entry from ACPI PPTT table. SLC on th= e > > > Neoverse reference design platforms is the memory side cache and so i= t > > > is removed from PPTT table. > > > > > > > Could you elaborate? Why does the former justify/imply the latter? > > The SLC cache in Neoverse reference design is not a processor resource, i= nstead it is an interconnect resource. As PPTT is used to describe the proc= essor topology and processor resources, it is better to remove the SLC cach= e from PPTT and the best place for SLC is HMAT/SRAT tables. > OK, thanks for the clarification. Pushed as 6b05b8acd60a..df5e094ef347 > > > > > Signed-off-by: Pranav Madhu > > > --- > > > Platform/ARM/SgiPkg/Include/SgiAcpiHeader.h | 4 +--- > > > Platform/ARM/SgiPkg/AcpiTables/RdE1Edge/Pptt.aslc | 24 +++--------= --------- > > > Platform/ARM/SgiPkg/AcpiTables/RdN1Edge/Pptt.aslc | 20 +++--------= ----- > > > Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2/Pptt.aslc | 23 +++--------= ------- > > - > > > Platform/ARM/SgiPkg/AcpiTables/RdN2/Pptt.aslc | 21 ++++-------= ------ > > > Platform/ARM/SgiPkg/AcpiTables/RdN2Cfg1/Pptt.aslc | 21 ++++-------= ------ > > > Platform/ARM/SgiPkg/AcpiTables/RdV1/Pptt.aslc | 21 ++++-------= ------ > > > Platform/ARM/SgiPkg/AcpiTables/RdV1Mc/Pptt.aslc | 23 ++++-------= -------- > > > 8 files changed, 26 insertions(+), 131 deletions(-) > > > > > > Link to github branch for this patch - > > > https://github.com/Pranav-Madhu/edk2-platforms/tree/topics/remove_slc= _ > > > from_pptt > > > > > <...> > > Regards, > Pranav > > >=20 > >