From: "Ard Biesheuvel" <ardb@kernel.org>
To: mikuback@linux.microsoft.com
Cc: devel@edk2.groups.io, Ard Biesheuvel <ardb+tianocore@kernel.org>,
Leif Lindholm <quic_llindhol@quicinc.com>,
Sami Mujawar <sami.mujawar@arm.com>
Subject: Re: [edk2-devel] [PATCH v1 1/1] ArmPkg/ArmMmuLib: Use function pointer type
Date: Tue, 28 Nov 2023 12:03:26 +0100 [thread overview]
Message-ID: <CAMj1kXH4nV9dGhT8EcG9f40vdaDvOhQAXsEtOc1o+cNvTZfWfw@mail.gmail.com> (raw)
In-Reply-To: <20231127235743.1055-1-mikuback@linux.microsoft.com>
On Tue, 28 Nov 2023 at 00:58, <mikuback@linux.microsoft.com> wrote:
>
> From: Michael Kubacki <michael.kubacki@microsoft.com>
>
> mReplaceLiveEntryFunc is a function pointer but assigned as a VOID*
> pointer:
>
> mReplaceLiveEntryFunc = *(VOID **)GET_GUID_HOB_DATA (Hob);
>
> This leads to the Visual Studio warning:
>
> nonstandard extension, function/data pointer conversion in
> expression
>
> This change updates the assignment to avoid using a data pointer and
> defines a type for the function pointer to succinctly and accurately
> refer to the type when it is used in the library code.
>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
Merged, thanks.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111807): https://edk2.groups.io/g/devel/message/111807
Mute This Topic: https://groups.io/mt/102841630/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
prev parent reply other threads:[~2023-11-28 11:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-27 23:57 [edk2-devel] [PATCH v1 1/1] ArmPkg/ArmMmuLib: Use function pointer type Michael Kubacki
2023-11-28 11:03 ` Ard Biesheuvel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMj1kXH4nV9dGhT8EcG9f40vdaDvOhQAXsEtOc1o+cNvTZfWfw@mail.gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox