From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 007F27803E3 for ; Tue, 28 Nov 2023 11:03:43 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=s1tvGvBz4yG0/kteQIKB0haUP8JPLoRY1mFJ/lEMD2Y=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1701169422; v=1; b=Mo/uZlS5p32PnFFfJhbxvU0f/gi0r6vAv8OwDgydvZIpLR9Xyyy/XZCy/xNi++nh5d8WhuhA ZZgt9XPsLCaQOr1XmPztXXvkerr0XunyOLGegNb4OGEcXPnj6lZmI3W+v3LoITsrxJJHS4r9OF9 lnkAryAX7Nyy5eMz1tncxrk4= X-Received: by 127.0.0.2 with SMTP id kTryYY7687511xz7XPcor8Gg; Tue, 28 Nov 2023 03:03:42 -0800 X-Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web11.30240.1701169421280837349 for ; Tue, 28 Nov 2023 03:03:41 -0800 X-Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id A1FB7616E1 for ; Tue, 28 Nov 2023 11:03:40 +0000 (UTC) X-Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4FE68C433CB for ; Tue, 28 Nov 2023 11:03:40 +0000 (UTC) X-Received: by mail-lj1-f175.google.com with SMTP id 38308e7fff4ca-2c887d1fb8fso66002051fa.0 for ; Tue, 28 Nov 2023 03:03:40 -0800 (PST) X-Gm-Message-State: 4i6k0rJybAzcgQjyzMw0PEzGx7686176AA= X-Google-Smtp-Source: AGHT+IFJysAf/qfvkgm7SmItVvL2Qwc+2wVyx558RkdEJ3z0Um66qaY7kZ0TwsXtcRDJLi4FJf8gObBC7ComOrkLcIE= X-Received: by 2002:a2e:9895:0:b0:2c9:afbc:7684 with SMTP id b21-20020a2e9895000000b002c9afbc7684mr1212329ljj.20.1701169418551; Tue, 28 Nov 2023 03:03:38 -0800 (PST) MIME-Version: 1.0 References: <20231127235743.1055-1-mikuback@linux.microsoft.com> In-Reply-To: <20231127235743.1055-1-mikuback@linux.microsoft.com> From: "Ard Biesheuvel" Date: Tue, 28 Nov 2023 12:03:26 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH v1 1/1] ArmPkg/ArmMmuLib: Use function pointer type To: mikuback@linux.microsoft.com Cc: devel@edk2.groups.io, Ard Biesheuvel , Leif Lindholm , Sami Mujawar Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ardb@kernel.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="Mo/uZlS5"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Tue, 28 Nov 2023 at 00:58, wrote: > > From: Michael Kubacki > > mReplaceLiveEntryFunc is a function pointer but assigned as a VOID* > pointer: > > mReplaceLiveEntryFunc = *(VOID **)GET_GUID_HOB_DATA (Hob); > > This leads to the Visual Studio warning: > > nonstandard extension, function/data pointer conversion in > expression > > This change updates the assignment to avoid using a data pointer and > defines a type for the function pointer to succinctly and accurately > refer to the type when it is used in the library code. > > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Cc: Sami Mujawar > Signed-off-by: Michael Kubacki Merged, thanks. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111807): https://edk2.groups.io/g/devel/message/111807 Mute This Topic: https://groups.io/mt/102841630/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-