From: "Ard Biesheuvel" <ardb@kernel.org>
To: edk2-devel-groups-io <devel@edk2.groups.io>, mark.kettenis@xs4all.nl
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Leif Lindholm <leif@nuviainc.com>, Peter Batard <pete@akeo.ie>,
Jeremy Linton <jeremy.linton@arm.com>,
Mark Kettenis <kettenis@openbsd.org>
Subject: Re: [edk2-devel] [PATCH] Platform/RaspberryPi: Remove TypeTranslation attribute
Date: Sun, 10 Oct 2021 23:10:09 +0200 [thread overview]
Message-ID: <CAMj1kXH4zHup15pM0OB30yvJx4ikBqfTL_Kp3PharnzSahxyvw@mail.gmail.com> (raw)
In-Reply-To: <20211010194814.17129-1-kettenis@openbsd.org>
On Sun, 10 Oct 2021 at 21:48, Mark Kettenis <mark.kettenis@xs4all.nl> wrote:
>
> The MMIO host bridge window isn't translated as both the primary
> and secondary side are MMIO. So remove the incorrect
> TypeTranslation attribute.
>
> Signed-off-by: Mark Kettenis <kettenis@openbsd.org>
Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
Pushed as bbb431a0c658..ab6fcc28fd99
Thanks,
> ---
> Platform/RaspberryPi/AcpiTables/Pci.asl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Platform/RaspberryPi/AcpiTables/Pci.asl b/Platform/RaspberryPi/AcpiTables/Pci.asl
> index ee37b7a21e..f485c6b5d2 100644
> --- a/Platform/RaspberryPi/AcpiTables/Pci.asl
> +++ b/Platform/RaspberryPi/AcpiTables/Pci.asl
> @@ -94,7 +94,7 @@ DefinitionBlock (__FILE__, "SSDT", 5, "RPIFDN", "RPI4PCIE", 2)
> 1, // SANITIZED_PCIE_MMIO_LEN + SANITIZED_PCIE_PCI_MMIO_BEGIN
> SANITIZED_PCIE_CPU_MMIO_WINDOW, // SANITIZED_PCIE_PCI_MMIO_BEGIN - SANITIZED_PCIE_CPU_MMIO_WINDOW
> 2 // SANITIZED_PCIE_MMIO_LEN + 1
> - ,,,MMI1,,TypeTranslation
> + ,,,MMI1
> )
>
> // root port registers, not to be used if SMCCC is utilized
> --
> 2.33.0
>
>
>
> ------------
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#81734): https://edk2.groups.io/g/devel/message/81734
> Mute This Topic: https://groups.io/mt/86221449/1131722
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub [ardb@kernel.org]
> ------------
>
>
next prev parent reply other threads:[~2021-10-10 21:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-10 19:48 [PATCH] Platform/RaspberryPi: Remove TypeTranslation attribute Mark Kettenis
2021-10-10 20:15 ` Mark Kettenis
2021-10-10 21:10 ` Ard Biesheuvel [this message]
2021-10-14 21:05 ` [edk2-devel] " Jeremy Linton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMj1kXH4zHup15pM0OB30yvJx4ikBqfTL_Kp3PharnzSahxyvw@mail.gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox