From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web11.47832.1685360492550281649 for ; Mon, 29 May 2023 04:41:32 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=OGktkY0v; spf=pass (domain: kernel.org, ip: 139.178.84.217, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1BB32617D2 for ; Mon, 29 May 2023 11:41:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7FBD8C4339E for ; Mon, 29 May 2023 11:41:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685360491; bh=LDBbZoPed/RLqvCMWESH88Sdo8Fx6uiNhTmCNng9Iyc=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=OGktkY0vVT6Nyp/ZVhu4cvhs9YdLvNYuFC1d+lal56A3yYupUIX89TjjlF7+PPJBu XtlQAgATAcOpLlIH10I4AjcdvD3B+9O+6zwaMYSyJoF3jcMD6E0uDY2srEQC99vY3W c1zwQN9H5Z1IyzGilrhBQaYt8j2IJRbsIPMfjx2iT52b0c0QOKmy4hzU4jyrssaPiV iAhyJc7SZPh1cSOYRc9ZRgqu6d7BobtIayKUjY8tuDaxdhWHUdqWdPvapm+PZhJWLj 7arxSgSD0TwxXEhzQ4j+9w24KQNnO9iIt83Vf0JM63i8KptmRX2kQ1fX7f6zQSyqlJ Zd2fht135q6Jw== Received: by mail-lf1-f54.google.com with SMTP id 2adb3069b0e04-4f3ba703b67so3387501e87.1 for ; Mon, 29 May 2023 04:41:31 -0700 (PDT) X-Gm-Message-State: AC+VfDyY9Kp8tr0I5wteU6jBlvEotc7Xq15LQ6ENvv5gseYbbaxQbJ0S dbcKH2cZFGjDs3tMA6OxyBydTnDoqKosSRmy9vg= X-Google-Smtp-Source: ACHHUZ6D5N2XRQ8l5VZSZAGVAQ0Jlxj0J02ZpKuTy8N6mycp2jijWi9zezJVx+/kt039/OUVfugdAATAdjQkZ1fLNUs= X-Received: by 2002:a19:750e:0:b0:4f3:80a3:b40a with SMTP id y14-20020a19750e000000b004f380a3b40amr3022047lfe.69.1685360489508; Mon, 29 May 2023 04:41:29 -0700 (PDT) MIME-Version: 1.0 References: <20230516094758.106631-1-kraxel@redhat.com> In-Reply-To: From: "Ard Biesheuvel" Date: Mon, 29 May 2023 13:41:18 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/1] OvmfPkg/PciHotPlugInitDxe: Do not reserve IO ports by default. To: Gerd Hoffmann Cc: devel@edk2.groups.io, Ard Biesheuvel , Jordan Justen , Jiewen Yao , Oliver Steffen , Pawel Polawski Content-Type: text/plain; charset="UTF-8" On Thu, 25 May 2023 at 17:47, Ard Biesheuvel wrote: > > On Tue, 16 May 2023 at 11:48, Gerd Hoffmann wrote: > > > > Flip the default for IO address space reservations for PCI(e) bridges > > and root ports with hotplug support from TRUE to FALSE. > > > > PCI(e) bridges will still get IO address space assigned in case: > > > > (a) Downstream devices actually need IO address space, or > > (b) Explicit configuration, using "qemu -device > > pcie-root-port,io-reserve=". > > > > In case IO address space is exhausted edk2 will stop assigning resources > > to PCI(e) bridges. This is not limited to IO resources, the affected > > bridges will not get any memory resources assigned either. > > > > This patch solves this issue by not handing out the scare IO address > > space, which is in most cases not needed anyway. Result is a more > > consistent PCI configuration in virtual machine configurations with many > > PCie root ports. > > > > Signed-off-by: Gerd Hoffmann > > Reviewed-by: Ard Biesheuvel > Merged as #4441 > > --- > > OvmfPkg/PciHotPlugInitDxe/PciHotPlugInit.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/OvmfPkg/PciHotPlugInitDxe/PciHotPlugInit.c b/OvmfPkg/PciHotPlugInitDxe/PciHotPlugInit.c > > index 6b2b6797b3b6..69903a600981 100644 > > --- a/OvmfPkg/PciHotPlugInitDxe/PciHotPlugInit.c > > +++ b/OvmfPkg/PciHotPlugInitDxe/PciHotPlugInit.c > > @@ -589,7 +589,7 @@ GetResourcePadding ( > > return EFI_INVALID_PARAMETER; > > } > > > > - DefaultIo = TRUE; > > + DefaultIo = FALSE; > > DefaultMmio = TRUE; > > DefaultPrefMmio = TRUE; > > > > -- > > 2.40.1 > >