From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web10.81888.1673600893545982307 for ; Fri, 13 Jan 2023 01:08:13 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=P3K3/+jY; spf=pass (domain: kernel.org, ip: 139.178.84.217, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E2E7C61090 for ; Fri, 13 Jan 2023 09:08:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 549D5C433D2 for ; Fri, 13 Jan 2023 09:08:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1673600892; bh=m85XErMKym9E6IMPaT2DEwFzJQuJ/7QiicXE+UThFjw=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=P3K3/+jYoFw52PNtAVyrsLnEc1IPVDWMfiW5LKxal3g9KoOBVid0l2um4OmTdVdgO PhA1Odyk3MwNSrbPVvP0hBSx7wS17ypr2igRENLLvJD+udXJLV7gCsOAYHggxnYir2 p/OOTR60z8Bi8dFF+6W4KEmW1IkdPtfvkLb7FK0wIR/w+dwDb1ZaL3cgpnQw6Jqszp Kf23FrZDFuUrs4XD+hlqD4ovfEyVYArPnUHnhpdl7XOxrtcteMy0nGsF3DZw7f3oXS MC6v9lV2RGwaGsDHP2ImLzqG2sNjSAcIOfa0xaTO7yXS7HLlWJvO9qzemAUNdan/gV UwRqG7xy0Mo8Q== Received: by mail-lj1-f180.google.com with SMTP id e13so21902144ljn.0 for ; Fri, 13 Jan 2023 01:08:12 -0800 (PST) X-Gm-Message-State: AFqh2krZrkp4EShoyaq+BjVELWMru4Ayl5v3Wuut4VfgWqm3gDQ1iBH2 jCjHwB2m9sTEqFlTZDP6fAZZxIPI2z4HyI+6Mtw= X-Google-Smtp-Source: AMrXdXvCrgVXoe7PQc5wdZP64xu21lZrIAg/s07N0GAzhxEPEcJMWMtSMYIUNb6uVMgw4J50iHpeczquS5OYWRux9NQ= X-Received: by 2002:a2e:96ce:0:b0:283:33fa:ee22 with SMTP id d14-20020a2e96ce000000b0028333faee22mr949501ljj.415.1673600890314; Fri, 13 Jan 2023 01:08:10 -0800 (PST) MIME-Version: 1.0 References: <20230112093425.1228300-1-kraxel@redhat.com> In-Reply-To: From: "Ard Biesheuvel" Date: Fri, 13 Jan 2023 10:07:58 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH v3 0/8] OvmfPkg: check 64bit mmio window for resource conflicts To: devel@edk2.groups.io, lersek@redhat.com Cc: kraxel@redhat.com, Oliver Steffen , Ard Biesheuvel , Jordan Justen , Pawel Polawski , Jiewen Yao Content-Type: text/plain; charset="UTF-8" On Thu, 12 Jan 2023 at 19:34, Laszlo Ersek wrote: > > Hi, > > On 1/12/23 10:34, Gerd Hoffmann wrote: > > v3: > > - Add / fix comments, add notes to commit messages. > > - Make functions static. > > - Logging tweaks. > > - Fix windows compiler warnings. > > - Add patches (5,6,7) moving MMCONFIG to 0xe0000000, simplifying code > > and reducing differences between 'pc' and 'q35' along the way. > > Eventually we want split them into a separate series, but some of > > this was discussed in v2 review, so I just appended them here for > > now. > > v2: > > - split up PlatformScanOrAdd64BitE820Ram() into scan function with > > callbacks, store results in PlatformInfoHob struct. > > > > Gerd Hoffmann (8): > > OvmfPkg/PlatformInitLib: Add PlatformScanE820 and GetFirstNonAddressCB > > OvmfPkg/PlatformInitLib: Add PlatformGetLowMemoryCB > > OvmfPkg/PlatformInitLib: Add PlatformAddHobCB > > OvmfPkg/PlatformInitLib: Add PlatformReservationConflictCB > > OvmfPkg/PlatformInitLib: reorder PlatformQemuUc32BaseInitialization > > OvmfPkg/PlatformInitLib: update address space layout comment > > OvmfPkg/PlatformInitLib: move mmconfig to 0xe0000000 > > OvmfPkg/PlatformInitLib: simplify mtrr setup > > > > OvmfPkg/AmdSev/AmdSevX64.dsc | 2 +- > > OvmfPkg/IntelTdx/IntelTdxX64.dsc | 2 +- > > OvmfPkg/OvmfPkgIa32.dsc | 2 +- > > OvmfPkg/OvmfPkgIa32X64.dsc | 2 +- > > OvmfPkg/OvmfPkgX64.dsc | 2 +- > > OvmfPkg/OvmfXen.dsc | 2 +- > > OvmfPkg/Include/Library/PlatformInitLib.h | 3 +- > > OvmfPkg/Library/PeilessStartupLib/Hob.c | 3 +- > > .../PeilessStartupLib/PeilessStartup.c | 7 +- > > OvmfPkg/Library/PlatformInitLib/MemDetect.c | 384 ++++++++++-------- > > OvmfPkg/Library/PlatformInitLib/Platform.c | 39 +- > > OvmfPkg/PlatformPei/MemDetect.c | 3 +- > > 12 files changed, 246 insertions(+), 205 deletions(-) > > > > please proceed with this without me. Since I've been back to edk2, just > "temporarily" (until the BZs I've reported in 2023 would be fixed), my > stress levels have been through the roof, I'm again working 10-12 hour > days, things are falling apart around me. I'm simply unable to ignore > things on the list that I have some knowledge for commenting upon, and > that traffic happens to be sizeable, and my comments happen to be > detailed, and while that may be good for edk2, it's *destroying* me. I'm > an edk2 addict / workaholic that has relapsed. > > I'm out. Thanks for the collaboration. I must save myself. > Laszlo, I'm really sorry to hear this. Thanks a lot for your input, it has been valuable as always.