From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by mx.groups.io with SMTP id smtpd.web11.3161.1659609190392806167 for ; Thu, 04 Aug 2022 03:33:10 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Cx3qk9T9; spf=pass (domain: kernel.org, ip: 145.40.68.75, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 7D766B82449 for ; Thu, 4 Aug 2022 10:33:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 47E5EC433D6 for ; Thu, 4 Aug 2022 10:33:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1659609187; bh=X4uFWGAVwXFcdLnu41q4OkkyAYNFAfT8+t0Dir/h3gk=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=Cx3qk9T9FzOv51y7g7zXcMbEOzsKZxHUhsFN37z/XONT5BQ71g3BRBQdvaYe9ek/V veqrTAroxMHdCVa/GATqyEarAXYHhwUdPx7vfTyuvZfPUqKBkAbzhDu9wuv6BiCHpS OLJW9ql+QfnkBp2a17LyBOkHos4TrL8PWFV+yKOBJXBsHtv/4qui6TbZtWRo8dBL5H NxLnkrhXZ3e/hrjK2iL8xqARSxpo2yYbh9LIG0fAbJHHVYy03n9sWOewttuT5Chofl YuVPGwoMe94QCiKmSiQd7D7FHHc1/mckwZDWPWtpA+YTkjxzmUcggLFGb7sdMLmH9E epPb4lzeMttBQ== Received: by mail-oi1-f182.google.com with SMTP id t132so1219376oie.6 for ; Thu, 04 Aug 2022 03:33:07 -0700 (PDT) X-Gm-Message-State: ACgBeo220X9mAtqNoTx0FbWs8DZq2NRlP2P/P5DSFv8ztoeFRlZOKT+K nxD19syW8lIipsJHOgNCG92+LoolEJaUv1sg6n8= X-Google-Smtp-Source: AA6agR6WkfdmvueAF3MOWDvkY2I5acgoAYwjfmWr/Jre9NAQOkh12Haummpe+XiKJThb7pasYRUawdcBfQpei+CWIkw= X-Received: by 2002:a05:6808:16ac:b0:33b:32ce:edd8 with SMTP id bb44-20020a05680816ac00b0033b32ceedd8mr538310oib.126.1659609186376; Thu, 04 Aug 2022 03:33:06 -0700 (PDT) MIME-Version: 1.0 References: <20220803143547.27772-1-sami.mujawar@arm.com> In-Reply-To: <20220803143547.27772-1-sami.mujawar@arm.com> From: "Ard Biesheuvel" Date: Thu, 4 Aug 2022 12:32:55 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v1 0/5] Add support to build PRM for AARCH64 using GCC To: Sami Mujawar Cc: edk2-devel-groups-io , Michael Kubacki , Nate DeSimone , Ankit Sinha , npham@amperecomputing.com, loc.ho@amperecomputing.com, Jose Marinho , Samer El-Haj-Mahmoud , Matteo Carlini , Akanksha Jain , Ben Adderson , nd Content-Type: text/plain; charset="UTF-8" On Wed, 3 Aug 2022 at 16:36, Sami Mujawar wrote: > > This patch series adds support to build PRM for AARCH64 using GCC. > > The changes can be seen at: > https://github.com/samimujawar/edk2/tree/2238_aarch64_prm_support_v1 > > Jose Marinho (5): > Basetools/GenFw: Allow AARCH64 builds to use the --prm flag > PrmPkg: Enable external visibility on PRM symbols > PrmPkg: Build Prm Samples with GCC for AARCH64 > PrmPkg: Support AArch64 builds using GCC > PrmPkg: Add details on AArch64 build to the Readme. > i don't maintain any of the packages in question, but the changes look appropriate to me, so Reviewed-by: Ard Biesheuvel