From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web11.11051.1675169146381619457 for ; Tue, 31 Jan 2023 04:45:46 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=YAXk/D/W; spf=pass (domain: kernel.org, ip: 139.178.84.217, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D01EA614E9 for ; Tue, 31 Jan 2023 12:45:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 420D5C433D2 for ; Tue, 31 Jan 2023 12:45:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675169145; bh=oCOyjjvRGry46g78ZwZo9IFu1qOEFlwQVx2jlt5bGKk=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=YAXk/D/WD8B+1lknlBaRXajfkLOtlri3GHX42odUw/Ve8v7GmgSrMyfm7RM1zVKks H3shV2iVn6ynsPJLrwB/kriknHQy8UXNjKvIVlf2QxojK41jYeISx0RCQ/vJ7jW3Ft EUNi3TGrsr+ZctDilk9rFGzCtWHmf3XLSAJQuabOaJOxkkkM7Y/FhfkCViPB4tbWUx Uuh9d9H3couPzM9rC3D7W6F34YCY3zk2F/kIttYRge9sFtXaThfmbG8nhGtycBD5nV dG8dh5VtZTej7wFAOrF8LbPoF3UUwMZCItbh7KsweIM+n9ZV0BEEh3oexOoVhNtwBr 3QyBjzmBitAow== Received: by mail-lj1-f182.google.com with SMTP id o5so1080449ljj.1 for ; Tue, 31 Jan 2023 04:45:45 -0800 (PST) X-Gm-Message-State: AFqh2kp02SJMqc0CI0oRKr9DnWafozM5BhbKaWSi8N2Uy9zo0RCq90+Y FxlPQ4VH/5ovrwG5loU+9hh0Y4ASu5ptc5G9uuQ= X-Google-Smtp-Source: AMrXdXs3fpEuEc1XTVz9xdAiQl+CXCRfGyBzN2HEwZH+nESb6NjxYnm54/Yb6GfiReqATvwnIoMwr37vyrX1Hqi6PV0= X-Received: by 2002:a2e:a812:0:b0:28b:9149:6291 with SMTP id l18-20020a2ea812000000b0028b91496291mr3804909ljq.142.1675169143212; Tue, 31 Jan 2023 04:45:43 -0800 (PST) MIME-Version: 1.0 References: <20230130020925.3395964-1-tommy_huang@aspeedtech.com> In-Reply-To: From: "Ard Biesheuvel" Date: Tue, 31 Jan 2023 13:45:31 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [edk2-non-osi][PATCH V1] ASpeed/ASpeedGopBinPkg: Correct all INF_VERSION value To: Tommy Huang Cc: "devel@edk2.groups.io" , "nathaniel.l.desimone@intel.com" , "isaac.w.oram@intel.com" , "quic_llindhol@quicinc.com" , "michael.d.kinney@intel.com" , Ryan Chen , BMC-SW Content-Type: text/plain; charset="UTF-8" On Tue, 31 Jan 2023 at 12:52, Tommy Huang wrote: > > Hi Ard, > > Thanks for your review. > > Because I have saw the last patch has been accepted into https://github.com/tianocore/edk2-non-osi.git > So, I use another patch to fix the typo. > Do you mean that I need to send my last patch again with corrected the .inf files? > > BR, > > by Tommy > Please resend the patch with me on cc. It seems the list management software has corrupted the patch. > > -----Original Message----- > > From: Ard Biesheuvel > > Sent: Tuesday, January 31, 2023 7:38 PM > > To: devel@edk2.groups.io; Tommy Huang > > Cc: nathaniel.l.desimone@intel.com; isaac.w.oram@intel.com; > > quic_llindhol@quicinc.com; michael.d.kinney@intel.com; Ryan Chen > > ; BMC-SW > > Subject: Re: [edk2-devel] [edk2-non-osi][PATCH V1] ASpeed/ASpeedGopBinPkg: > > Correct all INF_VERSION value > > > > On Mon, 30 Jan 2023 at 03:09, Tommy Huang > > wrote: > > > > > > 1. Correct all INF_VERSION value. > > > > > > Cc: Isaac Oram > > > Cc: Nate DeSimone > > > Cc: Leif Lindholm > > > Cc: Michael D Kinney > > > Cc: Ryan Chen > > > Cc: BMC-SW > > > > > > Signed-off-by: Tommy Huang > > > > This patch does not apply > > > > Please generate your patch against > > https://github.com/tianocore/edk2-non-osi.git > > > > > > > --- > > > Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2500GopDxe.inf | 4 ++-- > > > Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2600GopDxe.inf | 4 ++-- > > > 2 files changed, 4 insertions(+), 4 deletions(-) > > > > > > diff --git a/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2500GopDxe.inf > > > b/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2500GopDxe.inf > > > index d6a674c..6bda488 100644 > > > --- a/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2500GopDxe.inf > > > +++ b/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2500GopDxe.inf > > > @@ -10,11 +10,11 @@ > > > ## > > > > > > > > > > > > [Defines] > > > > > > - INF_VERSION = 0x00011302 > > > + INF_VERSION = 1.29 > > > BASE_NAME = ASpeedAst2500GopDxe > > > > > > FILE_GUID = > > 7F81D838-F91D-4C44-8552-8FB912122FDD > > > > > > MODULE_TYPE = UEFI_DRIVER > > > > > > - VERSION_STRING = 1.29 > > > + VERSION_STRING = 1.13.02 > > > > > > > > > [Binaries.AArch64] > > > > > > PE32|AArch64/ASpeedAst2500Gop.efi|* > > > > > > diff --git a/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2600GopDxe.inf > > > b/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2600GopDxe.inf > > > index a652ced..3375407 100644 > > > --- a/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2600GopDxe.inf > > > +++ b/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2600GopDxe.inf > > > @@ -9,11 +9,11 @@ > > > ## > > > > > > [Defines] > > > - INF_VERSION = 0x00011302 > > > + INF_VERSION = 1.29 > > > BASE_NAME = ASpeedAst2600GopDxe > > > FILE_GUID = > > 36f08597-2a8d-4824-9416-59c810b0d9f3 > > > MODULE_TYPE = UEFI_DRIVER > > > - VERSION_STRING = 1.29 > > > + VERSION_STRING = 1.13.02 > > > > > > [Binaries.AArch64] > > > PE32|AArch64/ASpeedAst2600Gop.efi|* > > > -- > > > 2.25.1 > > > > > > > > > > > > > > > > > >