From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 699D278003C for ; Thu, 2 May 2024 09:37:54 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=CHrRt4Mw5LE8d5c3EwWnKGASf1pR1b2YU4pUyfApSUM=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20240206; t=1714642673; v=1; b=2ILrxuf/+Ji+X1XKS7mhna5hAUVNv/IB3MyuNVFPCAfXcF5aLr+AqdQ0Bj2AE44TNsJyoER/ 8x2mS4iZufZOwr/6n9F1inlD+/YipdOhmJAQuDV+TFIRJQ7ylh9T+OvAa9Mc3KNWp80cYA+HL6K hRAywMKBcN4EdhQuLGlCUJ1pAZFJaz4mlvdgGNz3fJM48VVUli516bZXIQV5AGB0Go0XthLG1pU 5najLQrRQa1zI3k8HuzbgGNrZ5LXQaeJeNKe3CBQ4bB4C/KFjDw1DDfFUsJY+THsremniWDPY/V IEMuUEuZnqD3o8Ug8TdoVdy6z6z6nYhWJ5zyDV8kmBfbg== X-Received: by 127.0.0.2 with SMTP id WrcSYY7687511x5hJkfbG3HU; Thu, 02 May 2024 02:37:53 -0700 X-Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by mx.groups.io with SMTP id smtpd.web11.9426.1714642671841356358 for ; Thu, 02 May 2024 02:37:52 -0700 X-Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 7A754CE147B; Thu, 2 May 2024 09:37:48 +0000 (UTC) X-Received: by smtp.kernel.org (Postfix) with ESMTPSA id BE6D6C32789; Thu, 2 May 2024 09:37:46 +0000 (UTC) X-Received: by mail-lf1-f49.google.com with SMTP id 2adb3069b0e04-51f300b318cso381791e87.3; Thu, 02 May 2024 02:37:46 -0700 (PDT) X-Gm-Message-State: Pdc40tHspOYXPOafQUTAGschx7686176AA= X-Google-Smtp-Source: AGHT+IHsJHRq6PrhtT7YGfa6HDicmhIuk355SLobrCaQfnks4I0XN87LiK5VOjhqYQaCqs4K6pY+ij4v6/ll6CzAy4Y= X-Received: by 2002:a05:6512:401e:b0:51b:79b7:8398 with SMTP id br30-20020a056512401e00b0051b79b78398mr3250134lfb.57.1714642665029; Thu, 02 May 2024 02:37:45 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: "Ard Biesheuvel" Date: Thu, 2 May 2024 11:37:31 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] Proposal to switch TianoCore Code Review from email to GitHub Pull Requests on 5-24-2024 To: devel@edk2.groups.io, michael.d.kinney@intel.com Cc: "rfc@edk2.groups.io" , Leif Lindholm , "Andrew Fish (afish@apple.com)" Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Thu, 02 May 2024 02:37:52 -0700 Resent-From: ardb@kernel.org Reply-To: devel@edk2.groups.io,ardb@kernel.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b="2ILrxuf/"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io On Wed, 1 May 2024 at 19:44, Michael D Kinney wrote: > > Hello, > > I would like to propose that TianoCore move all code review from email > based code reviews to GitHub Pull Requests based code reviews. > > The proposed date to switch would be immediately after the next stable > tag which is currently scheduled for May 24, 2024. > +1 Some kind of off-github reflector similar to rebecca's public inbox [0] would be appreciated to at least be able to keep track of different versions of a series exactly as they were submitted. One of the things that annoys me about doing GitHub reviews is dealing with PRs where the underlying branches gets updated through a force-push and there is no way to find out what changed, and whether the existing review comments are still in sync. Would it be possible to require a separate PR for each revision of a series, lock the underlying branch, and archive it for future reference (if desired?) [0] https://openfw.io/edk2-devel/ -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118503): https://edk2.groups.io/g/devel/message/118503 Mute This Topic: https://groups.io/mt/105847510/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-