From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web09.605.1665077979269390760 for ; Thu, 06 Oct 2022 10:39:39 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ZHHuWASC; spf=pass (domain: kernel.org, ip: 139.178.84.217, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8EC88619DD for ; Thu, 6 Oct 2022 17:39:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EC1D6C43470 for ; Thu, 6 Oct 2022 17:39:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1665077978; bh=Ol+dvzdNoMzYVhA4N3NBCd5yUM3H+DOnFGYEBzUwRTw=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=ZHHuWASCdBP0kBuzJ/nlPihfAGH1q/oQrNJYnS91bDWdMaa4Xm6gDc11nt8qs8SFR f0o5MG/DCHDrgXaOoSCluCkdFpxoiOpsafPVq7Rq+bJn5wT5nYq79mVbzX8peOnmhe MZVSUzI4hwX3Dg0q6zwTc/cCFmldJ1tzyTVJFGecVBfIiZVNW65UsNXFmG75qxPm3T otgIB8ZA9B5AgQzA6GYo0guASepMHsdBaIsJMsSPaoBKwfQyw1E4Jp9z/LhATTsKmK GyNvdbzYMk7selHFVWDPYsdBhH4G3aGpByWmQZOMfBFymc8KFOiYigXcpNikV5KvkT KbXoIxB4iorkg== Received: by mail-lj1-f171.google.com with SMTP id s10so3046458ljp.5 for ; Thu, 06 Oct 2022 10:39:37 -0700 (PDT) X-Gm-Message-State: ACrzQf11TT5gUH1miabp3jsygQD+egxRxF5HEnjWxjWS+NB02GVDtf9r IlLu+Zc18jq6sdkBRvHuCP3mrd99q8JWgjIhKyk= X-Google-Smtp-Source: AMsMyM6RP+EqtdVQk6/wIcDQjb7cUgNQJYYIrV+4aGVBv7+Oq2P3ijNpDv4ogukhftQpkLIHbyQCeDAs6LjUqDORSxY= X-Received: by 2002:a05:651c:239c:b0:26d:94b8:781d with SMTP id bk28-20020a05651c239c00b0026d94b8781dmr259215ljb.189.1665077975964; Thu, 06 Oct 2022 10:39:35 -0700 (PDT) MIME-Version: 1.0 References: <5fe03c70ba8a5937210bab6ff10ff2cf6b72ff12.1665067370.git.jbrasen@nvidia.com> In-Reply-To: <5fe03c70ba8a5937210bab6ff10ff2cf6b72ff12.1665067370.git.jbrasen@nvidia.com> From: "Ard Biesheuvel" Date: Thu, 6 Oct 2022 19:39:24 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2] MdeModulePkg/UefiBootManagerLib: Add Disk Info support for Ufs To: Jeff Brasen Cc: devel@edk2.groups.io, gaoliming@byosoft.com.cn, jian.j.wang@intel.com, zhichao.gao@intel.com, ray.ni@intel.com Content-Type: text/plain; charset="UTF-8" Merged #3447 into master. On Thu, 6 Oct 2022 at 16:44, Jeff Brasen wrote: > > Add support for getting disk info from UFS devices. > > Signed-off-by: Jeff Brasen > --- > MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c | 4 +++- > .../Library/UefiBootManagerLib/UefiBootManagerLib.inf | 1 + > 2 files changed, 4 insertions(+), 1 deletion(-) > > diff --git a/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c b/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c > index fac33b9ee9..030b2ee3ec 100644 > --- a/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c > +++ b/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c > @@ -195,7 +195,9 @@ BmGetDescriptionFromDiskInfo ( > > BmEliminateExtraSpaces (Description); > } > - } else if (CompareGuid (&DiskInfo->Interface, &gEfiDiskInfoScsiInterfaceGuid)) { > + } else if (CompareGuid (&DiskInfo->Interface, &gEfiDiskInfoScsiInterfaceGuid) || > + CompareGuid (&DiskInfo->Interface, &gEfiDiskInfoUfsInterfaceGuid)) > + { > BufferSize = sizeof (EFI_SCSI_INQUIRY_DATA); > Status = DiskInfo->Inquiry ( > DiskInfo, > diff --git a/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf b/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf > index fe05d5f1cc..2fc0a80a4e 100644 > --- a/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf > +++ b/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf > @@ -85,6 +85,7 @@ > gEfiDiskInfoIdeInterfaceGuid ## SOMETIMES_CONSUMES ## GUID > gEfiDiskInfoScsiInterfaceGuid ## SOMETIMES_CONSUMES ## GUID > gEfiDiskInfoSdMmcInterfaceGuid ## SOMETIMES_CONSUMES ## GUID > + gEfiDiskInfoUfsInterfaceGuid ## SOMETIMES_CONSUMES ## GUID > > [Protocols] > gEfiPciRootBridgeIoProtocolGuid ## CONSUMES > -- > 2.25.1 >