Re: [edk2-devel] [PATCH v4 1/5] OvmfPkg/PlatformInitLib: Add PlatformScanE820 and GetFirstNonAddressCB

["Ard Biesheuvel" <ardb@kernel.org>]

On Tue, 17 Jan 2023 at 15:47, Laszlo Ersek <lersek@redhat.com> wrote:
>
> On 1/17/23 13:16, Gerd Hoffmann wrote:
>
> > +/**
> > +  Store first address not used by e820 RAM entries in
> > +  PlatformInfoHob->FirstNonAddress
> > +**/
> > +VOID
> > +PlatformGetFirstNonAddressCB (
> > +  IN     EFI_E820_ENTRY64       *E820Entry,
> > +  IN OUT EFI_HOB_PLATFORM_INFO  *PlatformInfoHob
> > +  )
> > +{
> > +  UINT64  Candidate;
> > +
> > +  if (E820Entry->Type != EfiAcpiAddressRangeMemory) {
> > +    return;
> > +  }
> > +
> > +  Candidate = E820Entry->BaseAddr + E820Entry->Length;
> > +  if (PlatformInfoHob->FirstNonAddress < Candidate) {
> > +    DEBUG ((DEBUG_INFO, "%a: FirstNonAddress=0x%Lx\n", __FUNCTION__, Candidate));
> > +    PlatformInfoHob->FirstNonAddress = Candidate;
> > +  }
> > +}
>
> This could have been made STATIC (like the other three callbacks), but
> it's not important.
>

I can fix that up at merge time

Thanks,