Re: [edk2-devel] [PATCH 3/3] StandaloneMmPkg:Remove MpInformation.h

["Ard Biesheuvel" <ardb@kernel.org>]

Thanks for the clarification.

On Thu, 4 Jan 2024 at 03:21, Tan, Dun <dun.tan@intel.com> wrote:
>
> Hi Ard,
>
> This patch set has been dropped. Another patch set "Create and consume a new gMpInformationHobGuid2 in UefiCpuPkg." is adopted.
> When the Maximum length 64KB is not enough, there might be more than 1 HOB instance of this gMpInformationHobGuid2.
> There is no change in  ARM related code in the new patch set.
>
> Thanks,
> Dun
>
> -----Original Message-----
> From: Ard Biesheuvel <ardb@kernel.org>
> Sent: Wednesday, January 3, 2024 11:12 PM
> To: devel@edk2.groups.io; Tan, Dun <dun.tan@intel.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>; Sami Mujawar <sami.mujawar@arm.com>; Ni, Ray <ray.ni@intel.com>
> Subject: Re: [edk2-devel] [PATCH 3/3] StandaloneMmPkg:Remove MpInformation.h
>
> On Thu, 9 Nov 2023 at 03:51, duntan <dun.tan@intel.com> wrote:
> >
> > Remove MpInformation.h in StandaloneMmPkg since it has been moved to
> > UefiCpuPkg
> >
> > Signed-off-by: Dun Tan <dun.tan@intel.com>
> > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> > Cc: Sami Mujawar <sami.mujawar@arm.com>
> > Cc: Ray Ni <ray.ni@intel.com>
>
> Doesn't this break the ARM build?
>
>
> > ---
> >  StandaloneMmPkg/Drivers/StandaloneMmCpu/StandaloneMmCpu.inf                       |  1 +
> >  StandaloneMmPkg/Include/Guid/MpInformation.h                                      | 35 -----------------------------------
> >  StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/StandaloneMmCoreEntryPoint.inf |  1 +
> >  StandaloneMmPkg/StandaloneMmPkg.dec                                               |  1 -
> >  4 files changed, 2 insertions(+), 36 deletions(-)
> >
> > diff --git
> > a/StandaloneMmPkg/Drivers/StandaloneMmCpu/StandaloneMmCpu.inf
> > b/StandaloneMmPkg/Drivers/StandaloneMmCpu/StandaloneMmCpu.inf
> > index 1fcb17d89d..4ed0e395c8 100644
> > --- a/StandaloneMmPkg/Drivers/StandaloneMmCpu/StandaloneMmCpu.inf
> > +++ b/StandaloneMmPkg/Drivers/StandaloneMmCpu/StandaloneMmCpu.inf
> > @@ -27,6 +27,7 @@
> >    MdePkg/MdePkg.dec
> >    MdeModulePkg/MdeModulePkg.dec
> >    StandaloneMmPkg/StandaloneMmPkg.dec
> > +  UefiCpuPkg/UefiCpuPkg.dec
> >
> >  [LibraryClasses]
> >    ArmLib
> > diff --git a/StandaloneMmPkg/Include/Guid/MpInformation.h
> > b/StandaloneMmPkg/Include/Guid/MpInformation.h
> > deleted file mode 100644
> > index dbf88d12de..0000000000
> > --- a/StandaloneMmPkg/Include/Guid/MpInformation.h
> > +++ /dev/null
> > @@ -1,35 +0,0 @@
> > -/** @file
> > -  EFI MP information protocol provides a lightweight MP_SERVICES_PROTOCOL.
> > -
> > -  MP information protocol only provides static information of MP processor.
> > -
> > -  Copyright (c) 2009, Intel Corporation. All rights reserved.<BR>
> > -  Copyright (c) 2016 - 2018, ARM Limited. All rights reserved.<BR>
> > -
> > -  SPDX-License-Identifier: BSD-2-Clause-Patent
> > -
> > -**/
> > -
> > -#ifndef _MP_INFORMATION_H_
> > -#define _MP_INFORMATION_H_
> > -
> > -#include <Protocol/MpService.h>
> > -#include <PiPei.h>
> > -#include <Ppi/SecPlatformInformation.h>
> > -
> > -#define MP_INFORMATION_GUID \
> > -  { \
> > -    0xba33f15d, 0x4000, 0x45c1, {0x8e, 0x88, 0xf9, 0x16, 0x92, 0xd4, 0x57, 0xe3}  \
> > -  }
> > -
> > -#pragma pack(1)
> > -typedef struct {
> > -  UINT64                       NumberOfProcessors;
> > -  UINT64                       NumberOfEnabledProcessors;
> > -  EFI_PROCESSOR_INFORMATION    ProcessorInfoBuffer[];
> > -} MP_INFORMATION_HOB_DATA;
> > -#pragma pack()
> > -
> > -extern EFI_GUID  gMpInformationHobGuid;
> > -
> > -#endif
> > diff --git
> > a/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/StandaloneMmCoreE
> > ntryPoint.inf
> > b/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/StandaloneMmCoreE
> > ntryPoint.inf
> > index 75cfb98c0e..1fc31360ce 100644
> > ---
> > a/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/StandaloneMmCoreE
> > ntryPoint.inf
> > +++ b/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/StandaloneMmC
> > +++ oreEntryPoint.inf
> > @@ -33,6 +33,7 @@
> >    MdePkg/MdePkg.dec
> >    MdeModulePkg/MdeModulePkg.dec
> >    StandaloneMmPkg/StandaloneMmPkg.dec
> > +  UefiCpuPkg/UefiCpuPkg.dec
> >
> >  [Packages.ARM, Packages.AARCH64]
> >    ArmPkg/ArmPkg.dec
> > diff --git a/StandaloneMmPkg/StandaloneMmPkg.dec
> > b/StandaloneMmPkg/StandaloneMmPkg.dec
> > index 46784d94e4..01f37deebb 100644
> > --- a/StandaloneMmPkg/StandaloneMmPkg.dec
> > +++ b/StandaloneMmPkg/StandaloneMmPkg.dec
> > @@ -36,7 +36,6 @@
> >
> >  [Guids]
> >    gStandaloneMmPkgTokenSpaceGuid           = { 0x18fe7632, 0xf5c8, 0x4e63, { 0x8d, 0xe8, 0x17, 0xa5, 0x5c, 0x59, 0x13, 0xbd }}
> > -  gMpInformationHobGuid                    = { 0xba33f15d, 0x4000, 0x45c1, { 0x8e, 0x88, 0xf9, 0x16, 0x92, 0xd4, 0x57, 0xe3 }}
> >    gMmFvDispatchGuid                        = { 0xb65694cc, 0x09e3, 0x4c3b, { 0xb5, 0xcd, 0x05, 0xf4, 0x4d, 0x3c, 0xdb, 0xff }}
> >
> >    ## Include/Guid/MmCoreData.h
> > --
> > 2.31.1.windows.1
> >
> >
> >
> > 
> >
> >


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#113149): https://edk2.groups.io/g/devel/message/113149
Mute This Topic: https://groups.io/mt/102479012/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-