public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [edk2-platforms PATCH 1/1] Marvell: Add VariableFlashInfoLib
@ 2022-06-09 23:51 Marcin Wojtas
  2022-06-10  0:33 ` [edk2-devel] " Michael Kubacki
  2022-06-10  8:12 ` Sunny Wang
  0 siblings, 2 replies; 4+ messages in thread
From: Marcin Wojtas @ 2022-06-09 23:51 UTC (permalink / raw)
  To: devel
  Cc: quic_llindhol, ardb+tianocore, mw, jaz, gjb, upstream, sunny.Wang,
	michael.kubacki

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479

This patch adds an instance for the library class VariableFlashInfoLib
that was recently introduced in MdeModulePkg. This change is made to
allow the new variable driver to build that has a dependency on
this library class and does not require any further platform changes.

Signed-off-by: Marcin Wojtas <mw@semihalf.com>
---
 Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
index 9322ad881e..b64c0ffdee 100644
--- a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
+++ b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
@@ -69,6 +69,7 @@
   UefiHiiServicesLib|MdeModulePkg/Library/UefiHiiServicesLib/UefiHiiServicesLib.inf
   UefiRuntimeLib|MdePkg/Library/UefiRuntimeLib/UefiRuntimeLib.inf
   UefiUsbLib|MdePkg/Library/UefiUsbLib/UefiUsbLib.inf
+  VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.inf
   VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf
 
   PcdLib|MdePkg/Library/DxePcdLib/DxePcdLib.inf
-- 
2.29.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [edk2-devel] [edk2-platforms PATCH 1/1] Marvell: Add VariableFlashInfoLib
  2022-06-09 23:51 [edk2-platforms PATCH 1/1] Marvell: Add VariableFlashInfoLib Marcin Wojtas
@ 2022-06-10  0:33 ` Michael Kubacki
  2022-06-10  8:12 ` Sunny Wang
  1 sibling, 0 replies; 4+ messages in thread
From: Michael Kubacki @ 2022-06-10  0:33 UTC (permalink / raw)
  To: devel, mw
  Cc: quic_llindhol, ardb+tianocore, jaz, gjb, upstream, sunny.Wang,
	michael.kubacki

Reviewed-by: Michael Kubacki <michael.kubacki@microsoft.com>

On 6/9/2022 7:51 PM, Marcin Wojtas wrote:
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
> 
> This patch adds an instance for the library class VariableFlashInfoLib
> that was recently introduced in MdeModulePkg. This change is made to
> allow the new variable driver to build that has a dependency on
> this library class and does not require any further platform changes.
> 
> Signed-off-by: Marcin Wojtas <mw@semihalf.com>
> ---
>   Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
> index 9322ad881e..b64c0ffdee 100644
> --- a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
> +++ b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
> @@ -69,6 +69,7 @@
>     UefiHiiServicesLib|MdeModulePkg/Library/UefiHiiServicesLib/UefiHiiServicesLib.inf
> 
>     UefiRuntimeLib|MdePkg/Library/UefiRuntimeLib/UefiRuntimeLib.inf
> 
>     UefiUsbLib|MdePkg/Library/UefiUsbLib/UefiUsbLib.inf
> 
> +  VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.inf
> 
>     VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf
> 
>   
> 
>     PcdLib|MdePkg/Library/DxePcdLib/DxePcdLib.inf
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [edk2-platforms PATCH 1/1] Marvell: Add VariableFlashInfoLib
  2022-06-09 23:51 [edk2-platforms PATCH 1/1] Marvell: Add VariableFlashInfoLib Marcin Wojtas
  2022-06-10  0:33 ` [edk2-devel] " Michael Kubacki
@ 2022-06-10  8:12 ` Sunny Wang
  2022-06-10  9:18   ` [edk2-devel] " Ard Biesheuvel
  1 sibling, 1 reply; 4+ messages in thread
From: Sunny Wang @ 2022-06-10  8:12 UTC (permalink / raw)
  To: Marcin Wojtas, devel@edk2.groups.io
  Cc: quic_llindhol@quicinc.com, ardb+tianocore@kernel.org,
	jaz@semihalf.com, gjb@semihalf.com, upstream@semihalf.com,
	michael.kubacki@microsoft.com

Reviewed-by: Sunny Wang <sunny.wang@arm.com>

-----Original Message-----
From: Marcin Wojtas <mw@semihalf.com>
Sent: 10 June 2022 00:51
To: devel@edk2.groups.io
Cc: quic_llindhol@quicinc.com; ardb+tianocore@kernel.org; mw@semihalf.com; jaz@semihalf.com; gjb@semihalf.com; upstream@semihalf.com; Sunny Wang <Sunny.Wang@arm.com>; michael.kubacki@microsoft.com
Subject: [edk2-platforms PATCH 1/1] Marvell: Add VariableFlashInfoLib

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479

This patch adds an instance for the library class VariableFlashInfoLib
that was recently introduced in MdeModulePkg. This change is made to
allow the new variable driver to build that has a dependency on
this library class and does not require any further platform changes.

Signed-off-by: Marcin Wojtas <mw@semihalf.com>
---
 Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
index 9322ad881e..b64c0ffdee 100644
--- a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
+++ b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
@@ -69,6 +69,7 @@
   UefiHiiServicesLib|MdeModulePkg/Library/UefiHiiServicesLib/UefiHiiServicesLib.inf

   UefiRuntimeLib|MdePkg/Library/UefiRuntimeLib/UefiRuntimeLib.inf

   UefiUsbLib|MdePkg/Library/UefiUsbLib/UefiUsbLib.inf

+  VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.inf

   VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf



   PcdLib|MdePkg/Library/DxePcdLib/DxePcdLib.inf

--
2.29.0

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [edk2-devel] [edk2-platforms PATCH 1/1] Marvell: Add VariableFlashInfoLib
  2022-06-10  8:12 ` Sunny Wang
@ 2022-06-10  9:18   ` Ard Biesheuvel
  0 siblings, 0 replies; 4+ messages in thread
From: Ard Biesheuvel @ 2022-06-10  9:18 UTC (permalink / raw)
  To: edk2-devel-groups-io, Sunny Wang
  Cc: Marcin Wojtas, quic_llindhol@quicinc.com,
	ardb+tianocore@kernel.org, jaz@semihalf.com, gjb@semihalf.com,
	upstream@semihalf.com, michael.kubacki@microsoft.com

On Fri, 10 Jun 2022 at 10:13, Sunny Wang <Sunny.Wang@arm.com> wrote:
>
> Reviewed-by: Sunny Wang <sunny.wang@arm.com>
>
> -----Original Message-----
> From: Marcin Wojtas <mw@semihalf.com>
> Sent: 10 June 2022 00:51
> To: devel@edk2.groups.io
> Cc: quic_llindhol@quicinc.com; ardb+tianocore@kernel.org; mw@semihalf.com; jaz@semihalf.com; gjb@semihalf.com; upstream@semihalf.com; Sunny Wang <Sunny.Wang@arm.com>; michael.kubacki@microsoft.com
> Subject: [edk2-platforms PATCH 1/1] Marvell: Add VariableFlashInfoLib
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
>
> This patch adds an instance for the library class VariableFlashInfoLib
> that was recently introduced in MdeModulePkg. This change is made to
> allow the new variable driver to build that has a dependency on
> this library class and does not require any further platform changes.
>
> Signed-off-by: Marcin Wojtas <mw@semihalf.com>

Pushed as 86119cb4962f..242e681ed8ed

Thanks all,


> ---
>  Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
> index 9322ad881e..b64c0ffdee 100644
> --- a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
> +++ b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
> @@ -69,6 +69,7 @@
>    UefiHiiServicesLib|MdeModulePkg/Library/UefiHiiServicesLib/UefiHiiServicesLib.inf
>
>    UefiRuntimeLib|MdePkg/Library/UefiRuntimeLib/UefiRuntimeLib.inf
>
>    UefiUsbLib|MdePkg/Library/UefiUsbLib/UefiUsbLib.inf
>
> +  VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.inf
>
>    VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf
>
>
>
>    PcdLib|MdePkg/Library/DxePcdLib/DxePcdLib.inf
>
> --
> 2.29.0
>
> IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
>
>
> 
>
>

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-06-10  9:18 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-06-09 23:51 [edk2-platforms PATCH 1/1] Marvell: Add VariableFlashInfoLib Marcin Wojtas
2022-06-10  0:33 ` [edk2-devel] " Michael Kubacki
2022-06-10  8:12 ` Sunny Wang
2022-06-10  9:18   ` [edk2-devel] " Ard Biesheuvel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox