From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mx.groups.io with SMTP id smtpd.web11.8178.1628080405159944114 for ; Wed, 04 Aug 2021 05:33:25 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=LSsMjdqN; spf=pass (domain: kernel.org, ip: 198.145.29.99, mailfrom: ardb@kernel.org) Received: by mail.kernel.org (Postfix) with ESMTPSA id 56B3060E8D for ; Wed, 4 Aug 2021 12:33:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1628080404; bh=uPKM6uDnnMPzJmfSvLt7ekNBfuG5CIW61BTyBA2BSok=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=LSsMjdqNZqnbabVxlVvgNC9kbw3ubb9fSbn2rFgRbwft5wJbe1hDLAgPJ22pFQMqh Av8Cbrpl/bqOZVLtU4USMpXG3HKtAo353euMMLxguzkXu3JV4jn7P7qUZ4bYwrVJeF lrRCe6tgGExte7WW5olppqQCXMWBMN3kG4xoBvx1JMaaHJzNzRz/fI7iIXEbPsu9qO cqyxHgVnIoO9Pa2uw8cubrCpKasnVB8mwOSylqNRvFgYJLR/wVnt8GcoBIrCpiZNt1 1bDibdaxdzzoND2wSCzlZO0NlWtfA0S4J/8kF0i9ys3crSTNkGTy8TqkmfAZYxaH4W n/4OQPpKgZSgw== Received: by mail-oi1-f181.google.com with SMTP id x15so2596232oic.9 for ; Wed, 04 Aug 2021 05:33:24 -0700 (PDT) X-Gm-Message-State: AOAM530FTfDEf1FymJk9gVGCJwQEWmxZ25f7WayMlsFmhS5pGpp6g+Sp 2YZ8taXFIbQT0CcUbS49krBWWPhO/3Y/yfBO9tI= X-Google-Smtp-Source: ABdhPJxz6ip2mPF8FxkD36F1KashchSXJULZGw+vrmq05+0vmPoAlE6Rjk/c32XPEDAVRdKoOvE7TgXmkG1DzqUoPaI= X-Received: by 2002:a05:6808:245:: with SMTP id m5mr5662876oie.174.1628080403688; Wed, 04 Aug 2021 05:33:23 -0700 (PDT) MIME-Version: 1.0 References: <20210714123045.1340940-1-gjb@semihalf.com> <01b601d788d7$64ca88a0$2e5f99e0$@byosoft.com.cn> In-Reply-To: <01b601d788d7$64ca88a0$2e5f99e0$@byosoft.com.cn> From: "Ard Biesheuvel" Date: Wed, 4 Aug 2021 14:33:12 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: =?UTF-8?B?UmU6IFtlZGsyLWRldmVsXSDlm57lpI06IFtlZGsyLXBsYXRmb3JtcyBQQVRDSCB2NiAwLzRdIFNlY3VyZSBCb290IGRlZmF1bHQga2V5cw==?= To: edk2-devel-groups-io , "Liming Gao (Byosoft address)" Cc: Sunny Wang , Grzegorz Bernacki , Ard Biesheuvel , Leif Lindholm , Samer El-Haj-Mahmoud , Marcin Wojtas , upstream@semihalf.com, Jiewen Yao , Jian J Wang , Min Xu , Laszlo Ersek , Sami Mujawar , Andrew Fish , Ray Ni , Jordan Justen , Rebecca Cran , Peter Grehan , Thomas Abraham , Chasel Chiu , Nate DeSimone , Eric Dong , Michael Kinney , "Sun, Zailiang" , "Qian, Yi" , Graeme Gregory , Radoslaw Biernacki , Peter Batard Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 4 Aug 2021 at 04:21, gaoliming wrote: > > Sunny: > I am OK to merge the reviewed patched first. > Patches 2-4 merged as 2f0188b56ef4..5ba08a9b7516 Thanks all > > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > > =E5=8F=91=E4=BB=B6=E4=BA=BA: Sunny Wang > > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2021=E5=B9=B48=E6=9C=883=E6=97= =A5 22:11 > > =E6=94=B6=E4=BB=B6=E4=BA=BA: Grzegorz Bernacki ; dev= el@edk2.groups.io; > > ardb+tianocore@kernel.org > > =E6=8A=84=E9=80=81: leif@nuviainc.com; Samer El-Haj-Mahmoud > > ; mw@semihalf.com; > > upstream@semihalf.com; jiewen.yao@intel.com; jian.j.wang@intel.com; > > min.m.xu@intel.com; lersek@redhat.com; Sami Mujawar > > ; afish@apple.com; ray.ni@intel.com; > > jordan.l.justen@intel.com; rebecca@bsdio.com; grehan@freebsd.org; > > Thomas Abraham ; chasel.chiu@intel.com; > > nathaniel.l.desimone@intel.com; gaoliming@byosoft.com.cn; > > eric.dong@intel.com; michael.d.kinney@intel.com; zailiang.sun@intel.co= m; > > yi.qian@intel.com; graeme@nuviainc.com; rad@semihalf.com; pete@akeo.ie= ; > > Sunny Wang > > =E4=B8=BB=E9=A2=98: RE: [edk2-platforms PATCH v6 0/4] Secure Boot defa= ult keys > > > > Hi Ard and Maintainers, > > > > For this patchset, > > 1/4 - Intel Platforms: add SecureBootVariableLib class resolution > > 2/4 - ARM Silicon and Platforms: add SecureBootVariableLib class > resolution > > 3/4 - RISC-V Platforms: add SecureBootVariableLib class resolution > > 4/4 - Platform/RaspberryPi: Enable default Secure Boot variables > > initialization > > > > Only Intel platform patch (1/4) hasn't got all Review-bys. I offline s= ent > a > > reminder to Intel platform Maintainers. I think they may be busy with > other > > things or need more time to review it. > > > > Therefore, how about we merge another three patches (2/4, 3/4, and 4/4= ) > > first? > > > > Best Regards, > > Sunny Wang > > > > -----Original Message----- > > From: Grzegorz Bernacki > > Sent: Wednesday, July 14, 2021 8:31 PM > > To: devel@edk2.groups.io > > Cc: leif@nuviainc.com; ardb+tianocore@kernel.org; Samer El-Haj-Mahmoud > > ; Sunny Wang ; > > mw@semihalf.com; upstream@semihalf.com; jiewen.yao@intel.com; > > jian.j.wang@intel.com; min.m.xu@intel.com; lersek@redhat.com; Sami > > Mujawar ; afish@apple.com; ray.ni@intel.com; > > jordan.l.justen@intel.com; rebecca@bsdio.com; grehan@freebsd.org; > > Thomas Abraham ; chasel.chiu@intel.com; > > nathaniel.l.desimone@intel.com; gaoliming@byosoft.com.cn; > > eric.dong@intel.com; michael.d.kinney@intel.com; zailiang.sun@intel.co= m; > > yi.qian@intel.com; graeme@nuviainc.com; rad@semihalf.com; pete@akeo.ie= ; > > Grzegorz Bernacki > > Subject: [edk2-platforms PATCH v6 0/4] Secure Boot default keys > > > > This patchset is a consequence of "Secure Boot default keys" > > patchset in edk2. It adds SecureBootVariableLib class resolution > > for each platform which uses SecureBootConfigDxe and also > > enables Secure Boot variables initialization for RPi4. > > Previously these commits were part of edk2 patchset, but since > > number of commits increased in v5 version, it is now separate > > patchset. > > > > Changes related to both edk2 & edk-platform versions: > > Changes since v1: > > - change names: > > SecBootVariableLib =3D> SecureBootVariableLib > > SecBootDefaultKeysDxe =3D> SecureBootDefaultKeysDxe > > SecEnrollDefaultKeysApp =3D> EnrollFromDefaultKeysApp > > - change name of function CheckSetupMode to GetSetupMode > > - remove ShellPkg dependecy from EnrollFromDefaultKeysApp > > - rebase to master > > > > Changes since v2: > > - fix coding style for functions headers in SecureBootVariableLib.h > > - add header to SecureBootDefaultKeys.fdf.inc > > - remove empty line spaces in SecureBootDefaultKeysDxe files > > - revert FAIL macro in EnrollFromDefaultKeysApp > > - remove functions duplicates and add SecureBootVariableLib > > to platforms which used it > > > > Changes since v3: > > - move SecureBootDefaultKeys.fdf.inc to ArmPlatformPkg > > - leave duplicate of CreateTimeBasedPayload in PlatformVarCleanupLib > > - fix typo in guid description > > > > Changes since v4: > > - reorder patches to make it bisectable > > - split commits related to more than one platform > > - move edk2-platform commits to separate patchset > > > > Changes since v5: > > - split SecureBootVariableLib into SecureBootVariableLib and > > SecureBootVariableProvisionLib > > > > Grzegorz Bernacki (4): > > Intel Platforms: add SecureBootVariableLib class resolution > > ARM Silicon and Platforms: add SecureBootVariableLib class resolutio= n > > RISC-V Platforms: add SecureBootVariableLib class resolution > > Platform/RaspberryPi: Enable default Secure Boot variables > > initialization > > > > Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > > | 2 ++ > > Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc > > | 2 ++ > > Platform/Intel/QuarkPlatformPkg/Quark.dsc > > | 2 ++ > > Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc > > | 2 ++ > > Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc > > | 2 ++ > > Platform/Qemu/SbsaQemu/SbsaQemu.dsc > > | 2 ++ > > Platform/RaspberryPi/RPi3/RPi3.dsc > > | 2 ++ > > Platform/RaspberryPi/RPi4/RPi4.dsc > > | 4 ++++ > > Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc > > | 2 ++ > > > > Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc > > | 2 ++ > > Platform/Socionext/DeveloperBox/DeveloperBox.dsc > > | 5 +++++ > > Platform/RaspberryPi/RPi4/RPi4.fdf > > | 2 ++ > > 12 files changed, 29 insertions(+) > > > > -- > > 2.25.1 > > > > IMPORTANT NOTICE: The contents of this email and any attachments are > > confidential and may also be privileged. If you are not the intended > recipient, > > please notify the sender immediately and do not disclose the contents = to > any > > other person, use it for any purpose, or store or copy the information= in > any > > medium. Thank you. > > > > >=20 > >