From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web10.47613.1685360506584652504 for ; Mon, 29 May 2023 04:41:46 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=oH4qB61B; spf=pass (domain: kernel.org, ip: 139.178.84.217, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1825E6101A for ; Mon, 29 May 2023 11:41:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7B2CAC433D2 for ; Mon, 29 May 2023 11:41:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685360505; bh=Jsqv9NRVNPbZGDLCnP7wGOkzvzCh0OaxuZA1GFrGaww=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=oH4qB61BOldohg9OJeyQG5sxGvSEmFkO0JiDEjyKlDCF24RVd1fr9sOf6zrFPTqu0 8c437iZqsstY29xtziHR33C7gFKYLjK2MNH4ilt81+ICG5XWzdL301LDawkbtTZVVq nGHGqhoIMpWnmiZRufxtpR/EdmxkRoGLqIkPUnwwCPuckRdbTB1vPzHhthGXiTkor1 NUpc7C1tk0pqhsEMO2pwHIau7M7WSJ0yZwGiiNWiajG5H9MkcmgiIRJaq4MC0pookL EaNZTjNpimJrO738TT+Jba/8epYctWHvRRsx8NSoik2bDsX1NJhF2TjbH8GenntH0O ITz2zROTeH1+w== Received: by mail-lf1-f47.google.com with SMTP id 2adb3069b0e04-4f4b2bc1565so3393443e87.2 for ; Mon, 29 May 2023 04:41:45 -0700 (PDT) X-Gm-Message-State: AC+VfDy0GK6kd3detq83u7D2vKus7dxVPsm68h+WJ9rM4659ZWVOLLQc MbRw5tTdxq5uIVP0q6Dsb5aJMcuWrfLc9ZfP7LE= X-Google-Smtp-Source: ACHHUZ4p6YOC4Xwc5L+JZWboq08CC4ebm6PSaVnvhX3fum9bw/AytwduU8OZLCZF4IDMQr41FBkcBiZpcx81JIPitiU= X-Received: by 2002:ac2:4a9a:0:b0:4f4:d41b:f42b with SMTP id l26-20020ac24a9a000000b004f4d41bf42bmr3561273lfp.32.1685360503501; Mon, 29 May 2023 04:41:43 -0700 (PDT) MIME-Version: 1.0 References: <20230524091117.302120-1-kraxel@redhat.com> <044df447-aacd-b4c7-7a58-301d2676e217@redhat.com> In-Reply-To: From: "Ard Biesheuvel" Date: Mon, 29 May 2023 13:41:32 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 1/1] OvmfPkg/PlatformPei: drop S3Verification() To: Laszlo Ersek Cc: Gerd Hoffmann , devel@edk2.groups.io, Rebecca Cran , Pawel Polawski , Oliver Steffen , Jordan Justen , Ard Biesheuvel , Ray Ni , Jiewen Yao Content-Type: text/plain; charset="UTF-8" On Wed, 24 May 2023 at 14:29, Ard Biesheuvel wrote: > > On Wed, 24 May 2023 at 14:28, Laszlo Ersek wrote: > > > > On 5/24/23 11:11, Gerd Hoffmann wrote: > > > Not needed any more, SMM + 64-bit PEI + S3 suspend works now. While > > > being at it also remove it from Bhyve (where it is dead code). > > > > > > Fixed by commits: > > > - 8bd2028f9ac3 ("MdeModulePkg: Supporting S3 in 64bit PEI") > > > - 6acf72901a2e ("UefiCpuPkg: Supporting S3 in 64bit PEI") > > > See also https://bugzilla.tianocore.org/show_bug.cgi?id=4195 > > > > > > Signed-off-by: Gerd Hoffmann > > > Reviewed-by: Ard Biesheuvel > > > Reviewed-by: Laszlo Ersek > > > Reviewed-by: Ray Ni > > > --- > > > OvmfPkg/Bhyve/PlatformPei/Platform.c | 29 -------------------------- > > > OvmfPkg/PlatformPei/Platform.c | 31 ---------------------------- > > > 2 files changed, 60 deletions(-) > > > > I disagree with this (v2) update. Bhyve platform code and QEMU platform > > code should not be fused into a common patch, if there's a way to avoid > > that. The reviewers for these C files are also different. If we want to > > modify Bhyve as a courtesy, we can certainly propose a *separate* patch > > for that. > > > > If others approve this patch, I can't block it from going in; since I've > > been CC'd (and I thought I'd comment this time), this is my view on it. > > > > Thanks Laszlo. I'll split them out when applying. Merged as #4441