From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by mx.groups.io with SMTP id smtpd.web10.8421.1661327388638154100 for ; Wed, 24 Aug 2022 00:49:49 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=u28aS+Ka; spf=pass (domain: kernel.org, ip: 145.40.68.75, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 87EE9B8238B for ; Wed, 24 Aug 2022 07:49:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 32150C433B5 for ; Wed, 24 Aug 2022 07:49:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1661327384; bh=K3sa/8dq1I6Fhbm9bpMJObQtjH11cgF1TDijKqC2pys=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=u28aS+Ka5kjqlHt+xp2PsbflZKMoOHf5ixThRgjU1HbQUCPfsNP5shV5gK0qoVYyK SPEdLBOy3sxwA8RMUNig9f+ltAU7H91XFJVSvjVxW9FMi6E7SnYZEWn96sjb+yySQG YfwZao2QOLggj2RMRvEvn1GGBNAqdboH8Ez/1g7EApAqAwmzTnh4JhSFU5H/TbqqcB 9AWFaBJb6rgkDaU2GQrJlXtkZYkuREr9k0QFcyksZhRci44sFqDA8vgsz7FLRzjFKQ 0cSSB7LMqD4tmcPum3IrMbemw+YXGgGpCu8aHZMgHrWfVcqh4L4Ok6X4gYOBy9G4s2 3rEOjL5AQ6EZQ== Received: by mail-wm1-f42.google.com with SMTP id z14-20020a7bc7ce000000b003a5db0388a8so1476623wmk.1 for ; Wed, 24 Aug 2022 00:49:44 -0700 (PDT) X-Gm-Message-State: ACgBeo2+WlPC7CdZXgAHgRrQy2RUbj4mKuIwXSQWBWBNem1xZ0RN0AWY azX13MbOxhB+S/8HdZEAnhOKKPIKp+E/mmTQMow= X-Google-Smtp-Source: AA6agR6n2a2qWZT8fR3qLMdvwXo7fa1rWxprmVGBn5znY6pZaYb2c1+SOm4GQgQ9YEWHvCPKWEmpp3fep6dlGx/y36o= X-Received: by 2002:a05:600c:3586:b0:3a5:fb24:a205 with SMTP id p6-20020a05600c358600b003a5fb24a205mr4478825wmq.77.1661327382419; Wed, 24 Aug 2022 00:49:42 -0700 (PDT) MIME-Version: 1.0 References: <41a26d57-4fae-f53f-29ae-d6c7b258eaee@bsdio.com> <000a01d8b693$58d87c60$0a897520$@byosoft.com.cn> In-Reply-To: From: "Ard Biesheuvel" Date: Wed, 24 Aug 2022 09:49:30 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] MdeModulePkg build fails for AARCH64 on Ubuntu 22.04 To: devel@edk2.groups.io, bob.c.feng@intel.com Cc: "Gao, Liming" , "rebecca@bsdio.com" , "Chen, Christine" , Andrew Fish , Leif Lindholm , "Kinney, Michael D" , "Wang, Jian J" Content-Type: text/plain; charset="UTF-8" On Tue, 23 Aug 2022 at 09:41, Bob Feng wrote: > > Hi Liming, > > Reverting patch may not a good idea, some platforms have done the implementation based on the DSC spec, if revert, those platforms build will break. Platforms implemented against the DSC spec would have never worked if they relied on behavior that BaseTools currently does not implement. > This commit 039bdb4d3e96f9c9264abf135b8a0eef2e2b4860 make the Basetools behavior be consistent with DSC spec so I don't think it's a regression bug. > Platforms built against the current behavior that used to work might break after this change. MdeModulePkg.dsc for ARM/AARCH64 no longer builds due to this change. Also, as I pointed out, the DSC spec is far from ambiguous. This means that platforms implemented against the spec will rely on one of several possible interpretations of that ambiguous set of rules. So let's revert this change now. Let's fix the DSC spec next, And only then, let's fix the code (assuming it still needs to be fixed) -- Ard.