From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mx.groups.io with SMTP id smtpd.web09.7705.1634209079382678116 for ; Thu, 14 Oct 2021 03:57:59 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=o2/MN4ml; spf=pass (domain: kernel.org, ip: 198.145.29.99, mailfrom: ardb@kernel.org) Received: by mail.kernel.org (Postfix) with ESMTPSA id A461861151 for ; Thu, 14 Oct 2021 10:57:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1634209078; bh=AzsrrlCKLrCbHpFCAthYXl8gzcmjQVZtZL9b68NGemI=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=o2/MN4mlxrZpCjcAGuYjIdb3r2qNlFBwZhexy+fdwwBhARJ4XMA/F2zcMPFWtyUPV W81qQTV6XoPeg9NTmBZozdvpnVuti6T4G1MQ/Y9aWwSDvBb+a+wtJ9O0KGklT6tPes ISCYqUilt1Qr8y6LhcF4FzjAgMHrpYaFNRVcP+Qx24py80/4NOA+pjD1aKCFS+0ud7 oijR5R9OVurld5+GRCRUEkvHxbiq2nCv/iEQiqeBvZ6R1BPj0elGixPwsSNAODso+D sClBZwgp5i7fmGASLGb+PGsXA9ArHNCCYcquhytsLnjTUK2RY6zGHjqLgzn1xIwSkA Ex5V4SkkwmgWw== Received: by mail-oi1-f177.google.com with SMTP id t4so7920511oie.5 for ; Thu, 14 Oct 2021 03:57:58 -0700 (PDT) X-Gm-Message-State: AOAM53015QudD56QtGr6by2C9G8MX985yax0wKOHyC9NQXaf/dNlEJpz Rw9yabAJXI+iPvhWNOOQbMQ8Z92ARwOxRr2rs7k= X-Google-Smtp-Source: ABdhPJxRihVh5v9yUAPhAVwjYYVWltHB7wMKf0JDOz5g0nYHltmKPnzMDwtg4hi/zZKmyssgvTo9BnCjy2lWfUhKCIs= X-Received: by 2002:aca:1712:: with SMTP id j18mr3445689oii.33.1634209077831; Thu, 14 Oct 2021 03:57:57 -0700 (PDT) MIME-Version: 1.0 References: <20210930004548.3033-1-abner.chang@hpe.com> <16AB2A90260D3DD8.20282@groups.io> <008d01d7bbf2$8de53ed0$a9afbc70$@byosoft.com.cn> <006601d7be3e$7477ff70$5d67fe50$@byosoft.com.cn> In-Reply-To: From: "Ard Biesheuvel" Date: Thu, 14 Oct 2021 12:57:46 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH V3 00/12] Migrate ArmVirtPkg modules to OvmfPkg To: "Chang, Abner (HPS SW/FW Technologist)" Cc: edk2-devel-groups-io , gaoliming , Ard Biesheuvel , Leif Lindholm , Sami Mujawar , Jiewen Yao , Jordan Justen , Gerd Hoffmann , "Schaefer, Daniel" , Sunil V L , Zhiguang Liu , Michael D Kinney Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 14 Oct 2021 at 12:14, Chang, Abner (HPS SW/FW Technologist) wrote: > > Hi Are, I am so sorry about that I just merged it two hours ago. Any proc= ess needed if we want to change the commit messages for adding your review = tag? > Don't worry about it. > ________________________________ > From: Ard Biesheuvel > Sent: Thursday, October 14, 2021 5:51:56 PM > To: edk2-devel-groups-io ; Chang, Abner (HPS SW/FW = Technologist) > Cc: gaoliming ; Ard Biesheuvel ; Leif Lindholm ; Sami Mujawar ; Jiewen Yao ; Jordan Justen ; Gerd Hoffmann ; Schaefer, Daniel ; Sunil V L ; Zhiguang Liu ; Michael D Kinney > Subject: Re: [edk2-devel] [PATCH V3 00/12] Migrate ArmVirtPkg modules to = OvmfPkg > > On Tue, 12 Oct 2021 at 06:17, Abner Chang wrote: > > > > Hi package maintainers, > > > > The review process of this patch set is almost done and please allow me= to merge it because the corresponding changes on edk2-platform is also req= uired to merge. > > > > > > > > Ard and Leif, do I need the Reviewed-by or Acked-by from either of you?= Or I can just proceed the merge process as Ard has no problem with this pa= tch set? > > > > > > Hi Abner, > > Where needed > > Acked-by: Ard Biesheuvel > > Feel free to merge it whenever convenient for you. > > > > > > From: gaoliming [mailto:gaoliming@byosoft.com.cn] > > Sent: Monday, October 11, 2021 9:22 AM > > To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) ; ardb@kernel.org > > Cc: 'Ard Biesheuvel' ; 'Leif Lindholm' ; 'Sami Mujawar' ; 'Jiewen Yao' ; 'Jordan Justen' ; 'Gerd Hoffman= n' ; Schaefer, Daniel ; 'Sunil = V L' ; 'Zhiguang Liu' ; '= Michael D Kinney' > > Subject: =E5=9B=9E=E5=A4=8D: [edk2-devel] [PATCH V3 00/12] Migrate ArmV= irtPkg modules to OvmfPkg > > > > > > > > The change in MdePkg is good to me. Reviewed-by: Liming Gao > > > > > > > > =E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io =E4=BB=A3=E8=A1=A8 Abner Chang > > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2021=E5=B9=B410=E6=9C=888=E6=97= =A5 11:39 > > =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io; gaoliming@byosoft.co= m.cn; ardb@kernel.org > > =E6=8A=84=E9=80=81: 'Ard Biesheuvel' ; 'Leif= Lindholm' ; 'Sami Mujawar' ; 'Jie= wen Yao' ; 'Jordan Justen' ; 'Gerd Hoffmann' ; Schaefer, Daniel ; 'Sunil V L' ; 'Zhiguang Liu' ; 'Michael D Kinney' > > =E4=B8=BB=E9=A2=98: Re: [edk2-devel] [PATCH V3 00/12] Migrate ArmVirtPk= g modules to OvmfPkg > > > > > > > > Thanks Liming, could you please also give the reviewed-by. > > > > > > > > Hi Ard, also need your reviewed-by for ArmPkg. Then this changes could = be upstream and finished. > > > > Thanks > > > > Abner > > > > > > > > > > > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of g= aoliming > > Sent: Friday, October 8, 2021 11:14 AM > > To: Chang, Abner (HPS SW/FW Technologist) ; 'edk2-= devel-groups-io' ; ardb@kernel.org > > Cc: 'Ard Biesheuvel' ; 'Leif Lindholm' ; 'Sami Mujawar' ; 'Jiewen Yao' ; 'Jordan Justen' ; 'Gerd Hoffman= n' ; Schaefer, Daniel ; 'Sunil = V L' ; 'Zhiguang Liu' ; '= Michael D Kinney' > > Subject: =E5=9B=9E=E5=A4=8D: [edk2-devel] [PATCH V3 00/12] Migrate ArmV= irtPkg modules to OvmfPkg > > > > > > > > Ard and Abner: > > > > I am OK to add these three PCDs PcdPciMmio32Translation, PcdPciMmio64T= ranslation, PcdPciIoTranslation to MdePkg. > > > > > > > > Thanks > > > > Liming > > > > =E5=8F=91=E4=BB=B6=E4=BA=BA: Chang, Abner (HPS SW/FW Technologist) > > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2021=E5=B9=B410=E6=9C=886=E6=97= =A5 17:27 > > =E6=94=B6=E4=BB=B6=E4=BA=BA: edk2-devel-groups-io ; ardb@kernel.org; Chang, Abner (HPS SW/FW Technologist) > > =E6=8A=84=E9=80=81: Ard Biesheuvel ; Leif Li= ndholm ; Sami Mujawar ; Jiewen Yao= ; Jordan Justen ; Gerd Ho= ffmann ; Schaefer, Daniel ; Sun= il V L ; Liming Gao ; Z= higuang Liu ; Michael D Kinney > > =E4=B8=BB=E9=A2=98: Re: [edk2-devel] [PATCH V3 00/12] Migrate ArmVirtPk= g modules to OvmfPkg > > > > > > > > Hi Ard, > > > > I realized there is a problem if we duplicate ArmPkg defined PCD to und= er OvmfPkg (e.g. PcdPciIoTranslate PCD) when I was duplicating this PCD to = OvmfPkg. > > > > FdtPciProducerLib is relocated to OvmfPkg/Fdt and uses PcdPciIoTranslat= e PCD declared with OvmfPkg namespace. FdtPciProducerLib is also used by bo= th ArmVirtPkg and RiscVVirtPkg. > > > > ArmVirtPkg uses ArmPciCpuIoDxe provided by ArmPkg however PcdPciIoTrans= late used by ArmPciCpuIoDxe is declared with ArmPkg namespace. > > > > I think this results in the problem because PcdPciIoTranslate(s) that a= re referred by ArmPkg and ArmVirtPkg come from two different namespaces, ri= ght? Unless ArmPciCpuIoDxe uses the one declared in OvmfPkg, but I don't th= ink we want to do this. > > > > Thought? Otherwise, we should still keep the original patch that reloca= tes these PCDs under MdePkg. > > > > > > > > Thanks > > > > Abner > > > > > > > > > > > > ________________________________ > > > > From: devel@edk2.groups.io on behalf of Abner Ch= ang > > Sent: Tuesday, October 5, 2021 11:00 PM > > To: edk2-devel-groups-io ; ardb@kernel.org > > Cc: Ard Biesheuvel ; Leif Lindholm ; Sami Mujawar ; Jiewen Yao ; Jordan Justen ; Gerd Hoffmann ; Schaefer, Daniel ; Sunil V L ; Liming Gao ; Zhiguang Liu ; Michael D Kinney > > Subject: Re: [edk2-devel] [PATCH V3 00/12] Migrate ArmVirtPkg modules t= o OvmfPkg > > > > > > > > Hi Ard, > > > > This way reduces the impact of MdePkg. We can try it. > > > > > > > > Thanks > > > > Abner > > > > > > > > ________________________________ > > > > From: devel@edk2.groups.io on behalf of Ard Bies= heuvel > > Sent: Tuesday, October 5, 2021 5:30 PM > > To: edk2-devel-groups-io ; Chang, Abner (HPS SW/F= W Technologist) > > Cc: Ard Biesheuvel ; Leif Lindholm ; Sami Mujawar ; Jiewen Yao ; Jordan Justen ; Gerd Hoffmann ; Schaefer, Daniel ; Sunil V L ; Liming Gao ; Zhiguang Liu ; Michael D Kinney > > Subject: Re: [edk2-devel] [PATCH V3 00/12] Migrate ArmVirtPkg modules t= o OvmfPkg > > > > > > > > On Thu, 30 Sept 2021 at 03:43, Abner Chang wrote: > > > > > > In V3: Address comments on V2. > > > In V2: Remove HPE license on the files that just moved around or > > > the changes in the file are just code removal. > > > > > > edk2 BZ #: 3665 > > > edk2 platform corresponding changes will be submitted after > > > this pactch set is reviewed. > > > > > > This pacthes set is to migrate some modules from ArmVirtPkg > > > to under OvmfPkg for the upcoming RiscVVirtPkg that can leverage > > > those modules without the dependency with Arm*Pkg. > > > > > > The modules moved from ArmVirtPkg to OvmfPkg are, > > > - FdtClientDxe > > > - PciPcdProducerLib > > > - HighMemDxe > > > - QemuFwCfgLib > > > - FdtPciHostBridgeLib > > > - VirtioFdtDxe > > > > > > Below PCDs are moved to under MdePkg and leverage by RiscVVirtPkg. > > > This change also remove the dependency on ArmPkg of OvmfPkg. > > > - PcdPciIoTranslation > > > - PcdPciIoTranslation > > > - PcdPciMmio32(64)Translation > > > > > > Signed-off-by: Abner Chang > > > Cc: Ard Biesheuvel > > > Cc: Leif Lindholm > > > Cc: Sami Mujawar > > > Cc: Jiewen Yao > > > Cc: Jordan Justen > > > Cc: Gerd Hoffmann > > > Cc: Daniel Schaefer > > > Cc: Sunil V L > > > Cc: Liming Gao > > > Cc: Zhiguang Liu > > > Cc: Michael D Kinney > > > > > > Abner Chang (12): > > > ArmVirtPkg/FdtClintDxe: Move FdtClientDxe to EmbeddedPkg > > > MdePkg: Add PcdPciIoTranslation PCD > > > ArmPkg: Use PcdPciIoTranslation PCD from MdePkg > > > ArmVirtPkg/FdtPciPcdProducerLib: Relocate PciPcdProducerLib to Ovmf= Pkg > > > ArmVirtPkg/HighMemDxe: Relocate HighMemDxe to OvmfPkg > > > OvmfPkg/HighMemDxe: Add RISC-V in the supported arch. > > > ArmVirtPkg/QemuFwCfgLib: Relocate QemuFwCfgLib to OvmfPkg > > > OvmfPkg/QemuFwCfgLibMMIO: Add RISC-V arch support > > > MdePkg: Add PcdPciMmio32(64)Translation PCDs > > > ArmVirtPkg/FdtPciHostBridgeLib: Relocate FdtPciHostBridgeLib to > > > OvmfPkg/Fdt > > > OvmfPkg/FdtPciHostBridgeLib: Add RISC-V in the supported arch. > > > ArmVirtPkg/VirtioFdtDxe: Relocate VirtioFdtDxe to OvmfPkg/Fdt > > > > > > > Hello all, > > > > These patches look ok to me, but I wonder if the MdePkg maintainers > > are happy taking these PCD declaration changes. Translations for PCIe > > are typically defined per host bridge, and I would rather move away > > from using PCDs for this entirely than 'promote' them by carrying them > > in MdePkg. > > > > As this issue is somewhat orthogonal to what Abner is trying to fix, > > perhaps it is better to avoid MdePkg changes for now, and just > > duplicate these PCDs into OvmfPkg. This is reasonable, given that we > > know that QEMU only exposes a single host bridge. > > > > The one in ArmPkg can hopefully be removed and replaced with something > > that is more appropriate. > > > > > > > ArmPkg/ArmPkg.dec | 15 ++++++-------- > > > ArmVirtPkg/ArmVirtPkg.dec | 3 --- > > > EmbeddedPkg/EmbeddedPkg.dec | 1 + > > > MdePkg/MdePkg.dec | 12 +++++++++++ > > > ArmVirtPkg/ArmVirtCloudHv.dsc | 18 ++++++++--------- > > > ArmVirtPkg/ArmVirtKvmTool.dsc | 18 ++++++++--------- > > > ArmVirtPkg/ArmVirtQemu.dsc | 20 +++++++++--------= -- > > > ArmVirtPkg/ArmVirtQemuKernel.dsc | 20 +++++++++--------= -- > > > ArmVirtPkg/ArmVirtXen.dsc | 2 +- > > > EmbeddedPkg/EmbeddedPkg.dsc | 1 + > > > ArmVirtPkg/ArmVirtCloudHv.fdf | 6 +++--- > > > ArmVirtPkg/ArmVirtKvmTool.fdf | 6 +++--- > > > ArmVirtPkg/ArmVirtXen.fdf | 2 +- > > > ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc | 6 +++--- > > > .../ArmPciCpuIo2Dxe/ArmPciCpuIo2Dxe.inf | 2 +- > > > .../ArmVirtGicArchLib/ArmVirtGicArchLib.inf | 1 + > > > .../ArmVirtPL031FdtClientLib.inf | 1 + > > > .../ArmVirtPsciResetSystemLib.inf | 1 + > > > .../ArmVirtTimerFdtClientLib.inf | 1 + > > > .../KvmtoolRtcFdtClientLib.inf | 1 + > > > .../NorFlashKvmtoolLib/NorFlashKvmtoolLib.inf | 1 + > > > .../NorFlashQemuLib/NorFlashQemuLib.inf | 1 + > > > .../XenAcpiPlatformDxe/XenAcpiPlatformDxe.inf | 1 + > > > ArmVirtPkg/XenioFdtDxe/XenioFdtDxe.inf | 1 + > > > .../Drivers}/FdtClientDxe/FdtClientDxe.inf | 1 - > > > .../FdtPciHostBridgeLib.inf | 11 +++++----- > > > .../FdtPciPcdProducerLib.inf | 5 ++--- > > > .../Fdt}/HighMemDxe/HighMemDxe.inf | 7 ++++--- > > > .../Fdt}/VirtioFdtDxe/VirtioFdtDxe.inf | 2 +- > > > .../Library/QemuFwCfgLib/QemuFwCfgLibMmio.inf | 6 +++--- > > > .../Include/Protocol/FdtClient.h | 0 > > > .../Drivers}/FdtClientDxe/FdtClientDxe.c | 0 > > > .../FdtPciHostBridgeLib/FdtPciHostBridgeLib.c | 0 > > > .../FdtPciPcdProducerLib.c | 0 > > > .../Fdt}/HighMemDxe/HighMemDxe.c | 3 ++- > > > .../Fdt}/VirtioFdtDxe/VirtioFdtDxe.c | 0 > > > .../Library/QemuFwCfgLib/QemuFwCfgLibMmio.c | 7 ++++--- > > > Maintainers.txt | 6 ++++++ > > > 38 files changed, 106 insertions(+), 83 deletions(-) > > > rename {ArmVirtPkg =3D> EmbeddedPkg/Drivers}/FdtClientDxe/FdtClientD= xe.inf (92%) > > > rename {ArmVirtPkg/Library =3D> OvmfPkg/Fdt}/FdtPciHostBridgeLib/Fdt= PciHostBridgeLib.inf (77%) > > > rename {ArmVirtPkg/Library =3D> OvmfPkg/Fdt}/FdtPciPcdProducerLib/Fd= tPciPcdProducerLib.inf (87%) > > > rename {ArmVirtPkg =3D> OvmfPkg/Fdt}/HighMemDxe/HighMemDxe.inf (83%) > > > rename {ArmVirtPkg =3D> OvmfPkg/Fdt}/VirtioFdtDxe/VirtioFdtDxe.inf (= 92%) > > > rename ArmVirtPkg/Library/QemuFwCfgLib/QemuFwCfgLib.inf =3D> OvmfPkg= /Library/QemuFwCfgLib/QemuFwCfgLibMmio.inf (86%) > > > rename {ArmVirtPkg =3D> EmbeddedPkg}/Include/Protocol/FdtClient.h (1= 00%) > > > rename {ArmVirtPkg =3D> EmbeddedPkg/Drivers}/FdtClientDxe/FdtClientD= xe.c (100%) > > > rename {ArmVirtPkg/Library =3D> OvmfPkg/Fdt}/FdtPciHostBridgeLib/Fdt= PciHostBridgeLib.c (100%) > > > rename {ArmVirtPkg/Library =3D> OvmfPkg/Fdt}/FdtPciPcdProducerLib/Fd= tPciPcdProducerLib.c (100%) > > > rename {ArmVirtPkg =3D> OvmfPkg/Fdt}/HighMemDxe/HighMemDxe.c (95%) > > > rename {ArmVirtPkg =3D> OvmfPkg/Fdt}/VirtioFdtDxe/VirtioFdtDxe.c (10= 0%) > > > rename ArmVirtPkg/Library/QemuFwCfgLib/QemuFwCfgLib.c =3D> OvmfPkg/L= ibrary/QemuFwCfgLib/QemuFwCfgLibMmio.c (93%) > > > > > > -- > > > 2.17.1 > > > > > > > > > > > > > > > > > > > > > >=20