From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web12.25073.1662386158524548642 for ; Mon, 05 Sep 2022 06:55:58 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=K1kj5gYh; spf=pass (domain: kernel.org, ip: 139.178.84.217, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1363D61137 for ; Mon, 5 Sep 2022 13:55:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 77160C433D6 for ; Mon, 5 Sep 2022 13:55:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662386157; bh=RBYPZ0xOIy7VS+ov4MIJqo5GaeqndEahnx1IQctYsvY=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=K1kj5gYhF3RH57Xz9DYn69iooYBy+QEyyuARXwcz4lblKSfo1mdDhhmOpuUuz0FD6 MfNhD78+uuu4M2QXT/DMAGs+spCIKKsx5pJEDDYn+OhhzLaDvfUwOKGFwDhi30npXk acgn3WMkblUVFoNx+E5ei6HdLqSstyNID718zow8YCSBv2ZZrwqFZXdU9Q70rECILM 0siRcZUt/BsaHys9tApyw5gsXlqWT65KsGFuAu2WVs4nx/VwgUzFt0dEgfp9r0+TSq rA6Kz9H6mCxRpVoeBlLzJz9eAAByM8/8xk4aJ0KT8M0OBM26HiKEBhledcr8bKTbUZ L0zxsiulmfjLQ== Received: by mail-lf1-f51.google.com with SMTP id br21so13337195lfb.0 for ; Mon, 05 Sep 2022 06:55:57 -0700 (PDT) X-Gm-Message-State: ACgBeo1pgBiaTsvJWrGE+D1MZRI/+qZYhp+FPurJ9bOBViqzcHvt1AhA AJ6qTxYvo5yG1xCVA627QLV9VZ3fpf4Xi8PW2ns= X-Google-Smtp-Source: AA6agR6Xzbvj5smaH1ySYgQIxqwiIUdjcJqE3RpMI3FpCCAmcsEkvPTn8vqX1i/vFJBT0wxZA3hQS+qBGFqUo3vBsoU= X-Received: by 2002:a05:6512:402:b0:494:78bb:f538 with SMTP id u2-20020a056512040200b0049478bbf538mr10115942lfk.637.1662386155538; Mon, 05 Sep 2022 06:55:55 -0700 (PDT) MIME-Version: 1.0 References: <20220810081140.158578-1-osteffen@redhat.com> <20220810081140.158578-2-osteffen@redhat.com> <20220815144717.uxzfgghjjuvnkf64@sirius.home.kraxel.org> In-Reply-To: <20220815144717.uxzfgghjjuvnkf64@sirius.home.kraxel.org> From: "Ard Biesheuvel" Date: Mon, 5 Sep 2022 15:55:44 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v1 1/1] OvmfPkg: increase max debug message length to 512 To: Gerd Hoffmann Cc: Oliver Steffen , devel@edk2.groups.io, Laszlo Ersek , Ard Biesheuvel , Eric Dong , Jiewen Yao , Jordan Justen , Rahul Kumar , Ray Ni Content-Type: text/plain; charset="UTF-8" On Mon, 15 Aug 2022 at 16:47, Gerd Hoffmann wrote: > > On Wed, Aug 10, 2022 at 10:11:40AM +0200, Oliver Steffen wrote: > > From: Laszlo Ersek > > > > Increase the maximum line length for debug messages. > > While log messages should be short, they can still > > get quite long, for example when printing device paths > > or config strings in HII routing. > > 512 chars is an empirically good value. > > > > Signed-off-by: Laszlo Ersek > > Signed-off-by: Oliver Steffen > > --- > > OvmfPkg/Library/PlatformDebugLibIoPort/DebugLib.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/OvmfPkg/Library/PlatformDebugLibIoPort/DebugLib.c b/OvmfPkg/Library/PlatformDebugLibIoPort/DebugLib.c > > index 4e25f198aa76..640627f38b72 100644 > > --- a/OvmfPkg/Library/PlatformDebugLibIoPort/DebugLib.c > > +++ b/OvmfPkg/Library/PlatformDebugLibIoPort/DebugLib.c > > @@ -21,7 +21,7 @@ > > // > > // Define the maximum debug and assert message length that this library supports > > // > > -#define MAX_DEBUG_MESSAGE_LENGTH 0x100 > > +#define MAX_DEBUG_MESSAGE_LENGTH 0x200 > > Acked-by: Gerd Hoffmann > Merged as #3287 > take care, > Gerd >