From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id D025CAC0FD4 for ; Tue, 23 Jul 2024 15:46:52 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=GXaYLp48TFYzL/QjSJ/vYjNtmpn2PmUfWbg/tBeByig=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20240206; t=1721749612; v=1; b=lsktjHdZXTikrx7T9gZ7gFXpZ9UjOFCT0lfkxyoU35RQom0OJ4YddjIfRQ0xjudL4+Y1LL2W ICvK9JeR1k/LlPFTP+GwKbh0+HQTuwgm/ID7jVJP6b5ijlZWvvoWoQm45iWwlfYHO7BfuLNgTxg wV4IMHLZJljhXDrkwVqunnp4NsdpkXy2o8y+gGATtgdz5M739100T5xU/luHIvQRCI+ldNSJNc6 LEqhvyhAW04X4aJfoZAX2WNgyhsB10ZRIjYaoqsONGe30c1+VmOC/jg4tx3oJ335QU/+qFfKlyO oBzHTQ6/CHrPiTh5BqeTeKzbFkV9fEHTCyGP+Yn5uE5NA== X-Received: by 127.0.0.2 with SMTP id xaWSYY7687511xOS1CtEt3CJ; Tue, 23 Jul 2024 08:46:51 -0700 X-Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web11.446.1721749610816036894 for ; Tue, 23 Jul 2024 08:46:50 -0700 X-Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 41A6761362 for ; Tue, 23 Jul 2024 15:46:50 +0000 (UTC) X-Received: by smtp.kernel.org (Postfix) with ESMTPSA id ED228C4AF13 for ; Tue, 23 Jul 2024 15:46:49 +0000 (UTC) X-Received: by mail-lj1-f169.google.com with SMTP id 38308e7fff4ca-2f025b94e07so7772421fa.0 for ; Tue, 23 Jul 2024 08:46:49 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCU6PVkhLPk7sqtyuELDy2sfjnntJZ7Rn0s36/WvI+gFVF+Oo++idwuyDF7BH/LlGbSFAYBmcG3rS4Y/XnXR+N2KsPjdgw== X-Gm-Message-State: eaFSrNm8tmJp3ZdBf2XoKQh0x7686176AA= X-Google-Smtp-Source: AGHT+IF6bQj8vBYkEyvKmoMqtyaXJDVlMgTCYEnWIIEswttZmd4W4c6S31pRVrgiaUCAdCxXnoXx4EmjlOEyXK4sykk= X-Received: by 2002:a2e:8803:0:b0:2ef:2e1c:79ae with SMTP id 38308e7fff4ca-2ef2e1c7c56mr54391011fa.19.1721749608210; Tue, 23 Jul 2024 08:46:48 -0700 (PDT) MIME-Version: 1.0 References: <20240721145155.324900-1-ardb+git@google.com> <20240721145155.324900-4-ardb+git@google.com> In-Reply-To: From: "Ard Biesheuvel" Date: Tue, 23 Jul 2024 17:46:37 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH edk2-platforms 3/4] Platform/Ampere: Switch to generic ResetRuntime DXE driver To: Leif Lindholm Cc: Ard Biesheuvel , devel@edk2.groups.io, Oliver Smith-Denny , Rebecca Cran , Nhi Pham , Chuong Tran , Peng Xie , Ling Jia , Yiqi Shu Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Tue, 23 Jul 2024 08:46:50 -0700 Resent-From: ardb@kernel.org Reply-To: devel@edk2.groups.io,ardb@kernel.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=lsktjHdZ; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io On Tue, 23 Jul 2024 at 17:32, Leif Lindholm wrote: > > On Sun, Jul 21, 2024 at 16:51:54 +0200, Ard Biesheuvel wrote: > > From: Ard Biesheuvel > > > > The reset runtime DXE driver is deprecated and will be removed soon. It > > is superseded by a generic implementation in MdeModulePkg, which is > > shared between all architectures, and implements the notification > > protocols that the EFI spec describes. So move the Ampere Jade platform > > to this implementation the of ResetSystem EFI runtime service. > > > > Signed-off-by: Ard Biesheuvel > > --- > > Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc | 3 +-- > > Platform/Ampere/JadePkg/Jade.fdf | 2 +- > > 2 files changed, 2 insertions(+), 3 deletions(-) > > > > diff --git a/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc b/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc > > index 1f705c68579a..fb170d436d00 100644 > > --- a/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc > > +++ b/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc > > @@ -259,7 +259,6 @@ [LibraryClasses.common.DXE_RUNTIME_DRIVER] > > !endif > > VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLibRuntimeDxe.inf > > > > - EfiResetSystemLib|ArmPkg/Library/ArmPsciResetSystemLib/ArmPsciResetSystemLib.inf > > Would it make sense to move the existing ResetSystemLib mapping here? > Not for any particular reason other than it's not actually used > anywhere else. There isn't an obvious reason imo why we would ever use another ResetSystemLib instance for other phases - the existing one is universal, i.e., it doesn't produce HOBs or consume PPIs or protocols and so it is usable from any context. So moving it here is possible but unnecessary. > Regardless, for the series: > Reviewed-by: Leif Lindholm > Cheers. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120015): https://edk2.groups.io/g/devel/message/120015 Mute This Topic: https://groups.io/mt/107476835/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-