Re: [PATCH 1/1] ArmPkg/SemihostFs: replace SetMem with ZeroMem

["Ard Biesheuvel" <ardb@kernel.org>]

On Thu, 9 Mar 2023 at 10:16, Gerd Hoffmann <kraxel@redhat.com> wrote:
>
> Ping.  Two reviews and the freeze is over.  Merge this now?
>

Pong. Thanks for the reminder - I'll go and merge this.

> On Wed, Feb 15, 2023 at 03:37:32PM +0100, Gerd Hoffmann wrote:
> > SetMem arguments 2+3 are in the wrong order, resulting in
> > the call having no effect because Length is zero.
> >
> > Fix this by using ZeroMem instead.
> >
> > Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=4205
> > Reported-by: Jeremy Boone <jeremy.boone@nccgroup.com>
> > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> > ---
> >  ArmPkg/Filesystem/SemihostFs/Arm/SemihostFs.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/ArmPkg/Filesystem/SemihostFs/Arm/SemihostFs.c b/ArmPkg/Filesystem/SemihostFs/Arm/SemihostFs.c
> > index 39a30533ee57..9cc9ed7d3637 100644
> > --- a/ArmPkg/Filesystem/SemihostFs/Arm/SemihostFs.c
> > +++ b/ArmPkg/Filesystem/SemihostFs/Arm/SemihostFs.c
> > @@ -574,7 +574,7 @@ ExtendFile (
> >    }
> >
> >    Remaining = Size;
> > -  SetMem (WriteBuffer, 0, sizeof (WriteBuffer));
> > +  ZeroMem (WriteBuffer, sizeof (WriteBuffer));
> >    while (Remaining > 0) {
> >      WriteNb   = MIN (Remaining, sizeof (WriteBuffer));
> >      WriteSize = WriteNb;
> > --
> > 2.39.1
> >
>
> --
>