From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web12.19867.1660677304318763423 for ; Tue, 16 Aug 2022 12:15:04 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=qucB7EUh; spf=pass (domain: kernel.org, ip: 139.178.84.217, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9BD5B6146E for ; Tue, 16 Aug 2022 19:15:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 09D1BC433D6 for ; Tue, 16 Aug 2022 19:15:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1660677303; bh=fJhCHVv8FuE9qwfyI+Zdue4Jkt5LtQ0Oiqtnz6SIeEw=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=qucB7EUh8GuWRoxWnCe9iLwosZMoi2Z95irWvF0mSoWjP37pEtI5fw6XeSjesSoec hSaWvawQAol6iy/mDi0puYWRaJ3BK1uqZWbT1YBLFXkrvEYlp4kwBF6CX0/rd5R+0V z31QtGbr1RtqE3eIrMjHkFtjBEwFgwVbelArzpPAr2RUyok2Q5ye5KHmbS92CegD10 4BlzRv4KtaZZFPO9PJf9p/HZqTxW7hSGKbF4JLlDbww1RNTvicdnucIaVvx3yeJZNi +nbQ6S5HA7O0oKYtgpImH8+5/Xhpb2smGl2kpIpvZyMmkESHNK2yEdWXrK28ECPh8n c7OpRbKG+J/fg== Received: by mail-wr1-f44.google.com with SMTP id n4so13709674wrp.10 for ; Tue, 16 Aug 2022 12:15:02 -0700 (PDT) X-Gm-Message-State: ACgBeo2rkH/YmVXotB/FeQtCJ+IQYVKAEOBrx7Ka8fmmnxpnF/lLzSa7 PhifLLquW2H+pv/wmsVh8Iw/27P8iJIxxUdmpKs= X-Google-Smtp-Source: AA6agR75xHfLGxwbDNg5ucXZxQ2ZVRBdMrRP2xKdq1PBkqq5gmPQyxhnPxYKA+x7w4xg/Lu/3bds71RgmQR4vvAbA7c= X-Received: by 2002:a5d:64a6:0:b0:21f:b3b:5cc9 with SMTP id m6-20020a5d64a6000000b0021f0b3b5cc9mr11839292wrp.601.1660677301242; Tue, 16 Aug 2022 12:15:01 -0700 (PDT) MIME-Version: 1.0 References: <20220815163119.2877228-1-dimitrije.pavlov@arm.com> In-Reply-To: From: "Ard Biesheuvel" Date: Tue, 16 Aug 2022 21:14:49 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 0/3] OvmfPkg: Check arguments for validity To: Sunny Wang Cc: Dimitrije Pavlov , "devel@edk2.groups.io" , Ard Biesheuvel , Jiewen Yao , Liming Gao , Jeff Booher-Kaeding , Samer El-Haj-Mahmoud Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 16 Aug 2022 at 13:39, Sunny Wang wrote: > > The series looks good to me. > Reviewed-by: Sunny Wang > > -----Original Message----- > From: Dimitrije Pavlov > Sent: 15 August 2022 17:31 > To: devel@edk2.groups.io > Cc: Ard Biesheuvel ; Jiewen Yao ; Liming Gao ; Sunny Wang ; Jeff Booher-Kaeding ; Samer El-Haj-Mahm= oud > Subject: [PATCH v2 0/3] OvmfPkg: Check arguments for validity > > Some functions across OVMF don't check pointer arguments for > validity, which causes null pointer dereferences and crashes > in the SCT test suite. > > This series adds checks to return EFI_INVALID_PARAMETER if a > pointer argument is NULL. > > v2: > - Add Liming Gao to Cc [Ard] > - Turn individual patches into a series [Ard] > - Fix issue with corrupted patches [Ard] > > Cc: Ard Biesheuvel > Cc: Jiewen Yao > Cc: Liming Gao > Cc: Sunny Wang > Cc: Jeff Booher-Kaeding > Cc: Samer El-Haj-Mahmoud > > Dimitrije Pavlov (3): > OvmfPkg/PlatformDxe: Check ExtractConfig and RouteConfig arguments > OvmfPkg/VirtioGpuDxe: Check QueryMode arguments > OvmfPkg/VirtioFsDxe: Check GetDriverName arguments > I tried to push these but they failed in CI. Could you please have a look and respin with the reported issues addressed? Thanks. https://github.com/tianocore/edk2/pull/3211