From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by mx.groups.io with SMTP id smtpd.web10.51145.1680257683548027353
 for <devel@edk2.groups.io>;
 Fri, 31 Mar 2023 03:14:43 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@kernel.org header.s=k20201202 header.b=feCjIgMR;
 spf=pass (domain: kernel.org, ip: 145.40.68.75, mailfrom: ardb@kernel.org)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by ams.source.kernel.org (Postfix) with ESMTPS id E23D9B82D20
	for <devel@edk2.groups.io>; Fri, 31 Mar 2023 10:14:41 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8B818C433D2
	for <devel@edk2.groups.io>; Fri, 31 Mar 2023 10:14:40 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1680257680;
	bh=HGGM7qsndiHkFr2tuAUxTBlVgJfkLrT9JKaCnpu7ch4=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=feCjIgMRCqbUMQnGnl7U2NsoJNuaRmCV/+3fUqtlkZkYpWws6zir/L7WSwNDHPs+2
	 77CEZjSyLVCmLcEzH1Migzwubadx/+sfMrmwmeq0XPk6X04D7LWG2/2p5jePsTHj+X
	 tek44DPBgqB+ZrJfAzkDReNaSMW5HTWTlpfx5h8Large73yK//KOW2aGEzVCMqsyAR
	 tqDopPn3f0Aj8yM7NsGOAmq5LOWKdjM4jZJcD0Xdu4AJUWEVIjPyD9gXINuoaLgt1D
	 xsZSVBW94b13rvGxi6/cEzNAvPh0lV7b20MbsT3MZh4ECCnpK57K7d7y9rFM+JF5FR
	 f5T6X42ZcYd3w==
Received: by mail-lf1-f45.google.com with SMTP id h25so28220772lfv.6
        for <devel@edk2.groups.io>; Fri, 31 Mar 2023 03:14:40 -0700 (PDT)
X-Gm-Message-State: AAQBX9dJqiTZM6UJRpoTLvCnMkv2bPyHxIMThOiM+klVEmXXOzS/tkRB
	XnWNNdiTLk8sYCaq9OIwDJnhA2Q2ugfBhp6rMRo=
X-Google-Smtp-Source: AKy350azRPrWAYfqunBDFbBd/w5eanfgby2ECV/qUSmgtBBSDrXLpagbB7I1GtQne4YDXfjl0/74H5XAiYqPXCD0DF8=
X-Received: by 2002:ac2:52b8:0:b0:4e9:d81f:9a8a with SMTP id
 r24-20020ac252b8000000b004e9d81f9a8amr7449346lfm.9.1680257678616; Fri, 31 Mar
 2023 03:14:38 -0700 (PDT)
MIME-Version: 1.0
References: <20230331091437.1593337-1-ardb@kernel.org> <20230331091437.1593337-3-ardb@kernel.org>
 <17517877FE72B326.27612@groups.io> <MN6PR11MB824469731FDD24690F3C3A298C8F9@MN6PR11MB8244.namprd11.prod.outlook.com>
In-Reply-To: <MN6PR11MB824469731FDD24690F3C3A298C8F9@MN6PR11MB8244.namprd11.prod.outlook.com>
From: "Ard Biesheuvel" <ardb@kernel.org>
Date: Fri, 31 Mar 2023 12:14:27 +0200
X-Gmail-Original-Message-ID: <CAMj1kXHMC0wtD8U0rK9mBBEFy01KP_g8WXou8KHcBa7w5gPTXw@mail.gmail.com>
Message-ID: <CAMj1kXHMC0wtD8U0rK9mBBEFy01KP_g8WXou8KHcBa7w5gPTXw@mail.gmail.com>
Subject: Re: [edk2-devel] [RFT PATCH v3 2/5] UefiCpuPkg/CpuExceptionHandlerLib: Use single SEC/PEI version
To: "Ni, Ray" <ray.ni@intel.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>, Andrew Fish <afish@apple.com>, 
	"Kinney, Michael D" <michael.d.kinney@intel.com>, "Liu, Zhiguang" <zhiguang.liu@intel.com>, 
	Rebecca Cran <rebecca@bsdio.com>, Tom Lendacky <thomas.lendacky@amd.com>, 
	=?UTF-8?Q?Marvin_H=C3=A4user?= <mhaeuser@posteo.de>
Content-Type: text/plain; charset="UTF-8"

On Fri, 31 Mar 2023 at 11:58, Ni, Ray <ray.ni@intel.com> wrote:
>
> By the way, which ("%" or "#") should be used for def check in NASM?
> I thought we need to use "%" but your patch uses "#".
>

The build rule for NASM files is

        Trim --asm-file -o ${d_path}(+)${s_base}.i -i $(INC_LIST) ${src}
        "$(PP)" $(DEPS_FLAGS) $(PP_FLAGS) $(INC) ${src} >
${d_path}(+)${s_base}.ii
        Trim --trim-long --source-code -o ${d_path}(+)${s_base}.iii
${d_path}(+)${s_base}.ii
        "$(NASM)" -I${s_path}(+) $(NASM_INC) $(NASM_FLAGS) -o $dst
${d_path}(+)${s_base}.iii

So the preprocessor $(PP) is executed first, which takes care of the #ifdefs