From: "Ard Biesheuvel" <ardb@kernel.org>
To: "Ni, Ray" <ray.ni@intel.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>,
"Wu, Hao A" <hao.a.wu@intel.com>,
Pawel Polawski <ppolawsk@redhat.com>,
Ard Biesheuvel <ardb+tianocore@kernel.org>,
"Albecki, Mateusz" <mateusz.albecki@intel.com>,
"Chang, Abner" <abner.chang@hpe.com>,
Leif Lindholm <quic_llindhol@quicinc.com>,
"Yao, Jiewen" <jiewen.yao@intel.com>,
Oliver Steffen <osteffen@redhat.com>,
"Gao, Liming" <gaoliming@byosoft.com.cn>,
"Wang, Jian J" <jian.j.wang@intel.com>,
"Justen, Jordan L" <jordan.l.justen@intel.com>
Subject: Re: [PATCH v7 1/6] MdeModulePkg/PciHostBridge: io range is not mandatory
Date: Thu, 2 Jun 2022 13:43:20 +0200 [thread overview]
Message-ID: <CAMj1kXHNh2B0+SH7U9kcCO7gAeYVaBBDdgRdZXP0PQBfhGmiqg@mail.gmail.com> (raw)
In-Reply-To: <MWHPR11MB16311F77B41CF02A3D6A2BBD8CDE9@MWHPR11MB1631.namprd11.prod.outlook.com>
On Thu, 2 Jun 2022 at 12:14, Ni, Ray <ray.ni@intel.com> wrote:
>
> Gerd,
> The fix should work. But I am curious why the if in blow is not hit.
> https://github.com/TianoCore/edk2/blob/master/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c#L922
>
> The RootBridge->ResAllocNode[TypeIo].Status is assigned as ResNone in:
> https://github.com/TianoCore/edk2/blob/master/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciRootBridgeIo.c#L263
>
> Or maybe your OVMF platform doesn't execute the above code path?
>
> Then I guess maybe the Base/Limit of Aperture is not set properly so that below if is hit?
> https://github.com/tianocore/edk2/blob/64706ef761273ba403f9cb3b7a986bfb804c0a87/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciRootBridgeIo.c#L249
>
I did a quick test with both ArmVirtQemu and microvm (using this
series but omitting the MdeModulePkg), and I can confirm that not
having a I/O resource window at all seems to work fine if none of the
PCI devices have I/O BARs.
Gerd, do you remember why exactly this patch is needed? Is it related
to devices that have I/O BARs but don't actually require them to
function correctly?
next prev parent reply other threads:[~2022-06-02 11:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-02 8:42 [PATCH v7 0/6] OvmfPkg/Microvm/pcie: add pcie support Gerd Hoffmann
2022-06-02 8:42 ` [PATCH v7 1/6] MdeModulePkg/PciHostBridge: io range is not mandatory Gerd Hoffmann
2022-06-02 10:14 ` Ni, Ray
2022-06-02 11:43 ` Ard Biesheuvel [this message]
2022-06-02 13:14 ` Gerd Hoffmann
2022-06-02 13:58 ` Ard Biesheuvel
2022-06-03 8:29 ` [edk2-devel] " Gerd Hoffmann
2022-06-03 8:30 ` Ard Biesheuvel
2022-06-02 8:42 ` [PATCH v7 2/6] OvmfPkg/FdtPciHostBridgeLib: " Gerd Hoffmann
2022-06-02 8:42 ` [PATCH v7 3/6] OvmfPkg/Platform: unfix PcdPciExpressBaseAddress Gerd Hoffmann
2022-06-02 8:42 ` [PATCH v7 4/6] OvmfPkg/Microvm/pcie: no vbeshim please Gerd Hoffmann
2022-06-02 8:42 ` [PATCH v7 5/6] OvmfPkg/Microvm/pcie: mPhysMemAddressWidth tweak Gerd Hoffmann
2022-06-02 8:42 ` [PATCH v7 6/6] OvmfPkg/Microvm/pcie: add pcie support Gerd Hoffmann
2022-06-03 9:12 ` [PATCH v7 0/6] " Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMj1kXHNh2B0+SH7U9kcCO7gAeYVaBBDdgRdZXP0PQBfhGmiqg@mail.gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox