From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mx.groups.io with SMTP id smtpd.web09.4052.1627404522848687354 for ; Tue, 27 Jul 2021 09:48:42 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=oC4+mPcU; spf=pass (domain: kernel.org, ip: 198.145.29.99, mailfrom: ardb@kernel.org) Received: by mail.kernel.org (Postfix) with ESMTPSA id 1691E6101C for ; Tue, 27 Jul 2021 16:48:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1627404522; bh=LCpSQki2FeLSTzYmcaCWBb1AlnxuGmNJsWOHKp833So=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=oC4+mPcU4P9Fi8U9qD5NhWj7gXyXZfXvBPc+xmo2kwzjJFdVPA0to7X/qwO8w6ka8 h4So4PFiuzWXm8T5OuUI5tzpupGgbDXgtvYOxSq47NR/ROzzKsNyTDElmmKgYn1tZl rCzMWvqI/0Vb+TGFuaD5RLS3MvBg3odIkYHf/5WIktsOhkOqHSrks5Eg7XSM5NqJR8 NFMFqAXtn1x8vk9TnuLxr043aUHa3aID4qm3dewLfT0S9YtVqGD5KzB+yX01QIUwxW v/2RMMunPDKTwYub9ZW8ZGdW53XULw4nCTkjGv77JoUwlicP6b1PLgJoGpI08u3OuU s38XmIqByqLvw== Received: by mail-ot1-f52.google.com with SMTP id i39-20020a9d17270000b02904cf73f54f4bso12238544ota.2 for ; Tue, 27 Jul 2021 09:48:42 -0700 (PDT) X-Gm-Message-State: AOAM533IdZ/uuK/g9LW/t4YyT7lhxlZtnHrtYW//HtmWTOQICZiqnHcX 8B9UQURcmVEpv5A+NZB3778rXPTbtEGJg89NQpI= X-Google-Smtp-Source: ABdhPJxRFQ+MujnLJBYeCPVkqBXZe8yd9z/tPMt1jfNSLd4hgBqSF59OTHR7/QqptbGkOsd+JGLxP9LFiKUAxkIk2lg= X-Received: by 2002:a05:6830:2316:: with SMTP id u22mr16166663ote.90.1627404521438; Tue, 27 Jul 2021 09:48:41 -0700 (PDT) MIME-Version: 1.0 References: <9f0e6ea44464ff942a4f808e8a21f0e37f6d06c0.1627404292.git.jbrasen@nvidia.com> In-Reply-To: <9f0e6ea44464ff942a4f808e8a21f0e37f6d06c0.1627404292.git.jbrasen@nvidia.com> From: "Ard Biesheuvel" Date: Tue, 27 Jul 2021 18:48:30 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 1/1] MdePkg: add definition of LINUX_EFI_INITRD_MEDIA_GUID To: Jeff Brasen Cc: edk2-devel-groups-io , Ard Biesheuvel , Michael Kinney , Jordan Justen , "Liming Gao (Byosoft address)" , Zhiguang Liu Content-Type: text/plain; charset="UTF-8" On Tue, 27 Jul 2021 at 18:45, Jeff Brasen wrote: > > Add LINUX_EFI_INITRD_MEDIA_GUID to our collection of GUID definitions, > it can be used in a media device path to specify a Linux style initrd > that can be loaded by the OS using the LoadFile2 protocol. > > Move these defines to MdePkg from OvmfPkg as these are relevant to > non-OVMF targets as well. > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2564 > Signed-off-by: Jeff Brasen Acked-by: Ard Biesheuvel > --- > MdePkg/MdePkg.dec | 5 ++++ > OvmfPkg/OvmfPkg.dec | 1 - > MdePkg/Include/Guid/LinuxEfiInitrdMedia.h | 31 ++++++++++++++++++++++ > OvmfPkg/Include/Guid/LinuxEfiInitrdMedia.h | 17 ------------ > 4 files changed, 36 insertions(+), 18 deletions(-) > create mode 100644 MdePkg/Include/Guid/LinuxEfiInitrdMedia.h > delete mode 100644 OvmfPkg/Include/Guid/LinuxEfiInitrdMedia.h > > diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec > index c5319fdd71ca..a28a2daaffa8 100644 > --- a/MdePkg/MdePkg.dec > +++ b/MdePkg/MdePkg.dec > @@ -818,6 +818,11 @@ [Guids] > # > gTianoCustomDecompressGuid = { 0xA31280AD, 0x481E, 0x41B6, { 0x95, 0xE8, 0x12, 0x7F, 0x4C, 0x98, 0x47, 0x79 }} > > + # > + # GUID used to provide initrd to linux via LoadFile2 protocol > + # > + gLinuxEfiInitrdMediaGuid = {0x5568e427, 0x68fc, 0x4f3d, {0xac, 0x74, 0xca, 0x55, 0x52, 0x31, 0xcc, 0x68}} > + > [Guids.IA32, Guids.X64] > ## Include/Guid/Cper.h > gEfiIa32X64ErrorTypeCacheCheckGuid = { 0xA55701F5, 0xE3EF, 0x43de, { 0xAC, 0x72, 0x24, 0x9B, 0x57, 0x3F, 0xAD, 0x2C }} > diff --git a/OvmfPkg/OvmfPkg.dec b/OvmfPkg/OvmfPkg.dec > index 6ae733f6e39f..3153f5ae4540 100644 > --- a/OvmfPkg/OvmfPkg.dec > +++ b/OvmfPkg/OvmfPkg.dec > @@ -118,7 +118,6 @@ [Guids] > gMicrosoftVendorGuid = {0x77fa9abd, 0x0359, 0x4d32, {0xbd, 0x60, 0x28, 0xf4, 0xe7, 0x8f, 0x78, 0x4b}} > gEfiLegacyBiosGuid = {0x2E3044AC, 0x879F, 0x490F, {0x97, 0x60, 0xBB, 0xDF, 0xAF, 0x69, 0x5F, 0x50}} > gEfiLegacyDevOrderVariableGuid = {0xa56074db, 0x65fe, 0x45f7, {0xbd, 0x21, 0x2d, 0x2b, 0xdd, 0x8e, 0x96, 0x52}} > - gLinuxEfiInitrdMediaGuid = {0x5568e427, 0x68fc, 0x4f3d, {0xac, 0x74, 0xca, 0x55, 0x52, 0x31, 0xcc, 0x68}} > gQemuKernelLoaderFsMediaGuid = {0x1428f772, 0xb64a, 0x441e, {0xb8, 0xc3, 0x9e, 0xbd, 0xd7, 0xf8, 0x93, 0xc7}} > gGrubFileGuid = {0xb5ae312c, 0xbc8a, 0x43b1, {0x9c, 0x62, 0xeb, 0xb8, 0x26, 0xdd, 0x5d, 0x07}} > gConfidentialComputingSecretGuid = {0xadf956ad, 0xe98c, 0x484c, {0xae, 0x11, 0xb5, 0x1c, 0x7d, 0x33, 0x64, 0x47}} > diff --git a/MdePkg/Include/Guid/LinuxEfiInitrdMedia.h b/MdePkg/Include/Guid/LinuxEfiInitrdMedia.h > new file mode 100644 > index 000000000000..0e7db8bd8140 > --- /dev/null > +++ b/MdePkg/Include/Guid/LinuxEfiInitrdMedia.h > @@ -0,0 +1,31 @@ > +/** @file > + GUID definition for the Linux Initrd media device path > + > + Linux distro boot generally relies on an initial ramdisk (initrd) > + which is provided by the loader, and which contains additional kernel > + modules (for storage and network, for instance), and the initial user > + space startup code, i.e., the code which brings up the user space side > + of the entire OS. > + > + In order to provide a standard method to locate this file, > + the GUID defined in this file is used to describe the device path > + for a LoadFile2 Protocol instance that is responsible for loading the initrd file. > + > + The kernel EFI Stub will locate and use this instance to load the initrd, > + therefore the firmware/loader should install an instance of this to load the > + relevant initrd. > + > + Copyright (c) 2020, Arm, Ltd. All rights reserved.
> + > + SPDX-License-Identifier: BSD-2-Clause-Patent > +**/ > + > +#ifndef LINUX_EFI_INITRD_MEDIA_GUID_H__ > +#define LINUX_EFI_INITRD_MEDIA_GUID_H__ > + > +#define LINUX_EFI_INITRD_MEDIA_GUID \ > + {0x5568e427, 0x68fc, 0x4f3d, {0xac, 0x74, 0xca, 0x55, 0x52, 0x31, 0xcc, 0x68}} > + > +extern EFI_GUID gLinuxEfiInitrdMediaGuid; > + > +#endif > diff --git a/OvmfPkg/Include/Guid/LinuxEfiInitrdMedia.h b/OvmfPkg/Include/Guid/LinuxEfiInitrdMedia.h > deleted file mode 100644 > index 83fc3fc79aa6..000000000000 > --- a/OvmfPkg/Include/Guid/LinuxEfiInitrdMedia.h > +++ /dev/null > @@ -1,17 +0,0 @@ > -/** @file > - GUID definition for the Linux Initrd media device path > - > - Copyright (c) 2020, Arm, Ltd. All rights reserved.
> - > - SPDX-License-Identifier: BSD-2-Clause-Patent > -**/ > - > -#ifndef LINUX_EFI_INITRD_MEDIA_GUID_H__ > -#define LINUX_EFI_INITRD_MEDIA_GUID_H__ > - > -#define LINUX_EFI_INITRD_MEDIA_GUID \ > - {0x5568e427, 0x68fc, 0x4f3d, {0xac, 0x74, 0xca, 0x55, 0x52, 0x31, 0xcc, 0x68}} > - > -extern EFI_GUID gLinuxEfiInitrdMediaGuid; > - > -#endif > -- > 2.25.1 >