From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 8B5E0780667 for ; Tue, 12 Mar 2024 16:50:20 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=yf535q1358UE4I0cNZMf46HFVD7RM1PaiokvsV4HxzE=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20240206; t=1710262219; v=1; b=UaFM3YGYLA0TZn3U9g7JVyPxEYfNwc0pd8RGlqkUPS19gosPpd+F67v6wrVTweD7gpEXQ3gL 506PAO7OFoKrIuD/Kzpg4bOsas+qDpV2lwsq7LnqFpbQNieWRAoXHje6ANBdWWxLbjM2Im8aAt4 6KYEx9P6/+AF4s3ai+rCGSdFVL9pdryuo+jaQfO4AWQmkmY1VV5HUl+Yaj/av/XcWIB9EwFXIny XYonpmAMf4SxofNpoewPGXNzaz3zsl7u1ouUGbK8mk2Hi9qtPSusLBHMzvJqtAw2IP/QIc6v1ek rdratlCXK8qtWX4lUeurf1Ood9pE89BB3Qw3pn1KW8OWQ== X-Received: by 127.0.0.2 with SMTP id WzkiYY7687511xLJ1EK0vQ8B; Tue, 12 Mar 2024 09:50:19 -0700 X-Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by mx.groups.io with SMTP id smtpd.web11.1500.1710262218329844758 for ; Tue, 12 Mar 2024 09:50:18 -0700 X-Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 7DFABCE138F for ; Tue, 12 Mar 2024 16:50:15 +0000 (UTC) X-Received: by smtp.kernel.org (Postfix) with ESMTPSA id B9776C43390 for ; Tue, 12 Mar 2024 16:50:14 +0000 (UTC) X-Received: by mail-lj1-f172.google.com with SMTP id 38308e7fff4ca-2d40fe2181dso53858641fa.1 for ; Tue, 12 Mar 2024 09:50:14 -0700 (PDT) X-Gm-Message-State: 0h0dWVX0T8mRIxYl54QxFHNNx7686176AA= X-Google-Smtp-Source: AGHT+IHsHSwo2QSHbq/B8uyBcxfuqoWKi0hMUGnhiSfrt3DqUNfiBYhERHPjXBk1K3gIItIsxOvWbJUN9VmS0fD50v0= X-Received: by 2002:a2e:8542:0:b0:2d4:3e96:47ee with SMTP id u2-20020a2e8542000000b002d43e9647eemr4104632ljj.26.1710262212953; Tue, 12 Mar 2024 09:50:12 -0700 (PDT) MIME-Version: 1.0 References: <20240312151716.2154180-1-ardb+git@google.com> <74a4fb99-5d29-44ac-93bd-caea7367d08e@quicinc.com> In-Reply-To: <74a4fb99-5d29-44ac-93bd-caea7367d08e@quicinc.com> From: "Ard Biesheuvel" Date: Tue, 12 Mar 2024 17:50:01 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH 1/1] EmbeddedPkg/NonCoherentIoMmuDxe: Make SetAttributes always succeed To: Leif Lindholm Cc: devel@edk2.groups.io, jeremy.linton@arm.com, abner.chang@amd.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Tue, 12 Mar 2024 09:50:18 -0700 Reply-To: devel@edk2.groups.io,ardb@kernel.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=UaFM3YGY; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Tue, 12 Mar 2024 at 17:38, Leif Lindholm wrote: > > On 2024-03-12 08:17, Ard Biesheuvel wrote: > > From: Ard Biesheuvel > > > > NonCoherentIoMmuSetAttribute() does nothing except return > > EFI_UNSUPPORTED. This was fine when it was introduced, but now, the PCI > > bus driver will fail a PCI I/O Map() operation if the SetAttributes > > fails. > > > > So return EFI_SUCCESS instead. > > It's unclear to me why this change is safe (looking forward). > Does NonCoherentIoMmuDxe also imply no IoMmu actually exists? > Basically. NonCoherentIoMmuDxe is just a vehicle to allow NonCoherentDmaLib to be plugged into the PCI host bridge driver. It is not intended to ever do anything more than that. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116693): https://edk2.groups.io/g/devel/message/116693 Mute This Topic: https://groups.io/mt/104886877/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-