From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 6DBF6D80320 for ; Fri, 13 Oct 2023 10:13:11 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=/TjTELy8KpQB5+wMzEWiS9++idf86oZLmWMDmfG3/C8=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1697191990; v=1; b=gDL9F1udi4ZYf0pVBhFPK1v69CRVS5Lt9r+ciU8AaWqE6wuayA1kmUEUOuWlOIvc5sdd9zRR 8pV1UQ1Ofs5Ck6beGN/zi6xZsrpUYvU2dBpQK6m1WLkiEj/olbi2BOv+HyqzzBIj5sdltuX/wft Bg8dYBWHcGDNMCU+EnOJM7XQ= X-Received: by 127.0.0.2 with SMTP id 9VYSYY7687511xJ2SKcwKXC3; Fri, 13 Oct 2023 03:13:10 -0700 X-Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web11.35232.1697191989347470824 for ; Fri, 13 Oct 2023 03:13:09 -0700 X-Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id B096D62077 for ; Fri, 13 Oct 2023 10:13:08 +0000 (UTC) X-Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1F519C43397 for ; Fri, 13 Oct 2023 10:13:08 +0000 (UTC) X-Received: by mail-lj1-f181.google.com with SMTP id 38308e7fff4ca-2c1807f3400so22169161fa.1 for ; Fri, 13 Oct 2023 03:13:08 -0700 (PDT) X-Gm-Message-State: 6ebqeEu1csFbg26J93BTBx3ux7686176AA= X-Google-Smtp-Source: AGHT+IGg+SzZ9FzEflAbVvW9CibBWblw+acioS9J0H4f5QxQ3/9pAXgnyr0Fh2nbk0QPQK5kPVYJxGTvvtIvhSPyZoY= X-Received: by 2002:a2e:9bd8:0:b0:2bc:d059:bc08 with SMTP id w24-20020a2e9bd8000000b002bcd059bc08mr18717296ljj.6.1697191986235; Fri, 13 Oct 2023 03:13:06 -0700 (PDT) MIME-Version: 1.0 References: <687bbaf5-3c2b-6d27-44a5-d19541ce97bd@redhat.com> <20231012090950.108577-1-lersek@redhat.com> In-Reply-To: <20231012090950.108577-1-lersek@redhat.com> From: "Ard Biesheuvel" Date: Fri, 13 Oct 2023 12:12:55 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [edk2-platforms PATCH 00/19] let LibRtcVirtualNotifyEvent() be dropped To: devel@edk2.groups.io, lersek@redhat.com Cc: Ard Biesheuvel , Bibo Mao , Chao Li , Chuong Tran , Leif Lindholm , Ling Jia , Marcin Wojtas , Masami Hiramatsu , Meenakshi Aggarwal , Nhi Pham , Peng Xie , Rebecca Cran , Wenyi Xie , Xianglai li , Yiqi Shu Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ardb@kernel.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=gDL9F1ud; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) On Thu, 12 Oct 2023 at 11:10, Laszlo Ersek wrote: > > https://bugzilla.tianocore.org/show_bug.cgi?id=4564 > > The RealTimeClockLib class header in edk2's EmbeddedPkg mistakenly > declares a function called LibRtcVirtualNotifyEvent(). No component ever > calls this function across module boundaries; all RealTimeClockLib > instances in edk2 and edk2-platforms are supposed to register -- and do > register -- their SetVirtualAddressMap() notification functions. > > In a sibling series for edk2, we're going to remove the > LibRtcVirtualNotifyEvent() API from the RealTimeClockLib *class* header. > In edk2-platforms, that means the following: > > (1) Fix existent (independent) build failures / bitrot. This is a > pre-requisite for showing that the other changes don't regress the > build. Build regression testing is only possible if you have a build > that completes in the first place. > > Patch #1 enables the NOOPT target for Hisilicon platforms, so that they > can be more quickly built: Hisilicon needs several fixes for existent > build issues. Patches #2 through #7 fix those issues. > > In particular patch#4 ("Hisilicon: rename OemMiscLib class to > HisiOemMiscLib") requires an ek2-non-osi complement; please see that in > the sibling edk2-non-osi posting ("Hisilicon: rename OemMiscLib class > dependencies to HisiOemMiscLib"). > > Patch #12 fixes prior build breakage in AmpereAltraPkg. > > (2) In those RealTimeClockLib instances that define > LibRtcVirtualNotifyEvent(), demonstrate that either (a) the usage is > module-internal, or (b) there is no usage. > > In case (a), rename LibRtcVirtualNotifyEvent() to VirtualNotifyEvent(), > and make it static. If needed, hoist the function definition above the > reference. In case (b), remove the function definition. > > (3) Some affected RealTimeClockLib instances turn out to be entirely > unused / superfluous; drop those altogether. > > Cc: Ard Biesheuvel > Cc: Bibo Mao > Cc: Chao Li > Cc: Chuong Tran > Cc: Leif Lindholm > Cc: Ling Jia > Cc: Marcin Wojtas > Cc: Masami Hiramatsu > Cc: Meenakshi Aggarwal > Cc: Nhi Pham > Cc: Peng Xie > Cc: Rebecca Cran > Cc: Wenyi Xie > Cc: Xianglai li > Cc: Yiqi Shu > > Thanks > Laszlo > > Laszlo Ersek (19): > Hisilicon: enable NOOPT builds > Hisilicon/FlashFvbDxe: fix PcdNorFlashCheckBlockLocked token space > GUID > Hisilicon.dsc.inc: resolve VariableFlashInfoLib > Hisilicon: rename OemMiscLib class to HisiOemMiscLib > Hisilicon: add missing include file to Pptt components > Hisilicon/Hi1620AcpiTables: fix up ASL > Hisilicon/ProcessorSubClassDxe: drop conflicting PROCESSOR_STATUS_DATA > type > Hisilicon: drop unused DS3231RealTimeClockLib instance > Hisilicon: drop unused VirtualRealTimeClockLib instance > Hisilicon/DS3231RealTimeClockLib: drop LibRtcVirtualNotifyEvent > Hisilicon/RX8900RealTimeClockLib: drop LibRtcVirtualNotifyEvent > AmpereAltraPkg/Ac01PcieLib: fix compilation error > JadePkg/PCF85063RealTimeClockLib: hide LibRtcVirtualNotifyEvent > LoongArchQemuPkg/LsRealTimeClockLib: hide LibRtcVirtualNotifyEvent > Styx/RealTimeClockLib: hide LibRtcVirtualNotifyEvent > Armada7k8k/RealTimeClockLib: hide LibRtcVirtualNotifyEvent > NXP/Pcf8563RealTimeClockLib: hide LibRtcVirtualNotifyEvent > FT2000-4Pkg/RealTimeClockLib: hide LibRtcVirtualNotifyEvent > Omap35xxPkg/RealTimeClockLib: drop LibRtcVirtualNotifyEvent > Thanks a lot for cleaning this up! For the series, Reviewed-by: Ard Biesheuvel Pushed as d6e36a151ff8..06f6274d5642 edk2-non-osi patch pushed as d6e36a151ff8..06f6274d5642 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109584): https://edk2.groups.io/g/devel/message/109584 Mute This Topic: https://groups.io/mt/101914650/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-