From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by mx.groups.io with SMTP id smtpd.web10.14843.1683720630863090044
 for <devel@edk2.groups.io>;
 Wed, 10 May 2023 05:10:30 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@kernel.org header.s=k20201202 header.b=I06LvIcS;
 spf=pass (domain: kernel.org, ip: 139.178.84.217, mailfrom: ardb@kernel.org)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by dfw.source.kernel.org (Postfix) with ESMTPS id 63EF7648DB
	for <devel@edk2.groups.io>; Wed, 10 May 2023 12:10:30 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8BF77C4339B
	for <devel@edk2.groups.io>; Wed, 10 May 2023 12:10:29 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1683720629;
	bh=JYFQywHLR6VYKKH2NeGPkwfVdX0E1Lun1F8u3gLe2QY=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=I06LvIcSENrioIRXibWWlJcgghz8RKtugZLnBlYcZ+NWFnPKMv9Cbu+wVWyAP+CRR
	 ca+Cp2e4l65WlEdyyC047QfESftjs7lBamP2qrO1xvJiSte3wycUcwRENncOJft0QG
	 Jx1/KLNV2v5HBkduIxhjdE8FwGzXfRDMAt4PpXPa3BWp90L2aFqFNX78fJ6oRIxMm5
	 4QWmKSwTP32Up98NOvXgp742xoOtwE5XmgmkhW7L1kFtV2J6tFVS19ssWVVu9Tq+Qw
	 sca6A7Wdp94aoHcJnOdgpM1H8uLr0EssgulKi+pjSrIqSyNot0Fy9nf+naO0Ec1XjZ
	 OmlH35s4A98lA==
Received: by mail-lj1-f171.google.com with SMTP id 38308e7fff4ca-2acb6571922so53264201fa.0
        for <devel@edk2.groups.io>; Wed, 10 May 2023 05:10:29 -0700 (PDT)
X-Gm-Message-State: AC+VfDwgd3ZCRDEFlzHRHSx40z+LyLeA18iASUo6xSr2wPHhEK/1qGmY
	OiGu1NuoBOZQo5tNTDJp2aHBsn23vY2l6yj1hbs=
X-Google-Smtp-Source: ACHHUZ51bq6mHWMcOgczGA34eXOEm/vz63htkMAKlCyyvkI9zQIOfcgro0/naRU6fGNXJghCTxW0bn7AYUU4Kei9BdU=
X-Received: by 2002:a2e:b04c:0:b0:293:4b91:eb44 with SMTP id
 d12-20020a2eb04c000000b002934b91eb44mr1961358ljl.38.1683720627631; Wed, 10
 May 2023 05:10:27 -0700 (PDT)
MIME-Version: 1.0
References: <20230509235337.1815842-1-rebecca@bsdio.com> <20230509235337.1815842-3-rebecca@bsdio.com>
 <CAMj1kXGkQyiRa_fojeK-o_=wbrzkHsvnGxOOKKJyK+O8_a2sDA@mail.gmail.com> <9d398003-436a-0d99-66b5-17a84eb62e34@bsdio.com>
In-Reply-To: <9d398003-436a-0d99-66b5-17a84eb62e34@bsdio.com>
From: "Ard Biesheuvel" <ardb@kernel.org>
Date: Wed, 10 May 2023 14:10:16 +0200
X-Gmail-Original-Message-ID: <CAMj1kXHQOoDkTr6AaUuPik7KKQk+V1qDuW+6=j5wQJQF1aJs_w@mail.gmail.com>
Message-ID: <CAMj1kXHQOoDkTr6AaUuPik7KKQk+V1qDuW+6=j5wQJQF1aJs_w@mail.gmail.com>
Subject: Re: [edk2-devel] [edk2-stable202305 PATCH 2/4] BaseTools: Set the CLANGDWARF OBJCOPY path in tools_def.template
To: Rebecca Cran <rebecca@bsdio.com>
Cc: devel@edk2.groups.io, Liming Gao <gaoliming@byosoft.com.cn>, 
	Bob Feng <bob.c.feng@intel.com>, Yuwei Chen <yuwei.chen@intel.com>
Content-Type: text/plain; charset="UTF-8"

On Wed, 10 May 2023 at 14:09, Rebecca Cran <rebecca@bsdio.com> wrote:
>
> On 5/10/23 05:03, Ard Biesheuvel wrote:
> > On Wed, 10 May 2023 at 01:53, Rebecca Cran <rebecca@bsdio.com> wrote:
> >> Set the OBJCOPY path for the CLANGDWARF toolchain to 'llvm-objcopy' to
> >> override the default of 'echo'.
> >>
> >> Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
> > This appears to break the AArch64 CLANGDWARF build.
> >
> > https://ci.linaro.org/job/leg-virt-tianocore-edk2-upstream/4880/console
>
> Ugh, I'm sorry. We're not overriding the OBJCOPY_FLAGS for ARM and
> AARCH64, so it uses the default of "not needed for" which previously got
> echoed.
>
> I'll work on a better local testing process to avoid such an obvious
> breakage in future.
>
>
> Would you like this commit reverted, or should I submit a patch to fix it?
>

No revert necessary - it should be a minimal fix, and we can just
apply it on top.