From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 8FB8ED80F9A for ; Wed, 18 Oct 2023 13:44:40 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=HXsvUta20eGux+x/fTto3EhLYPj0y5k14e/QTKuEzw0=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1697636679; v=1; b=clS28RQV6gNXnTvXqBFSBFjZq/54HRNGceyYsU1IYwSVaW/zrUHu8DvTaEMSUw2UBA7UQayH TjMx295fKxIMJyuNryXxjNwoYeLsGlC6yGF+sTyNOn2RBEODssFCFN0agKoX/oTi5ZtahtGRhhq Rmy7//jLA5XVMVZLnedy/+ak= X-Received: by 127.0.0.2 with SMTP id Uex8YY7687511xwx7sKl3iUx; Wed, 18 Oct 2023 06:44:39 -0700 X-Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web11.281551.1697636678659322817 for ; Wed, 18 Oct 2023 06:44:38 -0700 X-Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 20261617EA for ; Wed, 18 Oct 2023 13:44:38 +0000 (UTC) X-Received: by smtp.kernel.org (Postfix) with ESMTPSA id C6498C433CC for ; Wed, 18 Oct 2023 13:44:37 +0000 (UTC) X-Received: by mail-lj1-f173.google.com with SMTP id 38308e7fff4ca-2c504a5e1deso82719461fa.2 for ; Wed, 18 Oct 2023 06:44:37 -0700 (PDT) X-Gm-Message-State: S1oqv6JqS8VPtG1TefgczX3rx7686176AA= X-Google-Smtp-Source: AGHT+IHM7R+CWWzZubsjCD797z4S3Irn9IT4sHF1mtuLtoMA6MR7KBLbwIRaCOKKlKOWtBeoIIdzre2hp8YpzMfYM7s= X-Received: by 2002:a2e:b8d6:0:b0:2c5:1a89:41c0 with SMTP id s22-20020a2eb8d6000000b002c51a8941c0mr4212194ljp.23.1697636675972; Wed, 18 Oct 2023 06:44:35 -0700 (PDT) MIME-Version: 1.0 References: <687bbaf5-3c2b-6d27-44a5-d19541ce97bd@redhat.com> <20231012091057.108728-1-lersek@redhat.com> In-Reply-To: From: "Ard Biesheuvel" Date: Wed, 18 Oct 2023 15:44:24 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH 0/5] EmbeddedPkg/RealTimeClockLib: drop LibRtcVirtualNotifyEvent from lib class To: devel@edk2.groups.io, lersek@redhat.com Cc: Abner Chang , Ard Biesheuvel , Daniel Schaefer , Leif Lindholm , Ray Ni Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ardb@kernel.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=clS28RQV; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) On Wed, 18 Oct 2023 at 15:43, Laszlo Ersek wrote: > > On 10/12/23 11:10, Laszlo Ersek wrote: > > https://bugzilla.tianocore.org/show_bug.cgi?id=4564 > > > > The RealTimeClockLib class header in edk2's EmbeddedPkg mistakenly > > declares a function called LibRtcVirtualNotifyEvent(). No component ever > > calls this function across module boundaries; all RealTimeClockLib > > instances in edk2 and edk2-platforms are supposed to register -- and do > > register -- their SetVirtualAddressMap() notification functions. > > > > After the edk2-platforms and edk2-non-osi changes, we can repeat the > > procedure form the edk2-platforms series in edk2. In those > > RealTimeClockLib instances that define LibRtcVirtualNotifyEvent(), > > demonstrate that either (a) the usage is module-internal, or (b) there > > is no usage. In case (a), rename LibRtcVirtualNotifyEvent() to > > VirtualNotifyEvent(), and make it static. In case (b), remove the > > function definition. > > > > There is a superficial name match in > > PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe. Note that that module is a > > *driver*, not a library instance; what's more, > > PcatRealTimeClockRuntimeDxe does not depend on "EmbeddedPkg.dec" at all. > > Treat that module too as case (a), right at the front of the series. > > > > Finally, drop the LibRtcVirtualNotifyEvent() API declaration. > > > > Cc: Abner Chang > > Cc: Ard Biesheuvel > > Cc: Daniel Schaefer > > Cc: Leif Lindholm > > Cc: Ray Ni > > Can I get an ACK for the last three (EmbeddedPkg) patches? > For the series, Reviewed-by: Ard Biesheuvel > > > > Laszlo Ersek (5): > > PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe: rename > > LibRtcVirtualNotifyEvent > > ArmPlatformPkg/PL031RealTimeClockLib: hide LibRtcVirtualNotifyEvent > > EmbeddedPkg/TemplateRealTimeClockLib: drop LibRtcVirtualNotifyEvent > > EmbeddedPkg/VirtualRealTimeClockLib: drop LibRtcVirtualNotifyEvent > > EmbeddedPkg/RealTimeClockLib: drop LibRtcVirtualNotifyEvent from lib > > class > > > > ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeClockLib.c | 5 ++-- > > EmbeddedPkg/Include/Library/RealTimeClockLib.h | 15 ------------ > > EmbeddedPkg/Library/TemplateRealTimeClockLib/RealTimeClockLib.c | 24 -------------------- > > EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.c | 18 --------------- > > PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcRtcEntry.c | 5 ++-- > > 5 files changed, 6 insertions(+), 61 deletions(-) > > > > > > base-commit: 95c9f470ca6eab23bfd016bd438f932d7263d395 > > > > > > > > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109752): https://edk2.groups.io/g/devel/message/109752 Mute This Topic: https://groups.io/mt/101914677/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-